-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New menu config #52
Comments
Thanks for testing. |
3.: The thing is that you end up having wrong URLs if you have a typo (--> model doesn't exist). On the other hands, it's pretty easy to check for typos in links by just testing them :) 4.: Yeah don't do the |
Also improved tests for model activation
Could you please test latest version? |
Awesome! Works perfectly. |
…del linked apps
Also improved tests for model activation
…pen links in new window
…del linked apps
Also improved tests for model activation
…pen links in new window
First feedback: AWESOME! This is really great stuff. Works very well! A few minor things:
'url': 'app.model'
, the active menu item is only highlighted on the model list page, not on instance edit form pages.'/'
is a good indicator for a separator. Why not use something explicit, maybe'SPACER'
or'---'
?'url': 'app.model'
seems a bit like magic to me: If the model in question is not found, you'll just the get URL/app.model/
as link target. I suggest making things more explicit here too, maybe using'model': 'myapp.mymodel'
.The text was updated successfully, but these errors were encountered: