Django CMS support #77

Open
darklow opened this Issue Apr 5, 2013 · 9 comments

Comments

Projects
None yet
6 participants
@darklow
Owner

darklow commented Apr 5, 2013

Django CMS support

Since Django Suit v0.2.0 Django CMS support is included.

Supported Django Cms versions

Django Suit currently supports Django CMS 2.3.5 and 2.4.x versions.
Note: Some features like row styling (see preview below) are available only in 2.4.x version.

Issues

Report issues/questions related to beta version here in this issue or irc.
To discuss some ideas or chat - join us at #django-suit on irc.freenode.net

Known issues

  • Left menu and submit buttons takes extra horizontal space and content may not fit on smaller screens, therefore there will be horizontal menu layout sub-theme available very soon, that will give you an extra width for content.
  • Some CSS files used in plugin edit iframes are caching "too good" (Full reload doesn't affect iframe), therefore only emptying browser cache will help browser "to forget" django-cms original css files and load new ones.

Preview

Live Demo: http://djangosuit.com/admin/cms/page/

List (django-cms v2.4.0-beta):

image

Change form:

image

@maartendraijer

This comment has been minimized.

Show comment
Hide comment
@maartendraijer

maartendraijer Apr 5, 2013

Sweet! Very nice! Will test is as soon as possible (this weekend most likely).

Sweet! Very nice! Will test is as soon as possible (this weekend most likely).

@darklow darklow referenced this issue Apr 5, 2013

Closed

Django-cms support #2

@Kilian

This comment has been minimized.

Show comment
Hide comment
@Kilian

Kilian Apr 16, 2013

This looks great! I was wondering what the reasoning behind the change form blocks having a negative margin?

Some issues I found:

  • The "pages" in breadcrumb is not linked if you're on a detail page, unlike for example the "users" link when editing a user.
  • The two checkboxes "Is published" and "In Navigation" are placed besides each other in the regular style, but now "is published" becomes a label. "In navigation" should be similarly styled
  • The plus sign next to adding a plugin is showing a bit of the next icon (so pedantic, sorry!)

Kilian commented Apr 16, 2013

This looks great! I was wondering what the reasoning behind the change form blocks having a negative margin?

Some issues I found:

  • The "pages" in breadcrumb is not linked if you're on a detail page, unlike for example the "users" link when editing a user.
  • The two checkboxes "Is published" and "In Navigation" are placed besides each other in the regular style, but now "is published" becomes a label. "In navigation" should be similarly styled
  • The plus sign next to adding a plugin is showing a bit of the next icon (so pedantic, sorry!)
@darklow

This comment has been minimized.

Show comment
Hide comment
@darklow

darklow Apr 28, 2013

Owner

@Kilian

  1. What do you meant by "Detail page"? Can't find any breadcrumb which is not working
  2. Didn't understood this too. I applied just styling, by leaving column names the same as in original templates, which are "In navigation" and "Published". If you want to suggest these names, you should report in django-cms repo
  3. Seems fine to me. Which OS/Browser. Screenshot also would be nice.
Owner

darklow commented Apr 28, 2013

@Kilian

  1. What do you meant by "Detail page"? Can't find any breadcrumb which is not working
  2. Didn't understood this too. I applied just styling, by leaving column names the same as in original templates, which are "In navigation" and "Published". If you want to suggest these names, you should report in django-cms repo
  3. Seems fine to me. Which OS/Browser. Screenshot also would be nice.
@Kilian

This comment has been minimized.

Show comment
Hide comment
@Kilian

Kilian Apr 29, 2013

This is the unlinked pages breadcrumb, on /admin/cms/page/1/

pages

What django-cms does is place two checkmarks next to each other, so 'is published' and 'in navigation' each get their own checkmark:

checkmarks
but it probably does this in a hacky way so in django-suit it's not very clear which checkmark belongs where:

options

this is the screenshot of the icon, in firefox 20:

pedantic

Kilian commented Apr 29, 2013

This is the unlinked pages breadcrumb, on /admin/cms/page/1/

pages

What django-cms does is place two checkmarks next to each other, so 'is published' and 'in navigation' each get their own checkmark:

checkmarks
but it probably does this in a hacky way so in django-suit it's not very clear which checkmark belongs where:

options

this is the screenshot of the icon, in firefox 20:

pedantic

benjaoming added a commit to benjaoming/django-suit that referenced this issue Jun 25, 2013

darklow added a commit that referenced this issue Jun 26, 2013

Merge pull request #122 from benjaoming/patch-1
Add a note about django-cms to docs - issue #77
@snig-b

This comment has been minimized.

Show comment
Hide comment
@snig-b

snig-b Apr 29, 2014

Had previously commented on a closed issue - Please refer #2

Django-compressor gives out errors for 3rd party app support templates

snig-b commented Apr 29, 2014

Had previously commented on a closed issue - Please refer #2

Django-compressor gives out errors for 3rd party app support templates

@maestrofjp

This comment has been minimized.

Show comment
Hide comment
@maestrofjp

maestrofjp Jul 14, 2014

Contributor

Would you welcome a pull request for support for Django-CMS v3? If so, let's talk on a new ticket and figure out how to support both v2 and v3.

Contributor

maestrofjp commented Jul 14, 2014

Would you welcome a pull request for support for Django-CMS v3? If so, let's talk on a new ticket and figure out how to support both v2 and v3.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 15, 2014

Contributor

@maestrofjp check out the latest release of django-cms, it has a pretty okay fix (not perfect) to make django-suit and others work... buttons are no longer missing from the frontend editor :)

Contributor

benjaoming commented Jul 15, 2014

@maestrofjp check out the latest release of django-cms, it has a pretty okay fix (not perfect) to make django-suit and others work... buttons are no longer missing from the frontend editor :)

@maestrofjp

This comment has been minimized.

Show comment
Hide comment
@maestrofjp

maestrofjp Jul 18, 2014

Contributor

Yes, it's way better and acceptable since most django cms 3 editing is done on front end -- inline editing. Let me know if you want help improving things from where they stand. We're pretty locked into djanog CMS and moving to use suit on our future projects (fyi, waiting for my license request to be approved -- so don't worry).

Contributor

maestrofjp commented Jul 18, 2014

Yes, it's way better and acceptable since most django cms 3 editing is done on front end -- inline editing. Let me know if you want help improving things from where they stand. We're pretty locked into djanog CMS and moving to use suit on our future projects (fyi, waiting for my license request to be approved -- so don't worry).

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 18, 2014

Contributor

@maestrofjp I think the stance from django-cms is that if there is a way to improve djangoc-cms where it has become too focused on django.contrib.admin, then they are willing to merge it. So anything that's a generic improvement and not django-suit specific is acceptable.

Contributor

benjaoming commented Jul 18, 2014

@maestrofjp I think the stance from django-cms is that if there is a way to improve djangoc-cms where it has become too focused on django.contrib.admin, then they are willing to merge it. So anything that's a generic improvement and not django-suit specific is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment