Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new localized strings on main page & settings page, add pl translation of new localized strings #3237

Closed
wants to merge 2 commits into from

Conversation

wojtekmaj
Copy link

No description provided.

@wojtekmaj wojtekmaj mentioned this pull request Jul 26, 2020
@wojtekmaj
Copy link
Author

Wait, I need to add new English strings to all locales I don't know? 🤔

@Gusted
Copy link
Contributor

Gusted commented Jul 26, 2020

#3091 I already made a begin of this. and all the other languages need the translations as well in order to work...

src/ui/popup/main-page/app-switch.tsx Outdated Show resolved Hide resolved
src/ui/popup/main-page/app-switch.tsx Outdated Show resolved Hide resolved
src/ui/popup/main-page/index.tsx Outdated Show resolved Hide resolved
@plainheart
Copy link

Hi,
How's this PR for translation improvement going? I was going to add untranslated fields but just found this PR has been doing it.
If possible, I hope this work may go ahead so that more other languages can keep updated.
Thank you all!

@Gusted
Copy link
Contributor

Gusted commented Dec 9, 2020

Hi @plainheart!

I think after the new Design is polished and ready for production, all hard-coded strings will be converted to localized strings and everyone can add the translation for their language.

Regards,
Gusted

@wojtekmaj wojtekmaj closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants