Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change lack-of-samples into a noisy warning (Refs. #335) #336

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Jan 9, 2022

To be reverted in December 2022 (~+11 months from the date of this commit),
see #335 (comment)

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #336 (e96a4d1) into develop (a571881) will decrease coverage by 0.00%.
The diff coverage is 59.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #336      +/-   ##
===========================================
- Coverage    60.48%   60.47%   -0.01%     
===========================================
  Files          207      207              
  Lines        12608    12628      +20     
  Branches      1758     1761       +3     
===========================================
+ Hits          7626     7637      +11     
- Misses        4850     4859       +9     
  Partials       132      132              
Flag Coverage Δ
integration 47.94% <61.53%> (+0.02%) ⬆️
rpu_u 47.94% <61.53%> (+0.02%) ⬆️
unittests 22.57% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/librawspeed/decoders/RawDecoder.h 66.66% <ø> (ø)
src/librawspeed/metadata/Camera.h 100.00% <ø> (ø)
src/librawspeed/metadata/CameraMetaData.cpp 60.65% <0.00%> (ø)
src/librawspeed/decoders/RawDecoder.cpp 36.36% <33.33%> (-0.82%) ⬇️
src/utilities/rstest/rstest.cpp 52.50% <66.66%> (+0.17%) ⬆️
src/librawspeed/metadata/Camera.cpp 77.77% <90.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a571881...e96a4d1. Read the comment docs.

@LebedevRI LebedevRI marked this pull request as ready for review January 9, 2022 18:30
@LebedevRI LebedevRI merged commit a39c010 into darktable-org:develop Jan 9, 2022
@LebedevRI LebedevRI deleted the no-samples branch January 9, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant