Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated condition after it being logged #100

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

DanChaltiel
Copy link
Contributor

When you log a warning or an error, the condition is thrown again after the log message.

Therefore, here is a pull request to muffle these unnecessary messages.

I think it is really interesting for warnings, but I might have been carried away with errors, it might be not that useful. The getOptions() part also.

@daroczig
Copy link
Owner

thanks! sorry that it took "some" time to take a look 🤐
I've pushed some code style updates and merging after the CI/CD tests run

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cc4b608) 80.76% compared to head (f36d54d) 82.39%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   80.76%   82.39%   +1.62%     
==========================================
  Files          10       10              
  Lines         520      551      +31     
==========================================
+ Hits          420      454      +34     
+ Misses        100       97       -3     
Files Coverage Δ
R/hooks.R 56.89% <50.00%> (+34.67%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daroczig daroczig merged commit d554e28 into daroczig:master Oct 22, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants