Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize jed/xjed as text document editor #3

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Recognize jed/xjed as text document editor #3

merged 1 commit into from
Jan 23, 2024

Conversation

kseistrup
Copy link
Contributor

The jed text editor (and its graphic sibling xjed) uses jed $FILE -g $LINENO to open $FILE and position the cursor at line number $LINENO.

This pull-request will allow docfd to use jed or xjed to open a text file.

Disclaimer: I don't speak OCaml at all, and I haven't tested the patch, I've merely copied the existing pattern.

@darrenldl
Copy link
Owner

Thanks! I took a look at jed's man page and I think you got it perfectly right. I'll update the README and push a new release shortly.

@darrenldl darrenldl merged commit 13405fc into darrenldl:main Jan 23, 2024
@kseistrup kseistrup deleted the jed branch January 23, 2024 09:48
darrenldl added a commit that referenced this pull request Jan 23, 2024
@darrenldl
Copy link
Owner

I tested it against jed and it seems to work right. But I can't seem to find a package for xjed on Fedora to test the xjed part.

I've updated README and CHANGELOG nonetheless.

@kseistrup
Copy link
Contributor Author

I should have told you in the PR-note: jed (and xjed) has been my editor for almost 35 years, so I am confident about the syntax (but not about the OCaml code). If it works in jed it will work in xjed too.

Thank you so much for your swift merging, I will package docfd for AUR right away.

@darrenldl
Copy link
Owner

darrenldl commented Jan 23, 2024

Off topic: what are the killer features of jed that makes you use it for 35 years?

Also I just realised I missed some pushes for 2.1.0 - I'm going to redo the release.

EDIT: Okay the pushes for the proper version string have been made, and retagged 2.1.0. The binary should now actually carry the right version string after the CI finishes building it.

EDIT2: Just noticed you've already published the older tagged commit. Sorry about that!

@kseistrup
Copy link
Contributor Author

what are the killer features of jed that makes you use it for 35 years?

I immediately liked it because:

  • it had syntax highlighting
  • it had auto-indentation
  • it was easily extensible via its builtin scripting language S-Lang
  • its keystrokes are more or less the same as emacs'

I know this is all standard today, but this was 35 years ago and I had just started using Linux. The rest is just habbit and muscle memory. If I were to start all over today I'd probably choose helix (or kakoune).

Just noticed you've already published the older tagged commit. Sorry about that!

No problem. Microsoft GitHub sends me an email for every new release, and I just re-published v2.1.0.

@darrenldl
Copy link
Owner

Gotcha. Thanks for the insight.. If I'm starting from scratch today I'd likewise think helix or kakoune makes the most sense, at least in terms of the designs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants