-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalizeWheelDelta change, sry for wightespaces :) #91
Conversation
Scroll event normalization so you can scroll by each element old normalization is to fast.
You invalidated |
Yes for not just for Macbook trackpads and for magic mouse to , which was my issue so i needed change, yes i exchange component.json sry :) |
I've reviewed it again, and I see what you are doing. In Mackbook trackpads the value returned from That being said, it gave me an idea how to handle it. Gonna try it later today. Don't submit more PR's, your PR's are a mess :) |
Yes i only exchanged normalizeWheelDelta but bed thing happen while i was not on the newest version of the script, and i didn't see you was exchanging something because on bower is still new version 1.0.2, that's why i destroy it :D, and i exchange component.json because i want to use it with bower but i didn't know that i cannot directly download script from github thought bower. :) Regarding the fix yes mac os returns floating points. And while you returned 1 or -1 scrolling was to fast (to many steps because sometimes you want scroll only by one item and with 1 or -1 was not possible). But you don't need item based scrolling here because is scroll event it is not click event (next/previous) item, i don't know what is your concept but for me does not have a sense. Anyways you can stop on half item while you dragging on the scroll bar. Let me know what are you think :). |
You can test the code in I've set up a quick test for it here: http://jsbin.com/InAlUh/1 |
No description provided.