Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalizeWheelDelta change, sry for wightespaces :) #91

Closed
wants to merge 5 commits into from
Closed

normalizeWheelDelta change, sry for wightespaces :) #91

wants to merge 5 commits into from

Conversation

igorzg
Copy link

@igorzg igorzg commented Oct 10, 2013

No description provided.

Igor and others added 5 commits October 10, 2013 12:38
Scroll event normalization so you can scroll by each element old normalization is to fast.
@darsain
Copy link
Owner

darsain commented Oct 10, 2013

You invalidated component.json, changed the repository url inside it, added code with inconsistent indentation, and bumped and build a new version just because of your patch that doesn't actually solve any of the current issues. In fact, your wheelDelta "normalization" only amplifies the issue with Macbook trackpads.

No

@darsain darsain closed this Oct 10, 2013
@igorzg
Copy link
Author

igorzg commented Oct 10, 2013

Yes for not just for Macbook trackpads and for magic mouse to , which was my issue so i needed change, yes i exchange component.json sry :)

@darsain
Copy link
Owner

darsain commented Oct 10, 2013

I've reviewed it again, and I see what you are doing. In Mackbook trackpads the value returned from normalizeWheelDelta is a floating point. It is the same kind of fix already proposed in #57, and rejected because it fixes the issue only in non-item based scrolling, while breaking item-based because you can't scroll by 0.15 items.

That being said, it gave me an idea how to handle it. Gonna try it later today. Don't submit more PR's, your PR's are a mess :)

@igorzg
Copy link
Author

igorzg commented Oct 10, 2013

Yes i only exchanged normalizeWheelDelta but bed thing happen while i was not on the newest version of the script, and i didn't see you was exchanging something because on bower is still new version 1.0.2, that's why i destroy it :D, and i exchange component.json because i want to use it with bower but i didn't know that i cannot directly download script from github thought bower. :)

Regarding the fix yes mac os returns floating points. And while you returned 1 or -1 scrolling was to fast (to many steps because sometimes you want scroll only by one item and with 1 or -1 was not possible). But you don't need item based scrolling here because is scroll event it is not click event (next/previous) item, i don't know what is your concept but for me does not have a sense. Anyways you can stop on half item while you dragging on the scroll bar. Let me know what are you think :).

@darsain
Copy link
Owner

darsain commented Oct 10, 2013

You can test the code in src/sly.js, and refer back if it fixed your issues with fast scrolling.

I've set up a quick test for it here: http://jsbin.com/InAlUh/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants