Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit 2b75836

Browse files
committed
fix: Add test to compile examples, fix imports for examples
1 parent 2d8615f commit 2b75836

File tree

5 files changed

+14
-7
lines changed

5 files changed

+14
-7
lines changed

lib/angular_dynamic.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'package:angular/change_detection/change_detection.dart';
99
import 'package:angular/change_detection/dirty_checking_change_detector_dynamic.dart';
1010
import 'package:angular/core/registry_dynamic.dart';
1111
import 'package:angular/core/parser/parser_dynamic.dart';
12-
import 'dart:html' as dom;
12+
import 'dart:html';
1313

1414
/**
1515
* If you are writing code accessed from Angular expressions, you must include
@@ -25,8 +25,8 @@ import 'dart:html' as dom;
2525
*/
2626
@MirrorsUsed(targets: const [
2727
'angular',
28-
'angular.core',
29-
'angular.core.dom',
28+
'angular.core_internal',
29+
'angular.core.dom_internal',
3030
'angular.filter',
3131
'angular.perf',
3232
'angular.directive',
@@ -36,7 +36,7 @@ import 'dart:html' as dom;
3636
'angular.core.parser.lexer',
3737
'perf_api',
3838
List,
39-
dom.NodeTreeSanitizer,
39+
NodeTreeSanitizer,
4040
],
4141
metaTargets: const [
4242
NgInjectableService,

lib/core/module.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
library angular.core;
22

3+
export "package:angular/core/service.dart";
34
export "package:angular/core_dom/module_internal.dart" show
45
Animation,
56
AnimationResult,

scripts/generate-documentation.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,6 @@ mv docs/ $DOCVIEWER_DIR/client/web/docs/
5151
(cd $DOCVIEWER_DIR/client; pub build)
5252

5353
# Revert the temp copy of the README.md file
54-
mv README-orig.md README.md
54+
rm README.md
55+
mv README-orig.md README.md
5556

scripts/travis/build.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ set -evx
44
. ./scripts/env.sh
55

66
# skip auxiliary tests if we are only running dart2js
7-
if [[ $TESTS != "dart2js" ]]; then
7+
if [[ $TESTS == "dart2js" ]]; then
8+
cd example
9+
pub build
10+
cd ..
11+
else
812
# run io tests
913
dart -c test/io/all.dart
1014

test/angular_spec.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ main() {
4343
});
4444

4545
describe('angular symbols', () {
46-
it('should not export symbols that we do not know about', () {
46+
iit('should not export symbols that we do not know about', () {
4747
// Test is failing? Add new symbols to the "ALLOWED_NAMES" list below.
4848
// But make sure that you intend to export the symbol!
4949
// Questions? Talk to @jbdeboer
@@ -123,6 +123,7 @@ main() {
123123
var ALLOWED_NAMES = [
124124
"angular.app.Application",
125125
"angular.app.AngularModule",
126+
"angular.core.service.NgInjectableService",
126127
"angular.core_internal.CacheStats",
127128
"angular.core_internal.ExceptionHandler",
128129
"angular.core_internal.Interpolate",

0 commit comments

Comments
 (0)