Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit 691c4ca

Browse files
committed
fix(introspection): Export all symbols. And a test.
1 parent 84ded8c commit 691c4ca

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

lib/introspection.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,11 @@ List<Object> ngDirectives(dom.Node node) {
7676
}
7777

7878
_publishToJavaScript() {
79-
js.context
80-
..['ngProbe'] = (dom.Node node) => _jsProbe(ngProbe(node))
81-
..['ngInjector'] = (dom.Node node) => _jsInjector(ngInjector(node))
82-
..['ngScope'] = (dom.Node node) => _jsScope(ngScope(node))
83-
..['ngQuery'] = (dom.Node node, String selector, [String containsText]) =>
79+
// Point of style here: cascades require too many ()s, reducing readability.
80+
js.context['ngProbe'] = (dom.Node node) => _jsProbe(ngProbe(node));
81+
js.context['ngInjector'] = (dom.Node node) => _jsInjector(ngInjector(node));
82+
js.context['ngScope'] = (dom.Node node) => _jsScope(ngScope(node));
83+
js.context['ngQuery'] = (dom.Node node, String selector, [String containsText]) =>
8484
new js.JsArray.from(ngQuery(node, selector, containsText));
8585
}
8686

test/introspection_spec.dart

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
library introspection_spec;
22

33
import '_specs.dart';
4+
import 'dart:js' as js;
45

56
void main() {
67
describe('introspection', () {
@@ -35,5 +36,13 @@ void main() {
3536
shadowRoot.innerHtml = '<ul><li>stash</li><li>secret</li><ul>';
3637
expect(toHtml(ngQuery(div, 'li'))).toEqual('<li>stash</li><li>secret</li>');
3738
});
39+
40+
it('should be available from Javascript', () {
41+
ngBootstrap(element: new Element.html('<div></div>'));
42+
expect(js.context['ngProbe']).toBeDefined();
43+
expect(js.context['ngScope']).toBeDefined();
44+
expect(js.context['ngInjector']).toBeDefined();
45+
expect(js.context['ngQuery']).toBeDefined();
46+
});
3847
});
39-
}
48+
}

0 commit comments

Comments
 (0)