You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
fix(jasmine): don't swallow exceptions in afterEach
It turns out that `tearDown()` in `unittest/unittest.dart` swallows
exceptions (at least in the current version.) This means that
exceptions thrown in our `afterEach` functions are silently swallowed
and cause our tests to pass incorrectly. As an example, the 24 tests
that were updated in commit d663667
should have been failing with the exception `Unflushed requests: 1` but
did not. This change makes it so that these exceptions do show up.
0 commit comments