Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Extension types] Update tests according to the new setter/method rules #2388

Closed
sgrekhov opened this issue Nov 20, 2023 · 0 comments
Closed

[Extension types] Update tests according to the new setter/method rules #2388

sgrekhov opened this issue Nov 20, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

Update Extension types tests according to the new rules regarding setter/method conflict. The change
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 20, 2023
@sgrekhov sgrekhov self-assigned this Nov 20, 2023
@sgrekhov sgrekhov mentioned this issue Nov 22, 2023
Closed
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 22, 2023
@sgrekhov
Fixes dart-lang#2388. Add tests for the new method/setter rules. Upda…
7f7a798 
…te assertions
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 24, 2023
@sgrekhov
dart-lang#2388. Rename and reorder static_analysis_member_invocation_…
26bf99e 
…A06_t* tests
eernstg pushed a commit that referenced this issue Nov 24, 2023
@sgrekhov
#2388. Rename and reorder static_analysis_member_invocation_A06_t* te…
24af6b9 
…sts (#2397)

Renaming operations:
static_analysis_member_invocation_A06_t03.dart -> *02*
static_analysis_member_invocation_A06_t05.dart -> *03*
static_analysis_member_invocation_A06_t06.dart -> *05*
static_analysis_member_invocation_A06_t07.dart -> *06*
tatic_analysis_member_invocation_A06_t08.dart -> *04*
.. plus a couple of small changes in a `@description`.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 24, 2023
@sgrekhov @athomas
[co19] Roll co19 to 85c868a325bc92f4e743958077ad0ad2eb58c81f
2534859 
2023-11-23 athom@google.com Merge pull request dart-lang/co19#2395 from dart-lang/merge-pre-nnbd
2023-11-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2390. Fix tests according to the new method/setter rules (dart-lang/co19#2392)
2023-11-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2388. Add tests for the new method/setter rules. Update assertions (dart-lang/co19#2393)
2023-11-23 athom@google.com Merge remote-tracking branch 'origin/pre-nnbd' into master
2023-11-22 sgrekhov22@gmail.com Fixes dart-lang/co19#2389. Add additional error expectation for analyzer (dart-lang/co19#2391)
2023-11-21 sgrekhov22@gmail.com dart-lang/co19#2342. Update nullability tests according to the new rules (dart-lang/co19#2385)
2023-11-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2384. Fix not well-bound extension types. Add function-type dynamic test (dart-lang/co19#2387)

Change-Id: Ic3848f6f39fd42b01bfed5feac3d922c6f5a53d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338120
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to 2ba55b45d85fece505a503dd12cf1c708825b74f
a3d5e1d 
2023-12-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.13.0 to 4.0.0 (dart-lang/co19#2410)
2023-12-01 sgrekhov22@gmail.com dart-lang/co19#2398. Update async tests to avoid false-positive results on web. Language and LanguageFeatures tests (dart-lang/co19#2407)
2023-12-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2408. Fix roll failures (dart-lang/co19#2409)
2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Update asyncStart/End() to correspond SDK version. Replace asyncMultiTest (dart-lang/co19#2406)
2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Remove excessive async. Add explicit `void` (dart-lang/co19#2400)
2023-11-28 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 1 (dart-lang/co19#2353)
2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2390. Add expected error to static_analysis_extension_types_A30_t02.dart (dart-lang/co19#2401)
2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2399. Update expected errors locations for CFE (dart-lang/co19#2402)
2023-11-24 sgrekhov22@gmail.com dart-lang/co19#2388. Rename and reorder static_analysis_member_invocation_A06_t* tests (dart-lang/co19#2397)

Change-Id: Ie4b51caa12a9a0896c893cc02b099a07ef09fbd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339560
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov