#2388. Rename and reorder static_analysis_member_invocation_A06_t* tests #2397
Conversation
There was a problem hiding this comment.
LGTM.
Github actually only recognizes one of these operations: Renaming 08 to 04. For instance, it says that 07 was deleted rather than renamed to 06, and it shows a bunch of differences for all the other libraries.
Do you use git mv to rename libraries? (.. if not then that could explain why github really doesn't understand the renaming operations). Otherwise it would be very nice to have just a small hint about the renaming operations in the PR description (perhaps something like 'Renaming: 08 -> 04, 07 -> 06'), also in order to help future readers who might want to understand the history of one of these libraries.
|
Ok, will do the next time. I rename files in Intelj IDEA and then do a commit from there, not from a command-line. Sometimes this tool is smart enough to recognise renaming, sometimes not |
|
OK, thanks! |
2023-12-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.13.0 to 4.0.0 (dart-lang/co19#2410) 2023-12-01 sgrekhov22@gmail.com dart-lang/co19#2398. Update async tests to avoid false-positive results on web. Language and LanguageFeatures tests (dart-lang/co19#2407) 2023-12-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2408. Fix roll failures (dart-lang/co19#2409) 2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Update asyncStart/End() to correspond SDK version. Replace asyncMultiTest (dart-lang/co19#2406) 2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Remove excessive async. Add explicit `void` (dart-lang/co19#2400) 2023-11-28 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 1 (dart-lang/co19#2353) 2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2390. Add expected error to static_analysis_extension_types_A30_t02.dart (dart-lang/co19#2401) 2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2399. Update expected errors locations for CFE (dart-lang/co19#2402) 2023-11-24 sgrekhov22@gmail.com dart-lang/co19#2388. Rename and reorder static_analysis_member_invocation_A06_t* tests (dart-lang/co19#2397) Change-Id: Ie4b51caa12a9a0896c893cc02b099a07ef09fbd7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339560 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Github shows a big diff but in fact it's only renaming and reordering of the tests