Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to f1fcc6d38c7daa7d75da6985e0f09a0f713b152e #2408

Closed
sgrekhov opened this issue Dec 1, 2023 · 0 comments
Closed

Failures on [co19] Roll co19 to f1fcc6d38c7daa7d75da6985e0f09a0f713b152e #2408

sgrekhov opened this issue Dec 1, 2023 · 0 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Dec 1, 2023

There are new test failures on [co19] Roll co19 to f1fcc6d38c7daa7d75da6985e0f09a0f713b152e.

The tests

co19/Language/Classes/Constructors/Factories/accessible_class_A01_t01 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Constructors/Factories/accessible_class_A02_t01 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Constructors/Factories/accessible_class_A02_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t05 CompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t06 MissingCompileTimeError (expected Pass)

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-linux-chrome-unsound
dart2js-hostasserts-linux-d8
dart2js-linux-chrome
dart2wasm-linux-chrome
dart2wasm-linux-d8
ddc-linux-chrome
ddc-linux-chrome-unsound
vm-mac-debug-arm64
vm-mac-release-arm64
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Dec 1, 2023
@sgrekhov sgrekhov self-assigned this Dec 1, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 1, 2023
@sgrekhov
Fixes dart-lang#2408. Fix roll failures
b3ded08
@eernstg eernstg closed this as completed in 8d82009 Dec 1, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to 2ba55b45d85fece505a503dd12cf1c708825b74f
a3d5e1d 
2023-12-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.13.0 to 4.0.0 (dart-lang/co19#2410)
2023-12-01 sgrekhov22@gmail.com dart-lang/co19#2398. Update async tests to avoid false-positive results on web. Language and LanguageFeatures tests (dart-lang/co19#2407)
2023-12-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2408. Fix roll failures (dart-lang/co19#2409)
2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Update asyncStart/End() to correspond SDK version. Replace asyncMultiTest (dart-lang/co19#2406)
2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Remove excessive async. Add explicit `void` (dart-lang/co19#2400)
2023-11-28 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 1 (dart-lang/co19#2353)
2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2390. Add expected error to static_analysis_extension_types_A30_t02.dart (dart-lang/co19#2401)
2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2399. Update expected errors locations for CFE (dart-lang/co19#2402)
2023-11-24 sgrekhov22@gmail.com dart-lang/co19#2388. Rename and reorder static_analysis_member_invocation_A06_t* tests (dart-lang/co19#2397)

Change-Id: Ie4b51caa12a9a0896c893cc02b099a07ef09fbd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339560
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov