Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for import/export libraries with the same URI #2923

Closed
sgrekhov opened this issue Oct 8, 2024 · 0 comments
Closed

Add tests for import/export libraries with the same URI #2923

sgrekhov opened this issue Oct 8, 2024 · 0 comments
Assignees
@sgrekhov
Labels
area-test

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Oct 8, 2024

According to the specification

All imports and exports of the same URI in a Dart program denotes the same library, and imports or exports of different URIs denote distinct libraries.

We have no tests checking this statement.
@sgrekhov sgrekhov self-assigned this Oct 8, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 8, 2024
@sgrekhov
dart-lang#2923. Add tests for import/exports with the same URI
d212592
eernstg pushed a commit that referenced this issue Oct 8, 2024
@sgrekhov
#2923. Add tests for import/exports with the same URI (#2924)
719fffa
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 8, 2024
@sgrekhov
dart-lang#2923. Add tests for import/exports with different URIs
fa9cba5
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 9, 2024
@sgrekhov
dart-lang#2923. More tests for import and export library with the sam…
d0b7764 
…e URI.
eernstg pushed a commit that referenced this issue Oct 9, 2024
@sgrekhov
#2923. More tests for import and export library with the same URI. (#…
495ccf2 
…2928)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 11, 2024
@sgrekhov
[co19] Roll co19 to dd66678fea1d11bc6295a688ed5f8e726034f762
9541425 
2024-10-10 sgrekhov22@gmail.com dart-lang/co19#2925. Add comment explaining why the syntax error is not reported in grammar_A05_t01_lib.dart (dart-lang/co19#2931)
2024-10-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2925. Fix expected errors positions in grammar_A05_t01_lib.dart (dart-lang/co19#2929)
2024-10-09 sgrekhov22@gmail.com dart-lang/co19#2923. More tests for import and export library with the same URI. (dart-lang/co19#2928)
2024-10-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2926. Remove unnecessary error expectation from grammar_A04_t01.dart (dart-lang/co19#2927)
2024-10-08 sgrekhov22@gmail.com dart-lang/co19#2923. Add tests for import/exports with the same URI (dart-lang/co19#2924)
2024-10-07 sgrekhov22@gmail.com dart-lang/co19#2825. Fix dotted.library.name syntax in `part of` directive (dart-lang/co19#2922)
2024-10-04 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting enum values test. (dart-lang/co19#2921)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I81902e4e4eac8a0b0ffd3f20d957aa9bfcc2cdc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389700
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
area-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov