Failures on [co19] Roll co19 to c051b94705832669ea10d6e064e777aad87b0e25

[athomas]

There are new test failures on [co19] Roll co19 to c051b94705832669ea10d6e064e777aad87b0e25.

The tests

co19/Language/Classes/Setters/same_name_getter_different_type_t01 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Setters/same_name_getter_different_type_t02 MissingCompileTimeError (expected Pass)
co19/Language/Variables/final_t11 MissingCompileTimeError (expected Pass)

are failing on configurations

analyzer-asserts-strong-linux
analyzer-asserts-weak-linux
cfe-strong-linux
cfe-weak-linux

[sgrekhov]

CFE failures
co19/Language/Classes/Setters/same_name_getter_different_type_t01 MissingCompileTimeError (expected Pass)
co19/Language/Classes/Setters/same_name_getter_different_type_t02 MissingCompileTimeError (expected Pass)
covered by dart-lang/sdk#42702

analyzer...
CompileTimeError -> MissingCompileTimeError (expected Pass)
✔ co19/Language/Variables/final_t11

According to the log analyzer expects a failure in a wrong place. It's odd. I'm unable to reproduce it nor on Dart SDK version: 2.10.0-45.0.dev (dev) (Wed Aug 19 06:32:03 2020 -0700) on "windows_x64" nor on fresh Dart SDK version: 2.10.0-edge.8293888df8ade9a343182a96bc171ae581641e56 (be) (Tue Aug 25 15:32:20 2020 +0700) on "linux_x64"
Both versions that I tried reports an error in an expected place.

class C {
  f() {
    final i;     // Accordng to the log there's no error here
//        ^
// [analyzer] unspecified
// [cfe] unspecified
    return i;  // Accordng to the log there's an error here
  }
}

main() {
  new C().f();
}

@athomas What version of the analyzer was used by the tryjob? Is there a way to rerun this test on the fresh version of the analyzer? Or, for example, mark this test as passed. If it failed on the next roll I'll see that and return back to this test

[athomas]

The failure seems to be still present in the logs (this is a separate job):
https://dart-ci.appspot.com/log/analyzer-nnbd-linux-release/analyzer-asserts-strong-linux/4337/co19/Language/Variables/final_t11

How exactly did you run the test?

python tools/test.py -n analyzer-asserts-strong-linux co19/Language/Variables/final_t11?

[sgrekhov]

I used

~/dart-sdk/sdk$ out/ReleaseX64/dart-sdk/bin/dartanalyzer tests/co19/src/Language/Variables/final_t11.dart
Analyzing tests/co19/src/Language/Variables/final_t11.dart...
  error • The final variable 'i' must be initialized. • tests/co19/src/Language/Variables/final_t11.dart:29:11 • final_not_initialized
1 error found.

As you can see there is an error on line 29 column 11. If to try

~/dart-sdk/sdk$ tools/test.py -n analyzer-asserts-strong-linux co19/Language/Variables/final_t11
Test configuration:
    analyzer-asserts-strong-linux(architecture: x64, compiler: dart2analyzer, mode: release, runtime: none, system: linux, nnbd: strong, enable-experiment: [non-nullable], enable-asserts, use-sdk)
Suites tested: co19

FAILED: dart2analyzer-none release_x64 co19/Language/Variables/final_t11
Expected: Pass
Actual: MissingCompileTimeError

--- Command "dart2analyzer" (took 04.000194s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dartanalyzer --enable-experiment=non-nullable --ignore-unrecognized-flags --packages=/home/sergey/dart-sdk/sdk/.packages --format=machine --no-hints /home/sergey/dart-sdk/sdk/tests/co19/src/Language/Variables/final_t11.dart

static error failures:
Missing static error at line 29, column 11, length 1:
- Expected unspecified analyzer error.
- Expected unspecified CFE error.

Unexpected static error at line 33, column 12, length 1:
- Had analyzer error 'COMPILE_TIME_ERROR.READ_POTENTIALLY_UNASSIGNED_FINAL'.

--- Re-run this test:
python tools/test.py -n analyzer-asserts-strong-linux co19/Language/Variables/final_t11
[00:05 | 100% | +    0 | -    1]

=== 0 tests passed, 1 failed ===

And here we have Missing static error at line 29, column 11. Why the results are different?

[athomas]

Most likely because you're not passing --enable-experiment=non-nullable to the dartanalyzer. Did you try doing that already?

[sgrekhov]

Indeed. Sorry for bothering