#2559. Add more augmenting functions tests #2615
Conversation
There was a problem hiding this comment.
Looks good, with a typo or two!
Just one proposal goes a bit further: It looks like LanguageFeatures/Augmentation-libraries/augmenting_functions_A05_t02.dart gives rise to some error messages that are expected (so they are treated correctly), but will also potentially cause some confusion.
LanguageFeatures/Augmentation-libraries/augmenting_functions_A05_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A06_t01.dart
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A06_t01.dart
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A06_t02.dart
Outdated
Show resolved
Hide resolved
|
Updated. Please teke another look |
|
|
||
| augment library 'augmenting_functions_A06_t02.dart'; | ||
|
|
||
| augment external void topLevelFunction() { |
There was a problem hiding this comment.
One more thing! The grammar doesn't allow augment external.
I think it's supposed to be written like this:
| augment external void topLevelFunction() { | |
| augment void topLevelFunction() { |
and it is not intended to be an error that the augmenting declaration doesn't have external.
In that sense, external plays a role which is similar to a body (so the original and the augmenting declarations can differ), not a modifier (where the original and augmenting declarations must be identical).
There was a problem hiding this comment.
|
Thank you for noticing! Fixed |
2024-04-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2622. Fix typo, add issue numbers (dart-lang/co19#2623) 2024-04-25 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for setters (dart-lang/co19#2620) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for getters (dart-lang/co19#2619) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for setters (dart-lang/co19#2618) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for getters (dart-lang/co19#2617) 2024-04-23 sgrekhov22@gmail.com dart-lang/co19#2559. Fix augmenting operators syntax (dart-lang/co19#2616) 2024-04-22 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting functions tests (dart-lang/co19#2615) 2024-04-19 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting functions signature tests. Part 2 (dart-lang/co19#2614) Change-Id: I8c187cda88baa2e638f189e2a9251c479d14ad79 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364502 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
No description provided.