-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2559. Add augmented expression tests for getters #2617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a couple of comments.
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t04.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t05.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Please take another look
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t04.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t05.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2024-04-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2622. Fix typo, add issue numbers (dart-lang/co19#2623) 2024-04-25 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for setters (dart-lang/co19#2620) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for getters (dart-lang/co19#2619) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for setters (dart-lang/co19#2618) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for getters (dart-lang/co19#2617) 2024-04-23 sgrekhov22@gmail.com dart-lang/co19#2559. Fix augmenting operators syntax (dart-lang/co19#2616) 2024-04-22 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting functions tests (dart-lang/co19#2615) 2024-04-19 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting functions signature tests. Part 2 (dart-lang/co19#2614) Change-Id: I8c187cda88baa2e638f189e2a9251c479d14ad79 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364502 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
No description provided.