Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2559. Add more augmenting expression tests for getters #2619

Merged
merged 2 commits into from
Apr 24, 2024
Merged

#2559. Add more augmenting expression tests for getters #2619

merged 2 commits into from
Apr 24, 2024

Conversation

sgrekhov
Copy link
Contributor

Added tests cases when augmented is called from some function

augment ... someGetter {
  var f = () {
    return augmented;
  }
  return f();
}

eernstg
eernstg approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

eernstg
eernstg reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue after all: A bunch of missing semicolons.

LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t03_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t04_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t05_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t08_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t09_lib.dart Outdated Show resolved Hide resolved
@sgrekhov
Copy link
Contributor Author

Thank you! Fixed

@sgrekhov sgrekhov requested a review from eernstg April 24, 2024 15:49
eernstg
eernstg approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eernstg eernstg merged commit c03a319 into dart-lang:master Apr 24, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 26, 2024
@sgrekhov
[co19] Roll co19 to c18ac1b2cb497b23fcb3c8d04cdab1069cd16e2b
cf56439 
2024-04-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2622. Fix typo, add issue numbers (dart-lang/co19#2623)
2024-04-25 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for setters (dart-lang/co19#2620)
2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for getters (dart-lang/co19#2619)
2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for setters (dart-lang/co19#2618)
2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for getters (dart-lang/co19#2617)
2024-04-23 sgrekhov22@gmail.com dart-lang/co19#2559. Fix augmenting operators syntax (dart-lang/co19#2616)
2024-04-22 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting functions tests (dart-lang/co19#2615)
2024-04-19 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting functions signature tests. Part 2 (dart-lang/co19#2614)

Change-Id: I8c187cda88baa2e638f189e2a9251c479d14ad79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364502
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgrekhov @eernstg