#2559. Add augmented expression tests for setters #2618
Conversation
There was a problem hiding this comment.
Looks good! Just one thing: LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t06.dart seems to imply that augmented = e in an augmentation will invoke a top-level setter in scope; it should actually invoke the original declaration (which will in turn invoke that top-level setter named augmented=). I'm suggesting that the log is adjusted a bit such that we can see that the invocation goes via the original declaration, and the description is adjusted to reflect this behavior.
| String _log = ""; | ||
|
|
||
| void set augmented(String value) { | ||
| throw Exception("Wrong setter is called"); |
There was a problem hiding this comment.
Thinking about this one more time, it's not obvious which is nicer for a developer who is encountering some test failures. The approach where line 26 assigns a value to _log which is not expected in some Expect statement is perhaps more consistent: We get to see what went wrong in both cases, but having a wrong _log value is more like several other buggy behaviors.
Anyway, I don't see a reason to change anything here now.
LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t06.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t06.dart
Outdated
Show resolved
Hide resolved
|
Updated. Please take another look |
| String _log = ""; | ||
|
|
||
| void set augmented(String value) { | ||
| throw Exception("Wrong setter is called"); |
There was a problem hiding this comment.
Thinking about this one more time, it's not obvious which is nicer for a developer who is encountering some test failures. The approach where line 26 assigns a value to _log which is not expected in some Expect statement is perhaps more consistent: We get to see what went wrong in both cases, but having a wrong _log value is more like several other buggy behaviors.
Anyway, I don't see a reason to change anything here now.
2024-04-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2622. Fix typo, add issue numbers (dart-lang/co19#2623) 2024-04-25 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for setters (dart-lang/co19#2620) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expression tests for getters (dart-lang/co19#2619) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for setters (dart-lang/co19#2618) 2024-04-24 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for getters (dart-lang/co19#2617) 2024-04-23 sgrekhov22@gmail.com dart-lang/co19#2559. Fix augmenting operators syntax (dart-lang/co19#2616) 2024-04-22 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting functions tests (dart-lang/co19#2615) 2024-04-19 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting functions signature tests. Part 2 (dart-lang/co19#2614) Change-Id: I8c187cda88baa2e638f189e2a9251c479d14ad79 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364502 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
No description provided.