#2559. Add scoping tests #2835
#2559. Add scoping tests #2835
Conversation
There was a problem hiding this comment.
Looks good! Noticed one small typo.
I somewhat bigger thing is the naming of the members when there is a name clash: They are named introductory... or augmenting.... I think there's a reason for this, but I still suspect that it would be easier for future maintainers of these tests (including ourselves ;-) if the clashing names have a name like clashingName... rather than introductory....
So what do you think? Is there a systematic reason for the current naming which would be disrupted if those declarations were renamed?
There was a problem hiding this comment.
Very nice!
One thing: LanguageFeatures/Augmentation-libraries/scoping_A01_t05.dart expects that it is possible to obtain a transformation from qux to this.qux in a situation where the library scope contains a declaration named qux (albeit in a different file). That isn't so (and it couldn't be so because then we would probably be unable to access that top-level declaration from the body of a declaration D in a different file if D has a member with that name, instance or static).
|
Thank you for pointing to this issue. Fixed. PTAL. |
2024-08-29 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for some corner cases (dart-lang/co19#2836) 2024-08-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2838. Variable named `_` does not bind anything (dart-lang/co19#2840) 2024-08-29 sgrekhov22@gmail.com dart-lang/co19#2559. Add scoping tests (dart-lang/co19#2835) 2024-08-29 sgrekhov22@gmail.com dart-lang/co19#2559. Fix extension types syntax (dart-lang/co19#2837) 2024-08-27 sgrekhov22@gmail.com dart-lang/co19#2559. Add extension types tests (dart-lang/co19#2831) 2024-08-26 sgrekhov22@gmail.com dart-lang/co19#2559. Add metadata tests (dart-lang/co19#2832) 2024-08-23 sgrekhov22@gmail.com dart-lang/co19#2559. Add more constructor augmentation tests around formal parameters (dart-lang/co19#2830) Change-Id: I55ef74d7a2c34edbfbbfd91570b7efb250d0d40d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382884 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
No description provided.