#2559. Add extension types to augmenting types tests #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Aug 29, 2024
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t01_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t02_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t02_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A10_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A10_t02.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Aug 30, 2024
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t01_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t02_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t02_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A10_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A10_t02.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 10, 2024
2024-09-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2852. Fix the new roll failures (dart-lang/co19#2853) 2024-09-09 sgrekhov22@gmail.com dart-lang/co19#2825. Add scope tests. Part 2. (dart-lang/co19#2847) 2024-09-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2849. Fix new roll failures (dart-lang/co19#2850) 2024-09-09 sgrekhov22@gmail.com dart-lang/co19#2559. Replace augmentation libraries by parts (dart-lang/co19#2848) 2024-09-05 sgrekhov22@gmail.com dart-lang/co19#2825. Add scope tests. Part 1. (dart-lang/co19#2845) 2024-09-04 sgrekhov22@gmail.com dart-lang/co19#2398. Update TouchEvent tests to not fail on platforms where it is not defined (dart-lang/co19#2844) 2024-09-03 sgrekhov22@gmail.com dart-lang/co19#2825. Add import inheritance and grammar tests (dart-lang/co19#2843) 2024-09-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting members tests. Part 2 (dart-lang/co19#2799) 2024-09-02 sgrekhov22@gmail.com dart-lang/co19#2825. Add enhanced parts tests for top-level declarations and ownership (dart-lang/co19#2842) 2024-09-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.2.1 to 4.2.2 in the github-actions group (dart-lang/co19#2841) 2024-08-30 sgrekhov22@gmail.com dart-lang/co19#2559. Add extension types to augmenting types tests (dart-lang/co19#2839) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I26f83579708b877918b5a0a904f8172aa1cf4724 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384480 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be questions regarding
augmenting_types_A10_t03.dartandaugmenting_types_A10_t06.dart. There are scoping tests checking that it is a compile-time error if we have a static and an instance member with the same name in an introductory and augmenting scopes. To avoid duplications these tests rewritten to have these declarations in different augmenting scopes.