This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Make the package not depend directly on package:charcode. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The charcode package is still used a dev-dependency, but that does not affect users of the convert package.
natebosch
approved these changes
Sep 22, 2020
lib/src/charcodes.dart
Outdated
| const int $z = 0x7a; | ||
|
|
||
| /// Character `~`. | ||
| const int $tilde = 0x7e; |
There was a problem hiding this comment.
Looks like it might need a dartfmt - missing trailing newline.
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
|
@lrhn is this ready to land? |
|
Yes. Done. |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
…convert#35) * Make the package not depend directly on package:charcode. The charcode package is still used a dev-dependency, but that does not affect users of the convert package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The charcode package is still used as a dev-dependency,
but that does not affect users of the convert package.