Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic callback parameters lose their type parameters #613

Closed
asgerf opened this issue Apr 6, 2017 · 1 comment
Closed

Generic callback parameters lose their type parameters #613

asgerf opened this issue Apr 6, 2017 · 1 comment
Assignees
@munificent
Labels
bug

Comments

@asgerf
Copy link

asgerf commented Apr 6, 2017

Example:

// before dartfmt
void takeIdentityFunction(T id<T>(T x)) {}

// after dartfmt
void takeIdentityFunction(T id(T x)) {}

If the syntax is not supported yet, it should at least refuse to format it.
@munificent munificent added the bug label Apr 6, 2017
@munificent
Copy link
Member

If the syntax is not supported yet, it should at least refuse to format it.

There's no automatic way to do that in general. This is just a bug. It should be supported.

munificent added a commit that referenced this issue Apr 6, 2017
@munificent
Don't drop type arguments on generic function typed parameters.
3090661 
Fix #613.
@munificent munificent mentioned this issue Apr 6, 2017
Merged
@munificent munificent self-assigned this Apr 6, 2017
munificent added a commit that referenced this issue Apr 6, 2017
@munificent
Don't drop type arguments on generic function typed parameters. (#614)
3aa02ea 
Fix #613.
munificent added a commit to dart-lang/sdk that referenced this issue Apr 6, 2017
@munificent
Update dart_style.
8bda93d 
This brings in an important fix for formatting generic function-typed
parameters. See:

dart-lang/dart_style#613

R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2805103002 .
@munificent munificent mentioned this issue Apr 6, 2017
Closed
whesse pushed a commit to dart-lang/sdk that referenced this issue Apr 7, 2017
@munificent @whesse
Update dart_style.
309b880 
This brings in an important fix for formatting generic function-typed
parameters. See:

dart-lang/dart_style#613

R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2805103002 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@munificent @asgerf