Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add firehose workflow #1228

Merged
merged 2 commits into from
Jun 2, 2023
Merged

add firehose workflow #1228

merged 2 commits into from
Jun 2, 2023

Conversation

jakemac53
Copy link
Contributor

This adds the worflow I talked about before - I think its worth trying out and you can always remove it if you want. You will also need to enable automated publish in the pub admin page https://pub.dev/packages/dart_style/admin.

See https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose#integrating-this-tool-into-a-repo

Note that if you ever need to publish from a dev/beta SDK then we would want to require that sdk, see https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose#publishing-from-a-specific-version-of-the-sdk. Happy to add that config if you think it is necessary.

@jakemac53 jakemac53 requested a review from munificent May 25, 2023 20:44
@jakemac53
Copy link
Contributor Author

Note that firehose does enforce a certain format for the changelog so I had to update that also

@jakemac53
Copy link
Contributor Author

See dart-archive/logging#140 (comment) as an example of how the workflow works - when you bump the version to one that looks like you want to publish it will add this comment, once you merge you can just click the linked tag to create the release and it will auto-publish.

Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I enabled publishing the package on the admin page, so I'll try this out the next time I'm ready to push a release.

@jakemac53
Copy link
Contributor Author

Note that in the admin settings you have the tag pattern set to just {{version}} where here I have it set to v{{version}} which is more the convention we use elsewhere - it looks like a mix has been used in this package.

Whatever you use doesn't matter, but the admin page and config here do need to agree :). Should I remove the preceding v from this config?

@munificent
Copy link
Member

you have the tag pattern set to just {{version}} where here I have it set to v{{version}} which is more the convention we use elsewhere - it looks like a mix has been used in this package.

Yes, I have always consistently used just the version number, but some other people who have published versions of the package didn't follow the existing convention.

Whatever you use doesn't matter, but the admin page and config here do need to agree :). Should I remove the preceding v from this config?

Oh, good point. Switch to v{{version}} on the admin page since that's what we use for other packages.

@jakemac53
Copy link
Contributor Author

but some other people who have published versions of the package didn't follow the existing convention.

This should resolve that issue :)

@jakemac53 jakemac53 merged commit 9c60d1a into main Jun 2, 2023
@jakemac53 jakemac53 deleted the publish-bot branch June 2, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants