Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit 494ed83

Browse files
committed
Remove WIP label, make categories always expanded, move build number down.
R=efortuna@google.com Review URL: https://chromiumcodereview.appspot.com//60233005
1 parent 133d7b0 commit 494ed83

File tree

7 files changed

+9
-12
lines changed

7 files changed

+9
-12
lines changed

client/web/app.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ class Viewer extends Observable {
237237
return lib.load();
238238
}
239239

240-
Future<List<Item>> getMember(Library lib, DocsLocation location) {
240+
Future<List<Item>> getMember(lib, DocsLocation location) {
241241
var member = lib.memberNamed(location.memberName);
242242
if (member == null) return new Future.value([lib, null]);
243243
return member.load().then((mem) => new Future.value([lib, member]));

client/web/category.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class CategoryElement extends DartdocElement {
2626
notifyPropertyChange(#accordionParent,
2727
accordionParentFor(change.oldValue), accordionParent);
2828
notifyPropertyChange(#divClass, divClassFor(change.oldValue), divClass);
29-
notifyPropertyChange(#divStyle, divStyleFor(change.oldValue), divStyle);
3029
});
3130
new PathObserver(viewer, "isInherited").changes.listen((changes) {
3231
_flushCache();
@@ -122,9 +121,6 @@ class CategoryElement extends DartdocElement {
122121

123122
@observable get divClass => divClassFor(viewer.isDesktop);
124123
divClassFor(isDesktop) => isDesktop ? 'collapse in' : 'collapse';
125-
@observable get divStyle => divStyleFor(viewer.isDesktop);
126-
divStyleFor(isDesktop) => isDesktop ? 'auto' : '0px';
127-
128124

129125
var validator = new NodeValidatorBuilder()
130126
..allowHtml5(uriPolicy: new SameProtocolUriPolicy())

client/web/category.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
data-toggle="collapse"
1313
data-parent="{{accordionParent}}"
1414
data-target="#accordion-{{stylizedName}}">
15-
{{title}}
15+
{{title}}<b class="caret"></b>
1616
</a>
1717
</div>
1818

1919
<div id="accordion-{{stylizedName}}"
2020
class="accordion-body {{divClass}}"
21-
style="height:{{divStyle}}">
21+
style="height:auto">
2222
<div class="accordion-inner">
2323
<ul id="itemList" class="nav nav-pills nav-stacked">
2424
</ul>

client/web/library-panel.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<polymer-element name="dartdoc-library-panel">
44
<template>
5-
<div class="list-group visible-lg col-lg-2 affix-left"
5+
<div class="list-group affix-left"
66
id="library-panel">
77
</div>
88
{{createEntries()}}

client/web/main.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<a href="http://api.dartlang.org/" class="navbar-brand header-logo"></a>
2929
<a href="#home"
3030
class="navbar-brand btn-link">
31-
Dart API Reference (Work-in-Progress) {{buildIdentifier}}
31+
Dart API Reference
3232
</a>
3333

3434
<div class="nav-collapse collapse navbar-responsive-collapse"
@@ -92,8 +92,9 @@
9292
<dartdoc-minimap-class item={{viewer.currentPage}}>
9393
</dartdoc-minimap-class>
9494
</template>
95-
95+
<div>Dart Build {{buildIdentifier}}</div>
9696
</div>
97+
9798
</template>
9899
</polymer-element>
99100
<script type="application/dart" src="main.dart"></script>

client/web/minimap-class.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
<polymer-element name="dartdoc-minimap-class" attributes="item">
55
<template>
6-
<div class="visible-lg col-lg-3 well well-sm nav affix-right"
6+
<div class="well well-sm nav affix-right"
77
id="minimap">
88
<a href="#{{linkHref}}">
99
{{name}} Class

client/web/minimap-library.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<polymer-element name="dartdoc-minimap-library"
55
attributes="item">
66
<template>
7-
<div class="visible-lg col-lg-3 well well-sm nav affix-right"
7+
<div class="well well-sm nav affix-right"
88
id="minimap">
99
<a href="#{{linkHref}}">
1010
{{name}} library

0 commit comments

Comments
 (0)