Parameterized type hierarchy change #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 1, 2021
This is not a full release of dartdoc; this patch (matching dart-lang/dartdoc#2714), helps unblock https://dart-review.googlesource.com/c/sdk/+/185903. Change-Id: I6bfea10d253b251a61525459d0fb1c26649929a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205700 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Janice Collins <jcollins@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue blocking https://dart-review.googlesource.com/c/sdk/+/185903. Dartdoc was still trying to cast a type where it shouldn't. Also add some test coverage as besides building the SDK this case was uncovered.