Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the main library to "http2.dart" #3

Closed
nex3 opened this issue Sep 8, 2015 · 3 comments
Closed

Rename the main library to "http2.dart" #3

nex3 opened this issue Sep 8, 2015 · 3 comments

Comments

@nex3
Copy link
Member

nex3 commented Sep 8, 2015

It's a strong convention among Dart packages to have a top-level library with the same name as the package (usually as the only top-level library). It's confusing that this package is named http2 but the top-level library is named transport.dart rather than http2.dart.

@mkustermann
Copy link
Member

This was intentional. The transitive closure of transport.dart can be made independent of dart:io if necessary. The package might nonetheless provide some helpers which use features of dart:io (e.g. Socket, ...). So http2.dart could re-export transport.dart and other helpers. (see e.g. the comment Would it be possible for this to be implemented in such a way as to optionally support use with the Chrome sockets API?)

On the other hand, in 99% of cases one doesn't care, so we could also rename it.

@nex3
Copy link
Member Author

nex3 commented Sep 11, 2015

Maybe the best thing to do would be to rename it for now, and then if it becomes necessary to have an IO-free library in the future re-add transport.dart and export it from http2.dart.

@sethladd
Copy link
Contributor

Let's pick the best name, without worrying too much about cases like Chrome sockets APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants