Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http2.dart and prepare for 1.0 #39

Merged
merged 3 commits into from
Dec 14, 2018
Merged

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Dec 13, 2018

@sigurdm
Copy link
Contributor Author

sigurdm commented Dec 13, 2018

cc @mkustermann

@@ -1,4 +1,9 @@
## 1.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a line here with * Graduate package to 1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@mkustermann mkustermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Though notice that there is still no stream prioritization implementation (afaik)

@sigurdm
Copy link
Contributor Author

sigurdm commented Dec 13, 2018

Right. I am not sure what that would entail.
Would you consider that needed for a 1.0?
Would it be a breaking change to add it?

@jonasfj
Copy link
Member

jonasfj commented Dec 13, 2018

Though notice that there is still no stream prioritization implementation (afaik)

@mkustermann, is there any reason to believe this can't be implemented without breaking the public API?

I'm not sure how it would look, but really that's the only question before going 1.0.

@kevmoo
Copy link
Member

kevmoo commented Dec 13, 2018

Since this is a breaking change release, could we remove one of the top-level libraries? Or both? Could we just have http2.dart?

@mkustermann
Copy link
Member

For some background: It's called transport.dart because it's implementing the transport mechanism. It doesn't implement application-level things (like making a http get request, ...)

I'm not sure how it would look, but really that's the only question before going 1.0.

If we don't expose priorities to the user, it can be implemented without breaking changes, yes.

@sigurdm
Copy link
Contributor Author

sigurdm commented Dec 14, 2018

Since this is a breaking change release, could we remove one of the top-level libraries? Or both? Could we just have http2.dart?

I don't think we should make breaking changes just because we can.
I prefer to keep the existing library around.

Also, looking forward http2.dart could expose more high-level abstractions...

@sigurdm
Copy link
Contributor Author

sigurdm commented Dec 14, 2018

When we implement priorities we can go to 2.0 if it turns out to be best done in a breaking fashion.

I think the library as it is now implements a meaningful and useful subset of http2, and it is fair to give it a stable version number indicating that users can feel comfortable relying on it.

@sigurdm sigurdm merged commit b6b875b into dart-lang:master Dec 14, 2018
mosuem pushed a commit to dart-lang/http that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status and priority
6 participants