-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http2.dart and prepare for 1.0 #39
Conversation
cc @mkustermann |
@@ -1,4 +1,9 @@ | |||
## 1.0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a line here with * Graduate package to 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Though notice that there is still no stream prioritization implementation (afaik)
Right. I am not sure what that would entail. |
@mkustermann, is there any reason to believe this can't be implemented without breaking the public API? I'm not sure how it would look, but really that's the only question before going 1.0. |
Since this is a breaking change release, could we remove one of the top-level libraries? Or both? Could we just have |
For some background: It's called
If we don't expose priorities to the user, it can be implemented without breaking changes, yes. |
I don't think we should make breaking changes just because we can. Also, looking forward |
When we implement priorities we can go to 2.0 if it turns out to be best done in a breaking fashion. I think the library as it is now implements a meaningful and useful subset of http2, and it is fair to give it a stable version number indicating that users can feel comfortable relying on it. |
* Add http2.dart, prepare for 1.0
This fixes dart-lang/http#1352 and dart-lang/http#1344