Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added central kordi to the rtl language regex #863

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

badeesAbood
Copy link
Contributor

i have noticed the issue numbered #827 and modified the regex in the isRtl in bidi to handle central Kordi .
it should work now , I hope it is an ideal solution

Copy link

google-cla bot commented Aug 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mosuem
Copy link
Member

mosuem commented Aug 7, 2024

Thanks - could you sign the CLA so we can move this forward?

Copy link

github-actions bot commented Aug 7, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
intl None 0.20.0-wip 0.20.0-wip 0.20.0-wip ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage
pkgs/intl/lib/src/intl/bidi.dart 💚 97 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
intl _DateFormatField
StringStack
DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.9.2-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@badeesAbood
Copy link
Contributor Author

Thanks - could you sign the CLA so we can move this forward?

I've just signed the CLA

@mosuem
Copy link
Member

mosuem commented Aug 7, 2024

A changelog entry (see the health check) and you are good to go!

@badeesAbood
Copy link
Contributor Author

A changelog entry (see the health check) and you are good to go!
it should be all good now I guess .

@copybara-service copybara-service bot merged commit 1fb3117 into dart-lang:main Aug 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants