Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyPath: add parameter followLinks #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gmpassos
Copy link

Directory.listSync only returns Link entries if followLinks: false is passed.

copyPath needs a followLinks parameter to configure the call of Directory.listSync and allow the copy of Link entries, as expected by line else if (file is Link) {

`Directory.listSync` only returns `Link` entries if `followLinks: false` is passed. `copyPath` needs a `followLinks` parameter to configure the call of `Directory.listSync` and allow the copy of `Link` entries, as expected by line `else if (file is Link) {`
@natebosch
Copy link
Member

Can you add a test and a CHANGELOG entry?

@gmpassos
Copy link
Author

gmpassos commented May 26, 2023

Can you add a test and a CHANGELOG entry?

👍

https://github.com/gmpassos/dart-io-copy-path-test

@devoncarew devoncarew added the needs-info Additional information needed from the issue author label May 31, 2023
@natebosch
Copy link
Member

Thanks for the example - can we find a way to test this in the local unit tests?

We also still need a CHANGELOG entry.

https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#changelog-entries

@github-actions github-actions bot removed the needs-info Additional information needed from the issue author label Jun 6, 2023
@gmpassos
Copy link
Author

Thanks for the example - can we find a way to test this in the local unit tests?

We also still need a CHANGELOG entry.

I will try this in the next week. Regards.

@gmpassos
Copy link
Author

Still need an unit test?

@natebosch
Copy link
Member

Still need an unit test?

Yes - if we break this functionality there should be some local test which signals the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants