-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart project not getting set when lints are run from within DAS. #154
Comments
Is this still an issue? |
I see it referenced from the |
I believe so. It looks like we're only initializing project instances here: DartProject project = await DartProject.create(analysisDriver, sources);
Registry.ruleRegistry.forEach((lint) {
if (lint is ProjectVisitor) {
(lint as ProjectVisitor).visit(project);
}
}); |
I came here from package_api_docs.dart; it's not firing in google3 at all, it looks like we need to wire this up somehow. Any pointers please? |
Also related: #1786. The rub is our notion of "project" hinged on the presence of a pubspec. That obviously doesn't translate to google3. We're part of the way there to a better solution where For that, see: https://dart-review.googlesource.com/c/sdk/+/123341 When we have a new analyzer roll (cc @stereotype441), we can start playing around with that. |
Picked up in #3395. |
For example,
package_prefixed_library_names
here: dart-lang/sdk#24947.The text was updated successfully, but these errors were encountered: