add missing lints in analysis_options.yaml #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Jul 6, 2018
|
Thinking out loud: should we consider adding a validation step to the tests to ensure this stays up to date? See also #1051, which has I think some relevant conversation. |
pq
approved these changes
Jul 6, 2018
pq
reviewed
Jul 6, 2018
analysis_options.yaml
Outdated
| @@ -16,20 +16,30 @@ linter: | |||
| - annotate_overrides | |||
| - avoid_annotating_with_dynamic | |||
| # - avoid_as | |||
| # - avoid_bool_literals_in_conditional_expressions # not yet tested | |||
There was a problem hiding this comment.
Actually, on reading this again, I'm not sure this note is totally accurate. Maybe a link to #1068 instead? Maybe something like:
# under review (see #1068)
pq
requested changes
Jul 6, 2018
|
PTAL |
|
Super. Thanks! |
srawlins
added a commit
to srawlins/linter
that referenced
this pull request
Aug 7, 2018
* master: (41 commits) New lint: prefer_void_to_null (dart-lang#1100) Fix warnings in the linter code base echo dart version (dart-lang#1103) Update google.yaml (dart-lang#1094) improved description (dart-lang#1092) Address review comments special case with ignore for lines_longer_than_80_chars 0.1.58 (dart-lang#1086) Roll-back use of optional new/const; add `no-preview-dart-2` bot. (dart-lang#1084) 0.1.57 (dart-lang#1080) address review comments address review comments fix lines_longer_than_80_chars for \r Fix npe in non_constant_identifier_names chore: set max SDK version to <3.0.0 (dart-lang#1077) Update google.yaml (dart-lang#1076) Google internal rules (dart-lang#1075) Prevent an NPE when dealing with incomplete/invalid code add missing lints in analysis_options.yaml (dart-lang#1069) fomatting fixes (dart-lang#1067) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.