Don't check if iterable is nullable, what matters is null-aware calls #4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
set-recommended
oprypin
force-pushed
the
foreach_calls_no_null
branch
from
25bd5bb
to
b305085
Compare
oprypin
force-pushed
the
foreach_calls_no_null
branch
from
b305085
to
27cf88f
Compare
bwilkerson
approved these changes
May 8, 2023
pq
approved these changes
May 8, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 9, 2023
See: dart-lang/linter#4330 Change-Id: I9d891d5e3cffe594d0f884eae56dfed7647e09db Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302040 Reviewed-by: Oleh Prypin <oprypin@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
…dart-lang/linter#4330) Fixes dart-lang/linter#4328. Reverts dart-lang/linter#4039 that caused false negatives in non-null-safe mode. And reverts dart-lang/linter#2752 along with it because it was not the exact right fix in the first place. Null-aware calls are since handled by dart-lang/linter#4305 and all the existing tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes avoid_function_literals_in_foreach_calls fails to handle legacy types #4328.
Reverts Don't report
avoid_function_literals_in_foreach_callswith null-aware call #4039 that caused false negatives in non-null-safe mode.And reverts skip nullable iterables in
avoid_function_literals_in_foreach_calls#2752 along with it because it was not the exact right fix in the first place.Null-aware calls are since handled by Don't report avoid_function_literals_in_foreach_calls with null-aware chain #4305 and all the existing tests still pass.