[unreachable_from_main] Support for instance members. #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
reviewed
Jun 8, 2023
| @@ -181,6 +229,16 @@ class _ReferenceVisitor extends RecursiveAstVisitor { | |||
| super.visitClassDeclaration(node); | |||
| } | |||
|
|
|||
| @override | |||
| visitConstantPattern(ConstantPattern node) { | |||
| _patternLevel++; | |||
srawlins
approved these changes
Jun 8, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 9, 2023
dart-lang/linter#4441 Change-Id: I55afa6b7d78bc1114ce97c1b5bebcf7a8bca5b98 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307975 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applied to
analyzer/,analysis_server, etc found a handful of violations.https://dart-review.googlesource.com/c/sdk/+/307975