-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Cannot add to an unmodifiable list' seen when running the flutter_markdown tests #480
Comments
Yeah we can back out the specific diff |
srawlins
added a commit
to flutter/packages
that referenced
this issue
Nov 1, 2022
The children list of an Element became unmodifiable in dart-lang/markdown#463, so this just changes flutter_markdown to not modify the children, in a test. Fixes dart-lang/markdown#480
Merged
11 tasks
srawlins
added a commit
to flutter/packages
that referenced
this issue
Nov 2, 2022
…ction (#2758) Do not modify children of a markdown Element after construction The children list of an Element became unmodifiable in dart-lang/markdown#463, so this just changes flutter_markdown to not modify the children, in a test. Fixes dart-lang/markdown#480
percula
pushed a commit
to percula/packages
that referenced
this issue
Nov 17, 2022
…ction (flutter#2758) Do not modify children of a markdown Element after construction The children list of an Element became unmodifiable in dart-lang/markdown#463, so this just changes flutter_markdown to not modify the children, in a test. Fixes dart-lang/markdown#480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I bisected a recent roll failure to d72ae07 ; here is the test failure:
The text was updated successfully, but these errors were encountered: