Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate heading IDs for headings with no content in HeaderWithIdSyntax #522

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Do not generate heading IDs for headings with no content in HeaderWithIdSyntax #522

merged 2 commits into from
Feb 16, 2023

Conversation

chenzhiguang
Copy link
Contributor

Fix #521

@coveralls
Copy link

coveralls commented Feb 16, 2023 •
edited

Pull Request Test Coverage Report for Build 4195915960

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 96.066%
Totals Coverage Status
Change from base Build 4187194284: 0.003%
Covered Lines: 1392
Relevant Lines: 1449
💛 - Coveralls

@chenzhiguang chenzhiguang mentioned this pull request Feb 16, 2023
Closed
@srawlins srawlins merged commit 4befe66 into dart-lang:master Feb 16, 2023
@chenzhiguang chenzhiguang deleted the Fix-HeaderWithIdSyntax branch February 16, 2023 17:24
@chenzhiguang chenzhiguang restored the Fix-HeaderWithIdSyntax branch March 11, 2023 12:18
@chenzhiguang chenzhiguang deleted the Fix-HeaderWithIdSyntax branch March 11, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception on parsing # characters with GitHubWeb extension (markdown 7.0.1)
3 participants
@chenzhiguang @coveralls @srawlins