This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Extension Sets #55
Merged
Extension Sets #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ author: Dart Team <misc@dartlang.org> | |||
| description: A library for converting markdown to HTML. | |||
| homepage: https://github.com/dart-lang/markdown | |||
| environment: | |||
| sdk: '>=1.8.0 <2.0.0' | |||
| sdk: '>=1.12.0 <2.0.0' | |||
There was a problem hiding this comment.
This is needed for ??=. Is it crazy to bump the SDK for this reason?
|
A couple of suggestions but 👍 |
srawlins
force-pushed
the
extension-sets
branch
from
f1c3ea5 to
ea6dc90
Compare
srawlins
force-pushed
the
extension-sets
branch
from
ea6dc90 to
7f825bb
Compare
|
Thanks @munificent |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should support CommonMark by default.
This does that, which means that calling
markdownToHtml()as before will keep the fenced code blocks, which good for things like, all of the READMEs and dartdoc comments that are currently using fenced code blocks.