-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows & MSVC support #16
Conversation
Something iffy is going on with the code-paths on the Windows bot: edit: An older build did the coverage correctly: https://coveralls.io/builds/59308648 Both builds have checked out the code in D:\a\native\native. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @dcharkes!
Thanks @HosseinYousefi The current PR doesn't work on the Dart CI bots, because |
Compilation on Windows with visual studio.
Closes:
Some more details:
cl.exe
, there are two, one for each target architecture.vcvarsxxx.bat
has to be invoked. We capture the environment variables by looking atset
before and after the batch script invocation.This PR contains a lot of
.toFilePath()
refactorings to ensure paths are handled correctly on Windows.Also in this PR, the
RelativePath
tool resolver now takes globs instead of uri's so that we can resolve relative paths with/bla/*/
where*
can be a version number for example.