-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_toolchain_c] Add linking on Linux #987
Conversation
PR HealthBreaking changes ✔️Details
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
@dcharkes if you want to take a first look. |
native_toolchain_c
native_toolchain_c
and linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add linking for native_toolchain_c and linux
[native_toolchain_c] Linker support for Linux
pkgs/native_assets_builder/test_data/treeshaking_native_assets/hook/build.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_assets/hook/build.dart
Outdated
Show resolved
Hide resolved
pkgs/native_toolchain_c/lib/src/native_toolchain/recognizer.dart
Outdated
Show resolved
Hide resolved
pkgs/native_toolchain_c/lib/src/native_toolchain/recognizer.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_assets/hook/link.dart
Outdated
Show resolved
Hide resolved
ce7da4b
to
7078488
Compare
pkgs/native_assets_builder/test_data/treeshaking_native_libs/hook/build.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_libs/hook/link.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_libs/hook/link.dart
Show resolved
Hide resolved
...tive_assets_builder/test_data/treeshaking_native_libs/test/treeshaking_native_libs_test.dart
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_libs/ffigen.yaml
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_libs/hook/link.dart
Outdated
Show resolved
Hide resolved
pkgs/native_toolchain_c/test/clinker/test_data/linker/symbols.lds
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to do cross arch, not only cross OS. Please add support/tests or an unsupported error.
I think after that it's good to merge! 🚀
pkgs/native_assets_builder/test_data/treeshaking_native_libs/hook/build.dart
Outdated
Show resolved
Hide resolved
...native_assets_builder/test_data/treeshaking_native_libs/lib/src/treeshaking_native_libs.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_libs/lib/treeshaking_native_libs.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_libs/src/native_add.c
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test_data/treeshaking_native_libs/src/native_add.h
Outdated
Show resolved
Hide resolved
...tive_assets_builder/test_data/treeshaking_native_libs/test/treeshaking_native_libs_test.dart
Outdated
Show resolved
Hide resolved
native_toolchain_c
and linux
Extend API by providing a
CLinker
, supporting development only on linux for now. Other platforms to be added in future PRs.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.