Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource class is being removed #1446

Closed
floitschG opened this issue Sep 2, 2016 · 3 comments
Closed

Resource class is being removed #1446

floitschG opened this issue Sep 2, 2016 · 3 comments

Comments

@floitschG
Copy link
Contributor

The Resource class will be removed in the next Dart release. There are still tests that depend on it (for example, 'test/run/resource_test.dart'. These tests will stop working.
@kwalrath
Copy link
Contributor

kwalrath commented Sep 6, 2016 •
edited
Loading

Should they be using https://pub.dartlang.org/packages/resource instead?

@floitschG
Copy link
Contributor Author

Yes, the Resource class has been moved into that package.
I'm not sure how this applies to pub, since it only uses that class in some test, but I doubt it's a problem to depend on the resource package.

@whesse
Copy link
Contributor

whesse commented Sep 21, 2016

These 7 tests are failing consistently on the buildbot, and locally. Submitted CL https://codereview.chromium.org/2357263002/ to suppress them until this issue is fixed.

whesse added a commit that referenced this issue Sep 21, 2016
@whesse
Update status for failing resource tests.
4ef3e3e 
BUG=#1446
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2357263002 .
whesse added a commit to dart-lang/sdk that referenced this issue Sep 21, 2016
@whesse
Roll pub in DEPS to pick up test status change
1c41399 
Does not roll dartium DEPS because it and other packages are at
much earlier versions.
Dartium DEPS should be updated all at once, in a different CL

BUG=dart-lang/pub#1446
TBR=rnystrom@google.com

Review URL: https://codereview.chromium.org/2358083002 .
nex3 added a commit that referenced this issue Sep 27, 2016
@nex3
Test package APIs rather than resource APIs.
d0461a2 
Closes #1446
@nex3 nex3 mentioned this issue Sep 27, 2016
Merged
nex3 added a commit that referenced this issue Sep 29, 2016
@nex3
Test package APIs rather than resource APIs.
64a4813 
Test package APIs rather than resource APIs.

Closes #1446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwalrath @whesse @floitschG