Look for the new snapshot error message from the Dart 2 VM. #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Jun 26, 2018
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 27, 2018
Change-Id: Ifa2158fb61f174fca93f70b3548a59266cd2dd95 Reviewed-on: https://dart-review.googlesource.com/62460 Reviewed-by: Natalie Weizenbaum <nweiz@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Bob Nystrom <rnystrom@google.com>
aam
added a commit
to aam/engine
that referenced
this pull request
Jun 28, 2018
Changes since last roll: ``` 4552beb Revert "[vm/kernel-service] Report an error if isolate compilation options change." f304948 [vm] Refactoring: extract kernel translation helpers to a separate file 5a47f4c Apply resolution for ParameterElement metadata. db7b507 Reenable FutureOr resynthesis tests with kernel. 1f8148f [infra] Restore sync-async behavior to fix legacy precompiler bots d9911b8 Add language_2 test status entries for -cdart2analyzer --use-cfe b0b1020 [fasta] Add more tests for noSuchMethod forwarders 90e27b1 Check for conflicts between a static setter and a constructor or static method. b0cbc4e Fix a bug in top-level type inference dependency tracking 29924c4 In observatory use ArgumentError instead of FallThroughError bd9aa51 Error on cyclic constructor redirect. 1a6c857 Remove ExpressionGenerator.buildThrowNoSuchMethodError c53746f Add lexeme2 template key 2f739fd Default implementation of _makeRead and _makeWrite 36b22c7 Remove unused files 583a81a [infra] Make test.py's --strong option a no-op to prepare for removing it 17b53a2 Test out no_implicit_casts on the analyzer source base. 2ee6359 Revert separation of getOutline() and getResolution() in FrontEndCompiler. fc472e0 Don't store resolution for desugaring generated NotJudgment. e0845f9 [vm/kernel-service] Report an error if isolate compilation options change. cc30bda In resynthesis tests, do not attempt to distinguish missing bound from Object. a1bd1dd Use standard I/O posix functions for Fuchsia, not 64 bit variants 6f284b4 Fixes for applying resolution to InstanceCreationExpression. 1eacd27 [VM runtime] Type bounds do not need to be checked during type finalization in strong mode, since bound checks are explicitly emitted where needed. 5db9e6c [VM interpreter] Do not load bytecode of synthesized functions with copied metadata. Fix return of native call to bytecode function. Fix stack level when returning from static field initializer. Use a zone handle for handled exception types. bcacff4 Ignore deferredCheck() in resolution storer. 423edf8 Fix analyzer/FE integration of local generic functions with bounds. 0e7e0c9 [vm/kernel/bytecode] Generate argument checks after allocating initial context 3fd6164 Fix analyzer/FE integration of redirected constructors involving type arguments. d03210c Fix storage of types for local functions that are generic. 4426f5a [gardening] Mark large_class_declaration_test Slow in debug, dart1 8525370 [build] Include kernel-service snapshot in the platform sdk f0bc620 Validate location in store(). b4a426f [dart:io] Adds HttpClient.connectionTimeout cb4a19b misc(pkg/analyzer): update to latest pkg:matcher API d2bde00 Cleanup skipFormalParameters and remove unused methods 56cb7ba Fix for applying resolution to static field annotations. 723bcbd Added link to see webdev.dartlang.org b9dbe3a Fix analyzer/FE integration for `is!` expressions. bef0eca [gardening] Update status after a7f0f7e f5e8cc3 Remove old code with incorrect instantiation to bounds on typedefs edf2685 linter 0.1.55 5443583 [VM] - Add --preview-dart-2 option back as a nop - Temporarily treat --checked as an alias for --enable-asserts in Dart2 mode so that google3 test scripts don't need to change. e7da604 More updates for -DuseFastaParser. efa4b21 [fuchsia] Update zx_cprng_draw a7f0f7e [vm] Add source positions to stack traces of bool checks 70087c3 Fixes for applying resolution to annotations. 21b077a Fix incorrect handling of non-generic typedefs. 37d9e79 Update co19 and co19 strong branch in DEPS 7d1642e [gardening] Mark large_class_declaration_test Slow. dce6663 Add message to assert to explain the problem b20dc7b Update the script to re-gen the analysis server spec. 29c549b [vm/kernel] Use old space in a specific Kernel FE error allocation. e13b9e8 [fasta] Update expectation files after cf2966e 46167df It is OK to declare a const constructor in a class with a mixin, if it has no fields. 88a88b0 Fix token used for large negative integers. b43dc89 Remove spec references to Symbol constructor. cf2966e [fasta] Generate noSuchMethod forwarders for abstract accessors 28ed0d7 Make it explicit that "dynamic" is exported from dart:core. ce312b9 Add --analyzer-use-fasta and --analyzer-use-fasta-parser to test.py 25286e4 Add tests for optimization of Flutters use of Widget.runtimeType df2529d Detect when a class has a member that conflicts with a static one 50fe42a Reduce use of putIfAbsent 385cde3 Resolve 'dynamic' element references. 70576f4 Roll dart-lang/pub#1938 into the SDK. 46710a7 Make checked flag again only enable assertions in Dart 2.0 e0905b9 Revert "Add ClassHierarchy to share code between J/KClosedWorld" 9179db8 Resynthesize typedef types properly from kernel. c53952a [vm/kernel/bytecode] Generate bytecode for assertions, bool checks a6c2c97 Rename ResynthesizeKernelStrongTest to ResynthesizeTest_Kernel cad8d4a Store instance creation information at arguments offset. a4c7cf3 First stab at a parsing library for named configurations. 008aa72 [VM interpreter] Support implicit getters and setters without compiling them. 54bc154 [fuchsia] Update to Sync2Ptr 05b1994 Prep for analyzer 0.32.2 a1efbd3 Change FrontEndCompiler.getOutline() to return full kernels. 966541b Improve literal function recovery 386efb1 Improve type parameter recovery 5c9add2 Allow Future<T> to be assigned to Future<void> 9c7cd04 [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6 [gardening] Update status file 5a19375 Clean up some hints e67c595 Relax return restrictions. a9c624a [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f3 Update dart_style package to 1.1.0 in DEPS f67308a Handle invalid dill files more gracefully 9aa0c4a [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3 Update app_jitk service status a16ad6d [infra] Make update_homebrew script work on Dart2 014a5bc Replace strstr with strncmp looking for path separator d2d47ac [kernel] Include urls even when we have no source 5f17b0a Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3 Add tests showing the async impact on function type checks 8e4d5c0 Update formated error for nonexisting constructor a8e930c Add ClassHierarchy to share code between J/KClosedWorld c9bd4df Document IntLiteral.value as holding a uint64 value 56d5740 Fix status for new test ed20faa Add test for rejecting inexact numbers 31ed467 Fix directory-prefix finding logic so it works on Windows. 2d6eaba pkg:build_integration: clarify that' it's not planned to be published f67cba1 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd0 Doc - Fix OSError.message and errorCode doc c97f177 Issue 33518. Fix for subtypes() in parts without library. e661c9e Simplify 'as T' for simple T 65a3c44 [observatory] Update packages and remove dead dependencies. b155729 Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533f snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623 Check function types in the correct order in runZoned. 6d25212 getStats Future should be strongly typed. ca99917 Remove code awaiting void results to unblock flutter#33145 19f60bf Improve fasta parser expression recovery d632980 Add tokens to more judgements 5721d8a - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037 Fix second half on flutter#33343: disallow generic functions as type arguments. 97c81d6 Remove variableSet factory methods. 98efc79 Improve parse assert statement recovery a93e303 [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81b Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6 Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560 Count analyzer cfe integration failing tests. 77f94ec Convert ShadowLogicalExpression to LogicalJudgment 1a0fc73 Add tokens to more judgements 8119118 Remove unused class 284b5cc Partial fix of flutter#33343. Reject generic function types as bounds. ada8188 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbda Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e [fasta] Update .expect files for non-simple bound tests aeff1c0 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8c [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a5 Change infer to return the expression instead of its type b9f1131 [vm/compiler] Fix incorrect assertion from 20ca5bb. f85fbde Expression compilation fix 6240dd5 Make incremental_load_from_dill_test dart2 compliant 8747da8 Bump kernel version after e2ce88d 20ca5bb [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817 Check whether variables is set before using GN not_needed f381778 Update the status of analysis server tests. 8b10b1f Add tokens to judgements, part 2 8c1591a Add a binder mechanism to the Factory API for handling labels. e132240 Re-enable some failing analyzer_cli --use-cfe tests. f598e69 Drop support for Dart 1 in pub 9146cea Print times in seconds ec0df45 Convert invocation Shadow(s) to Judgment(s). 223b143 Workaround for issue 33559. 091f886 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27 Add unittest for InferenceData 70ac1f9 Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82e [dart2js] Fix for issue 33572 1416ed2 Convert ShadowNot to NotJudgment. a1a2d90 Convert ShadowForStatement to ForJudgment. 7c6211b Make unittests work with Dart 2 a8d8050 Handle covariant parameters in function types b241702 Don't add parts without 'part of' as libraries. fea8cb1 Revise order of type variable declaration events 6339976 Rename lemma to binder 9d499ff Start adding tokens to judgements ff7a125 Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70e Docs - Update example websockets app; use idiomatic async/await in examples ed0ba90 Doc - Fix library links in analyzer docs 4c69708 dart2js: Make bazel-input-provider dart2 compliant. 9b814bd Use the lemma approach for NamedFunctionExpression 7c0d310 Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353 Update dartdoc to 0.20.1. eafa9ae [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708e [VM interpreter] Fix broken interpreter build. 94abf94 pkg:status_file misc cleanup 0272170 Fix a committed solo test and mark it as passing now. c8a488c Add parameters to Forest method to support labeled statements c4d6ac0 [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363c Rename typeContext to inferredType 10dcad1 pkg:kernel - cleanup pubspec file 7e7fd7f Convert ShadowLiteralList into LiteralListJudgment 4fe71ec [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9 Fix cascade specification. d08317b Make status file linter valid Dart 2 code f4d2bf3 Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2 Compile time error for web int literals that cannot be represented exactly 075c713 Register type arguments on inlining 4ebdb31 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90 Convert ShadowRethrow to RethrowJudgment 7661841 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd4072 Convert ShadowIfNullExpression to IfNullJudgment 7c327c3 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0f Convert ShadowStringConcatenation to StringConcatenationJudgment d065506 Use the lemma approach for other variable declaring constructs. 2121c3b Docs - Link to the Random.secure constructor in dartdoc 975686d [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c2 [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38d [vm, standalone] Do not copy when loading kernel. 8d7c529 Rename the kernel ShadowExpressions for assignments 47f394d Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4 Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af8 DEPS: update crypto version 530f1f6 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc335 Replace and remove parseType 1b681a7 Modify Factory API to allow forward references to incomplete local functions and variables. f682213 Add parameters to Factory methods to support the try statement cf6fbd9 Add parameters to Factory methods to support the switch statement b50ff49 Add parameters to Factory methods for list and map literals c585563 Add Factory method parameters for for loops c2a22c6 Updates to ddc/ddb tool 1a1ff9e Reverse the pub snapshot names d5d5daf Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c Fix docs for async File methods 569341c Improve CompressionOptions docs: 8d40afc Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfc Convert ShadowForInStatement to ForInJudgment. f2eaf6a Remove type parameters from the Fasta BodyBuilder 74dd544 Convert ShadowStringLiteral into StringLiteralJudgment 10641cb Update status files after 52b2a86 ee19f28 Make ResolutionStorer implement the Factory API. e2ce88d Add startFileOffset on procedures et al, enable VMs GetSource 52b2a86 Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9 Update testing scripts to run on a Dart 2 VM 8638668 [VM] Fix vm->native state transition in isolate_reload.cc 71ac67a [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8df Stop using !kernel annotations 3e85df5 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcc Roll pub to the latest version. abc8793 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb15 [vmservice] Report expression compilation errors b28ebca Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848f Convert ShadowWhileStatement to WhileJudgment. 5ccc497 Inline constructor bodies that are called once 4df1462 Add parameters to Factory methods for constructor initializers dce00bc - fix a strong mode type error - mark a test as slow 83a4d98 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1f Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f5 Convert ShadowTryCatch to TryCatchJudgment. 6182b72 [vm/kernel/bytecode] Fix passing of type arguments b343d0a trigger error for const A(B()) if B non-const 06a5882 Fix package_root_test.dart on mac buildbot. 8419090 Cleanup type variable event sequence 8da6407 [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c1 [vm] Shorten the write barrier sequence. b6aa31f Add required parameters to Factory.catchStatement 34bbb1d [Gardening] Move status line to the correct section. 68ecf31 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1 Add parameters to Factory API, part 2 85c27d7 [Gardening] Removed incorrect entry in the status file. 2edbfd9 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b Added super_no_such_method5_test also to the issue list for 33517 254d8ef Switch ShadowYieldStatement to YieldJudgment. 64fd665 Update deprecated references. 13fb4da Convert ShadowIfStatement to IfJudgment. 71042d3 linter 0.1.54 e9f9948 Cleanup unescape error messages 7b68a45 Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9d Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85 Re-enable the old analyzer/FE integration logic. 9bd3350 Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353f Convert ShadowReturnStatement to ReturnJudgment. 462d2a3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8b [VM][kernel] Don't mix in noSuchMethod forwarders 6612278 Skip non-utf8 file tests on reload builders, where they time out 125fae6 Incorporate comments from an earlier code review 188c858 [gardening] Fix standalone/app_snapshot_share_test 1c4b362 Support noSuchMethod forwarders in dart2js 2765981 Make DDK interpret IntLiteral.value as uint64 a049e34 Revert the fix for issue flutter#31770 d4a69bd app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d [dart2js] Fix for issue 33500 828df76 Notify kernel service of isolate shutdown. a36fbd1 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d3 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983 Convert ShadowStaticGet to StaticGetJudgment acd375c [gardening] Silence flaky test which times out on simarm64 bot 3becdb8 Convert property gets to judgments. 9db4b71 Convert ShadowIntLiteral to IntJudgment 37084e6 Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8 Convert ShadowNullLiteral to NullJudgment. 3a2a84d Improve misplaced factory/modifier recovery 3586fcb Cleanup deprecated code eac395c Add parameters needed by analyzer to Factory, part 1 edcd3be Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683 Convert ShadowDoStatement to DoJudgment. 8e8fb38 Convert ShadowBlock to BlockJudgment. b71fb2e Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f232 Enable Dart2 in dart2js by default 6b96e65 Convert ShadowArguments to ArgumentsJudgment. 437b492 [gardening] Update status for reload-kernel bots a3a1113 Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871a Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6 Add a Type parameter to Factory and update one method 1192369 [build] Remove tools/compile_platform.py ddde982 Improve fasta parser parameter list recovery f5a0e3e Create NamedExpressionJudgment. 165c57f Attempt to fix the windows bot 3 bb1fceb [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d5 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d395 Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49 Support asset directories in flutter pubspec validation. 015d9ef Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff93 Track which import is referenced by each prefix. 92c24a1 Skip sample_extension_app_snapshot_test on opt-counter-threshold builders 33d41a9 [VM] Fix incorrect memory allocation f3960a0 Fix language_2/vm/optimized_guarded_field_isolates_test e496efb [VM] Adjust status file after 6db5f38 ef49436 [fasta] Update expectation files after noSuchMethod forwarders change 049195b Fix path to entry points json file in app_snapshot_share_test b024432 [VM] Disable test in reload/rollback mode due to snapshot generation 6db5f38 [fasta] Don't generate noSuchMethod forwarders in abstract classes 7979232 Re-added header, only needed to remove the other resource section. a38b9be Restore dart2js-checked and dart-aot in try_benchmarks.sh. 7be47cd Remove some dead code (including implicit setters) 1c01aa7 Convert some ShadowExpressions into inference judgments 6e6bdb4 Ensure we run app_snapshot_share_test d7e5332 Make dual use of a part in the same program an error. 856c7c6 Skip standalone_2 on !strong configurations (for JIT / AOT VM) ba024be Mark dart2js specific argument as deprecated. 20fe2f0 Indent error pointer correctly in the presence of tabs. bd94de8 Use dynamic to fix string_interpolate_test b172a42 [VM] Catch errors for integer operations in kernel2kernel constant evaluator f288124 Fix InvalidInlineFunctionType example 15821a2 Explicit type args in body_builder 1f69257 Add message for missing type arguments 87e045c Remove the helper dart script from our browser test framework 532b9aa Flatten *WorldBuilder hierarchies. f1d44e3 Update status for passing Windows Firefox co19 tests efb4f69 Adjust simarm status. 1a443da Adjust options passed to precompile runtime. f8caffd Remove some uses of Platform.packageRoot. ebe2f1d Adjust status files. 6fcc95d Adjust status files. f2f6ebf Convert ShadowAssertInitializer to AssertInitializerJudgment. ea837c9 Transition tests to EvaluateCompiledExpression. 3e6e2dd Convert ShadowAssertStatement to AssertStatementJudgment. 27fefd7 Convert ShadowAwaitExpression to AwaitExpressionJudgment. dd1c54c Convert ShadowBoolLiteral to BoolLiteralJudgement 4a353fe Another attempt to fix tests on Windows a69d922 Adjust some of the test expectations based on the flip to Dart 2 mode. b3b8ca6 Remove the --package-default-analysis-options flag. 9943547 Default pub to Dart 2 with opt out aba94f0 Convert ShadowAsExpression to AsJudgment. bc7220a [VM] Turn dart2 on by default on the command line VM cdd2553 [vm/kernel/bytecode] Fix null handling in operator == df2bf65 [VM runtime] Minor cleanup of stubs on all architectures as already done for x64 b140bae Own files by their URIs during search. 56cee22 Build out the initial version of the Factory class (and derived classes). 83cb0c4 Fix awaiting void in analyzer ast_test.dart. Fix at method decl. c9af309 Fix fasta parsing of ?. in cascade expression 67695b9 Fix the dependencies on the dartdevk_sdk build step. 0a59b2f Fix test cases that await "void." Blocks flutter#33415, making that an error 3ba3e2a Revert "switch to dart_action until prebuilt Windows Dart VM is updated" 741ed33 Improve AstBuilder int literal recovery e77158e First steps toward generating analyzer/kernel ASTs during type inference. f1c3f99 [VM] Clear out return-value-register from call-to-runtime-stub, it needs to be GC-safe for lazy deopts 686fd13 [VM interpreter] Propagate unhandled exception returned from jitted code to interpreter. 8fedfc7 Removed DomName, DosEditable, and experimental annoations they are unused. 7d94755 Issue 33471. Use full ResolveResult in Extract Local refactoring. 57c0fc9 [vm/corelib] More cleanup in integer operations after _Bigint is removed 88d12fd Parse throw on RHS of an assignment 1dcc326 Fix tests that are failing on Windows 691313f Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin. e62f563 Validate sdkPath in AnalysisContextCollectionImpl. 493c421 Add AnalysisContextCollection. ```
aam
added a commit
to aam/engine
that referenced
this pull request
Jun 28, 2018
Changes since last roll: ``` 4552beb Revert "[vm/kernel-service] Report an error if isolate compilation options change." f304948 [vm] Refactoring: extract kernel translation helpers to a separate file 5a47f4c Apply resolution for ParameterElement metadata. db7b507 Reenable FutureOr resynthesis tests with kernel. 1f8148f [infra] Restore sync-async behavior to fix legacy precompiler bots d9911b8 Add language_2 test status entries for -cdart2analyzer --use-cfe b0b1020 [fasta] Add more tests for noSuchMethod forwarders 90e27b1 Check for conflicts between a static setter and a constructor or static method. b0cbc4e Fix a bug in top-level type inference dependency tracking 29924c4 In observatory use ArgumentError instead of FallThroughError bd9aa51 Error on cyclic constructor redirect. 1a6c857 Remove ExpressionGenerator.buildThrowNoSuchMethodError c53746f Add lexeme2 template key 2f739fd Default implementation of _makeRead and _makeWrite 36b22c7 Remove unused files 583a81a [infra] Make test.py's --strong option a no-op to prepare for removing it 17b53a2 Test out no_implicit_casts on the analyzer source base. 2ee6359 Revert separation of getOutline() and getResolution() in FrontEndCompiler. fc472e0 Don't store resolution for desugaring generated NotJudgment. e0845f9 [vm/kernel-service] Report an error if isolate compilation options change. cc30bda In resynthesis tests, do not attempt to distinguish missing bound from Object. a1bd1dd Use standard I/O posix functions for Fuchsia, not 64 bit variants 6f284b4 Fixes for applying resolution to InstanceCreationExpression. 1eacd27 [VM runtime] Type bounds do not need to be checked during type finalization in strong mode, since bound checks are explicitly emitted where needed. 5db9e6c [VM interpreter] Do not load bytecode of synthesized functions with copied metadata. Fix return of native call to bytecode function. Fix stack level when returning from static field initializer. Use a zone handle for handled exception types. bcacff4 Ignore deferredCheck() in resolution storer. 423edf8 Fix analyzer/FE integration of local generic functions with bounds. 0e7e0c9 [vm/kernel/bytecode] Generate argument checks after allocating initial context 3fd6164 Fix analyzer/FE integration of redirected constructors involving type arguments. d03210c Fix storage of types for local functions that are generic. 4426f5a [gardening] Mark large_class_declaration_test Slow in debug, dart1 8525370 [build] Include kernel-service snapshot in the platform sdk f0bc620 Validate location in store(). b4a426f [dart:io] Adds HttpClient.connectionTimeout cb4a19b misc(pkg/analyzer): update to latest pkg:matcher API d2bde00 Cleanup skipFormalParameters and remove unused methods 56cb7ba Fix for applying resolution to static field annotations. 723bcbd Added link to see webdev.dartlang.org b9dbe3a Fix analyzer/FE integration for `is!` expressions. bef0eca [gardening] Update status after a7f0f7e f5e8cc3 Remove old code with incorrect instantiation to bounds on typedefs edf2685 linter 0.1.55 5443583 [VM] - Add --preview-dart-2 option back as a nop - Temporarily treat --checked as an alias for --enable-asserts in Dart2 mode so that google3 test scripts don't need to change. e7da604 More updates for -DuseFastaParser. efa4b21 [fuchsia] Update zx_cprng_draw a7f0f7e [vm] Add source positions to stack traces of bool checks 70087c3 Fixes for applying resolution to annotations. 21b077a Fix incorrect handling of non-generic typedefs. 37d9e79 Update co19 and co19 strong branch in DEPS 7d1642e [gardening] Mark large_class_declaration_test Slow. dce6663 Add message to assert to explain the problem b20dc7b Update the script to re-gen the analysis server spec. 29c549b [vm/kernel] Use old space in a specific Kernel FE error allocation. e13b9e8 [fasta] Update expectation files after cf2966e 46167df It is OK to declare a const constructor in a class with a mixin, if it has no fields. 88a88b0 Fix token used for large negative integers. b43dc89 Remove spec references to Symbol constructor. cf2966e [fasta] Generate noSuchMethod forwarders for abstract accessors 28ed0d7 Make it explicit that "dynamic" is exported from dart:core. ce312b9 Add --analyzer-use-fasta and --analyzer-use-fasta-parser to test.py 25286e4 Add tests for optimization of Flutters use of Widget.runtimeType df2529d Detect when a class has a member that conflicts with a static one 50fe42a Reduce use of putIfAbsent 385cde3 Resolve 'dynamic' element references. 70576f4 Roll dart-lang/pub#1938 into the SDK. 46710a7 Make checked flag again only enable assertions in Dart 2.0 e0905b9 Revert "Add ClassHierarchy to share code between J/KClosedWorld" 9179db8 Resynthesize typedef types properly from kernel. c53952a [vm/kernel/bytecode] Generate bytecode for assertions, bool checks a6c2c97 Rename ResynthesizeKernelStrongTest to ResynthesizeTest_Kernel cad8d4a Store instance creation information at arguments offset. a4c7cf3 First stab at a parsing library for named configurations. 008aa72 [VM interpreter] Support implicit getters and setters without compiling them. 54bc154 [fuchsia] Update to Sync2Ptr 05b1994 Prep for analyzer 0.32.2 a1efbd3 Change FrontEndCompiler.getOutline() to return full kernels. 966541b Improve literal function recovery 386efb1 Improve type parameter recovery 5c9add2 Allow Future<T> to be assigned to Future<void> 9c7cd04 [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6 [gardening] Update status file 5a19375 Clean up some hints e67c595 Relax return restrictions. a9c624a [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f3 Update dart_style package to 1.1.0 in DEPS f67308a Handle invalid dill files more gracefully 9aa0c4a [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3 Update app_jitk service status a16ad6d [infra] Make update_homebrew script work on Dart2 014a5bc Replace strstr with strncmp looking for path separator d2d47ac [kernel] Include urls even when we have no source 5f17b0a Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3 Add tests showing the async impact on function type checks 8e4d5c0 Update formated error for nonexisting constructor a8e930c Add ClassHierarchy to share code between J/KClosedWorld c9bd4df Document IntLiteral.value as holding a uint64 value 56d5740 Fix status for new test ed20faa Add test for rejecting inexact numbers 31ed467 Fix directory-prefix finding logic so it works on Windows. 2d6eaba pkg:build_integration: clarify that' it's not planned to be published f67cba1 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd0 Doc - Fix OSError.message and errorCode doc c97f177 Issue 33518. Fix for subtypes() in parts without library. e661c9e Simplify 'as T' for simple T 65a3c44 [observatory] Update packages and remove dead dependencies. b155729 Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533f snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623 Check function types in the correct order in runZoned. 6d25212 getStats Future should be strongly typed. ca99917 Remove code awaiting void results to unblock flutter#33145 19f60bf Improve fasta parser expression recovery d632980 Add tokens to more judgements 5721d8a - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037 Fix second half on flutter#33343: disallow generic functions as type arguments. 97c81d6 Remove variableSet factory methods. 98efc79 Improve parse assert statement recovery a93e303 [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81b Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6 Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560 Count analyzer cfe integration failing tests. 77f94ec Convert ShadowLogicalExpression to LogicalJudgment 1a0fc73 Add tokens to more judgements 8119118 Remove unused class 284b5cc Partial fix of flutter#33343. Reject generic function types as bounds. ada8188 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbda Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e [fasta] Update .expect files for non-simple bound tests aeff1c0 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8c [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a5 Change infer to return the expression instead of its type b9f1131 [vm/compiler] Fix incorrect assertion from 20ca5bb. f85fbde Expression compilation fix 6240dd5 Make incremental_load_from_dill_test dart2 compliant 8747da8 Bump kernel version after e2ce88d 20ca5bb [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817 Check whether variables is set before using GN not_needed f381778 Update the status of analysis server tests. 8b10b1f Add tokens to judgements, part 2 8c1591a Add a binder mechanism to the Factory API for handling labels. e132240 Re-enable some failing analyzer_cli --use-cfe tests. f598e69 Drop support for Dart 1 in pub 9146cea Print times in seconds ec0df45 Convert invocation Shadow(s) to Judgment(s). 223b143 Workaround for issue 33559. 091f886 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27 Add unittest for InferenceData 70ac1f9 Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82e [dart2js] Fix for issue 33572 1416ed2 Convert ShadowNot to NotJudgment. a1a2d90 Convert ShadowForStatement to ForJudgment. 7c6211b Make unittests work with Dart 2 a8d8050 Handle covariant parameters in function types b241702 Don't add parts without 'part of' as libraries. fea8cb1 Revise order of type variable declaration events 6339976 Rename lemma to binder 9d499ff Start adding tokens to judgements ff7a125 Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70e Docs - Update example websockets app; use idiomatic async/await in examples ed0ba90 Doc - Fix library links in analyzer docs 4c69708 dart2js: Make bazel-input-provider dart2 compliant. 9b814bd Use the lemma approach for NamedFunctionExpression 7c0d310 Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353 Update dartdoc to 0.20.1. eafa9ae [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708e [VM interpreter] Fix broken interpreter build. 94abf94 pkg:status_file misc cleanup 0272170 Fix a committed solo test and mark it as passing now. c8a488c Add parameters to Forest method to support labeled statements c4d6ac0 [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363c Rename typeContext to inferredType 10dcad1 pkg:kernel - cleanup pubspec file 7e7fd7f Convert ShadowLiteralList into LiteralListJudgment 4fe71ec [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9 Fix cascade specification. d08317b Make status file linter valid Dart 2 code f4d2bf3 Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2 Compile time error for web int literals that cannot be represented exactly 075c713 Register type arguments on inlining 4ebdb31 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90 Convert ShadowRethrow to RethrowJudgment 7661841 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd4072 Convert ShadowIfNullExpression to IfNullJudgment 7c327c3 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0f Convert ShadowStringConcatenation to StringConcatenationJudgment d065506 Use the lemma approach for other variable declaring constructs. 2121c3b Docs - Link to the Random.secure constructor in dartdoc 975686d [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c2 [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38d [vm, standalone] Do not copy when loading kernel. 8d7c529 Rename the kernel ShadowExpressions for assignments 47f394d Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4 Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af8 DEPS: update crypto version 530f1f6 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc335 Replace and remove parseType 1b681a7 Modify Factory API to allow forward references to incomplete local functions and variables. f682213 Add parameters to Factory methods to support the try statement cf6fbd9 Add parameters to Factory methods to support the switch statement b50ff49 Add parameters to Factory methods for list and map literals c585563 Add Factory method parameters for for loops c2a22c6 Updates to ddc/ddb tool 1a1ff9e Reverse the pub snapshot names d5d5daf Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c Fix docs for async File methods 569341c Improve CompressionOptions docs: 8d40afc Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfc Convert ShadowForInStatement to ForInJudgment. f2eaf6a Remove type parameters from the Fasta BodyBuilder 74dd544 Convert ShadowStringLiteral into StringLiteralJudgment 10641cb Update status files after 52b2a86 ee19f28 Make ResolutionStorer implement the Factory API. e2ce88d Add startFileOffset on procedures et al, enable VMs GetSource 52b2a86 Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9 Update testing scripts to run on a Dart 2 VM 8638668 [VM] Fix vm->native state transition in isolate_reload.cc 71ac67a [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8df Stop using !kernel annotations 3e85df5 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcc Roll pub to the latest version. abc8793 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb15 [vmservice] Report expression compilation errors b28ebca Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848f Convert ShadowWhileStatement to WhileJudgment. 5ccc497 Inline constructor bodies that are called once 4df1462 Add parameters to Factory methods for constructor initializers dce00bc - fix a strong mode type error - mark a test as slow 83a4d98 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1f Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f5 Convert ShadowTryCatch to TryCatchJudgment. 6182b72 [vm/kernel/bytecode] Fix passing of type arguments b343d0a trigger error for const A(B()) if B non-const 06a5882 Fix package_root_test.dart on mac buildbot. 8419090 Cleanup type variable event sequence 8da6407 [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c1 [vm] Shorten the write barrier sequence. b6aa31f Add required parameters to Factory.catchStatement 34bbb1d [Gardening] Move status line to the correct section. 68ecf31 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1 Add parameters to Factory API, part 2 85c27d7 [Gardening] Removed incorrect entry in the status file. 2edbfd9 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b Added super_no_such_method5_test also to the issue list for 33517 254d8ef Switch ShadowYieldStatement to YieldJudgment. 64fd665 Update deprecated references. 13fb4da Convert ShadowIfStatement to IfJudgment. 71042d3 linter 0.1.54 e9f9948 Cleanup unescape error messages 7b68a45 Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9d Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85 Re-enable the old analyzer/FE integration logic. 9bd3350 Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353f Convert ShadowReturnStatement to ReturnJudgment. 462d2a3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8b [VM][kernel] Don't mix in noSuchMethod forwarders 6612278 Skip non-utf8 file tests on reload builders, where they time out 125fae6 Incorporate comments from an earlier code review 188c858 [gardening] Fix standalone/app_snapshot_share_test 1c4b362 Support noSuchMethod forwarders in dart2js 2765981 Make DDK interpret IntLiteral.value as uint64 a049e34 Revert the fix for issue flutter#31770 d4a69bd app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d [dart2js] Fix for issue 33500 828df76 Notify kernel service of isolate shutdown. a36fbd1 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d3 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983 Convert ShadowStaticGet to StaticGetJudgment acd375c [gardening] Silence flaky test which times out on simarm64 bot 3becdb8 Convert property gets to judgments. 9db4b71 Convert ShadowIntLiteral to IntJudgment 37084e6 Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8 Convert ShadowNullLiteral to NullJudgment. 3a2a84d Improve misplaced factory/modifier recovery 3586fcb Cleanup deprecated code eac395c Add parameters needed by analyzer to Factory, part 1 edcd3be Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683 Convert ShadowDoStatement to DoJudgment. 8e8fb38 Convert ShadowBlock to BlockJudgment. b71fb2e Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f232 Enable Dart2 in dart2js by default 6b96e65 Convert ShadowArguments to ArgumentsJudgment. 437b492 [gardening] Update status for reload-kernel bots a3a1113 Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871a Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6 Add a Type parameter to Factory and update one method 1192369 [build] Remove tools/compile_platform.py ddde982 Improve fasta parser parameter list recovery f5a0e3e Create NamedExpressionJudgment. 165c57f Attempt to fix the windows bot 3 bb1fceb [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d5 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d395 Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49 Support asset directories in flutter pubspec validation. 015d9ef Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff93 Track which import is referenced by each prefix. 92c24a1 Skip sample_extension_app_snapshot_test on opt-counter-threshold builders 33d41a9 [VM] Fix incorrect memory allocation f3960a0 Fix language_2/vm/optimized_guarded_field_isolates_test e496efb [VM] Adjust status file after 6db5f38 ef49436 [fasta] Update expectation files after noSuchMethod forwarders change 049195b Fix path to entry points json file in app_snapshot_share_test b024432 [VM] Disable test in reload/rollback mode due to snapshot generation 6db5f38 [fasta] Don't generate noSuchMethod forwarders in abstract classes 7979232 Re-added header, only needed to remove the other resource section. a38b9be Restore dart2js-checked and dart-aot in try_benchmarks.sh. 7be47cd Remove some dead code (including implicit setters) 1c01aa7 Convert some ShadowExpressions into inference judgments 6e6bdb4 Ensure we run app_snapshot_share_test d7e5332 Make dual use of a part in the same program an error. 856c7c6 Skip standalone_2 on !strong configurations (for JIT / AOT VM) ba024be Mark dart2js specific argument as deprecated. 20fe2f0 Indent error pointer correctly in the presence of tabs. bd94de8 Use dynamic to fix string_interpolate_test b172a42 [VM] Catch errors for integer operations in kernel2kernel constant evaluator f288124 Fix InvalidInlineFunctionType example 15821a2 Explicit type args in body_builder 1f69257 Add message for missing type arguments 87e045c Remove the helper dart script from our browser test framework 532b9aa Flatten *WorldBuilder hierarchies. f1d44e3 Update status for passing Windows Firefox co19 tests efb4f69 Adjust simarm status. 1a443da Adjust options passed to precompile runtime. f8caffd Remove some uses of Platform.packageRoot. ebe2f1d Adjust status files. 6fcc95d Adjust status files. f2f6ebf Convert ShadowAssertInitializer to AssertInitializerJudgment. ea837c9 Transition tests to EvaluateCompiledExpression. 3e6e2dd Convert ShadowAssertStatement to AssertStatementJudgment. 27fefd7 Convert ShadowAwaitExpression to AwaitExpressionJudgment. dd1c54c Convert ShadowBoolLiteral to BoolLiteralJudgement 4a353fe Another attempt to fix tests on Windows a69d922 Adjust some of the test expectations based on the flip to Dart 2 mode. b3b8ca6 Remove the --package-default-analysis-options flag. 9943547 Default pub to Dart 2 with opt out aba94f0 Convert ShadowAsExpression to AsJudgment. bc7220a [VM] Turn dart2 on by default on the command line VM cdd2553 [vm/kernel/bytecode] Fix null handling in operator == df2bf65 [VM runtime] Minor cleanup of stubs on all architectures as already done for x64 b140bae Own files by their URIs during search. 56cee22 Build out the initial version of the Factory class (and derived classes). 83cb0c4 Fix awaiting void in analyzer ast_test.dart. Fix at method decl. c9af309 Fix fasta parsing of ?. in cascade expression 67695b9 Fix the dependencies on the dartdevk_sdk build step. 0a59b2f Fix test cases that await "void." Blocks flutter#33415, making that an error 3ba3e2a Revert "switch to dart_action until prebuilt Windows Dart VM is updated" 741ed33 Improve AstBuilder int literal recovery e77158e First steps toward generating analyzer/kernel ASTs during type inference. f1c3f99 [VM] Clear out return-value-register from call-to-runtime-stub, it needs to be GC-safe for lazy deopts 686fd13 [VM interpreter] Propagate unhandled exception returned from jitted code to interpreter. 8fedfc7 Removed DomName, DosEditable, and experimental annoations they are unused. 7d94755 Issue 33471. Use full ResolveResult in Extract Local refactoring. 57c0fc9 [vm/corelib] More cleanup in integer operations after _Bigint is removed 88d12fd Parse throw on RHS of an assignment 1dcc326 Fix tests that are failing on Windows 691313f Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin. e62f563 Validate sdkPath in AnalysisContextCollectionImpl. 493c421 Add AnalysisContextCollection. ```
aam
added a commit
to flutter/engine
that referenced
this pull request
Jul 3, 2018
* Roll dart sdk to 9c7cd04e7f285c3e74f54def9f91dbdd1a18b1ba. Changes since last roll: ``` 9c7cd04e7f [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6661 [gardening] Update status file 5a193752f6 Clean up some hints e67c5953e9 Relax return restrictions. a9c624a010 [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f37a9 Update dart_style package to 1.1.0 in DEPS f67308a983 Handle invalid dill files more gracefully 9aa0c4ae3f [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3bc2 Update app_jitk service status a16ad6d9de [infra] Make update_homebrew script work on Dart2 014a5bc678 Replace strstr with strncmp looking for path separator d2d47acdce [kernel] Include urls even when we have no source 5f17b0a0be Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3c1d Add tests showing the async impact on function type checks 8e4d5c0a38 Update formated error for nonexisting constructor a8e930caf3 Add ClassHierarchy to share code between J/KClosedWorld c9bd4df214 Document IntLiteral.value as holding a uint64 value 56d57407e1 Fix status for new test ed20faa2ed Add test for rejecting inexact numbers 31ed467871 Fix directory-prefix finding logic so it works on Windows. 2d6eaba187 pkg:build_integration: clarify that' it's not planned to be published f67cba1067 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd08fb Doc - Fix OSError.message and errorCode doc c97f177112 Issue 33518. Fix for subtypes() in parts without library. e661c9ef54 Simplify 'as T' for simple T 65a3c4443b [observatory] Update packages and remove dead dependencies. b15572933d Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533ff72 snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6232 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623654 Check function types in the correct order in runZoned. 6d25212302 getStats Future should be strongly typed. ca99917fb6 Remove code awaiting void results to unblock #33145 19f60bfb52 Improve fasta parser expression recovery d632980ee0 Add tokens to more judgements 5721d8af6d - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037164 Fix second half on #33343: disallow generic functions as type arguments. 97c81d668a Remove variableSet factory methods. 98efc7917f Improve parse assert statement recovery a93e303f3f [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81bfe7 Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6cae Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560fc6 Count analyzer cfe integration failing tests. 77f94ec259 Convert ShadowLogicalExpression to LogicalJudgment 1a0fc733d3 Add tokens to more judgements 81191186d8 Remove unused class 284b5cce55 Partial fix of #33343. Reject generic function types as bounds. ada8188b73 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd28c [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbdac5c Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e182 [fasta] Update .expect files for non-simple bound tests aeff1c00f2 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a55c1 Change infer to return the expression instead of its type b9f11311f8 [vm/compiler] Fix incorrect assertion from 20ca5bbb056. f85fbde727 Expression compilation fix 6240dd5cc3 Make incremental_load_from_dill_test dart2 compliant 8747da838f Bump kernel version after e2ce88d 20ca5bbb05 [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec380 [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817322 Check whether variables is set before using GN not_needed f381778867 Update the status of analysis server tests. 8b10b1fda9 Add tokens to judgements, part 2 8c1591af9e Add a binder mechanism to the Factory API for handling labels. e132240c91 Re-enable some failing analyzer_cli --use-cfe tests. f598e6933c Drop support for Dart 1 in pub 9146cea63a Print times in seconds ec0df457a2 Convert invocation Shadow(s) to Judgment(s). 223b143167 Workaround for issue 33559. 091f8860c2 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27acd Add unittest for InferenceData 70ac1f90ec Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576dd4 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82ef9a [dart2js] Fix for issue 33572 1416ed283a Convert ShadowNot to NotJudgment. a1a2d90a6c Convert ShadowForStatement to ForJudgment. 7c6211b1d8 Make unittests work with Dart 2 a8d805055a Handle covariant parameters in function types b24170259c Don't add parts without 'part of' as libraries. fea8cb1473 Revise order of type variable declaration events 6339976567 Rename lemma to binder 9d499fffe4 Start adding tokens to judgements ff7a1255aa Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70ec5b Docs - Update example websockets app; use idiomatic async/await in examples ed0ba901e1 Doc - Fix library links in analyzer docs 4c697085be dart2js: Make bazel-input-provider dart2 compliant. 9b814bdf34 Use the lemma approach for NamedFunctionExpression 7c0d31092d Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353f76 Update dartdoc to 0.20.1. eafa9ae4b6 [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708eada [VM interpreter] Fix broken interpreter build. 94abf948c4 pkg:status_file misc cleanup 02721709c3 Fix a committed solo test and mark it as passing now. c8a488c1ca Add parameters to Forest method to support labeled statements c4d6ac0cbe [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363cba0 Rename typeContext to inferredType 10dcad1dd2 pkg:kernel - cleanup pubspec file 7e7fd7ffa5 Convert ShadowLiteralList into LiteralListJudgment 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2840 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9af5 Fix cascade specification. d08317b79f Make status file linter valid Dart 2 code f4d2bf313e Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2824 Compile time error for web int literals that cannot be represented exactly 075c713a93 Register type arguments on inlining 4ebdb31646 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90c42 Convert ShadowRethrow to RethrowJudgment 7661841cc5 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd40725af Convert ShadowIfNullExpression to IfNullJudgment 7c327c32b7 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c8f3 [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0ff07 Convert ShadowStringConcatenation to StringConcatenationJudgment d0655066a5 Use the lemma approach for other variable declaring constructs. 2121c3bb56 Docs - Link to the Random.secure constructor in dartdoc 975686d5a9 [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c268e [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38dec5 [vm, standalone] Do not copy when loading kernel. 8d7c5294c6 Rename the kernel ShadowExpressions for assignments 47f394d61c Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4cdf Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af84e7 DEPS: update crypto version 530f1f6512 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc3352e0 Replace and remove parseType 1b681a75c3 Modify Factory API to allow forward references to incomplete local functions and variables. f682213764 Add parameters to Factory methods to support the try statement cf6fbd9e07 Add parameters to Factory methods to support the switch statement b50ff4990a Add parameters to Factory methods for list and map literals c5855635ae Add Factory method parameters for for loops c2a22c6462 Updates to ddc/ddb tool 1a1ff9e666 Reverse the pub snapshot names d5d5daf411 Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c636 Fix docs for async File methods 569341cbe0 Improve CompressionOptions docs: 8d40afc9c0 Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfcacb Convert ShadowForInStatement to ForInJudgment. f2eaf6aae7 Remove type parameters from the Fasta BodyBuilder 74dd5440f1 Convert ShadowStringLiteral into StringLiteralJudgment 10641cbf42 Update status files after 52b2a869bcb93 ee19f2804a Make ResolutionStorer implement the Factory API. e2ce88dfcc Add startFileOffset on procedures et al, enable VMs GetSource 52b2a869bc Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9163 Update testing scripts to run on a Dart 2 VM 8638668ecf [VM] Fix vm->native state transition in isolate_reload.cc 71ac67aed1 [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8dfe85 Stop using !kernel annotations 3e85df5167 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575a54 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcca7f Roll pub to the latest version. abc8793109 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb154e9 [vmservice] Report expression compilation errors b28ebca825 Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2305 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848fe0f Convert ShadowWhileStatement to WhileJudgment. 5ccc497678 Inline constructor bodies that are called once 4df14626b3 Add parameters to Factory methods for constructor initializers dce00bc836 - fix a strong mode type error - mark a test as slow 83a4d98554 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee90f [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1fad8 Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f578c Convert ShadowTryCatch to TryCatchJudgment. 6182b7215d [vm/kernel/bytecode] Fix passing of type arguments b343d0a80d trigger error for const A(B()) if B non-const 06a588233c Fix package_root_test.dart on mac buildbot. 8419090c8c Cleanup type variable event sequence 8da640704a [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe657 Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c141f [vm] Shorten the write barrier sequence. b6aa31f7d8 Add required parameters to Factory.catchStatement 34bbb1da30 [Gardening] Move status line to the correct section. 68ecf31fc5 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1cd7 Add parameters to Factory API, part 2 85c27d78c1 [Gardening] Removed incorrect entry in the status file. 2edbfd95a7 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b130 Added super_no_such_method5_test also to the issue list for 33517 254d8ef153 Switch ShadowYieldStatement to YieldJudgment. 64fd6653cf Update deprecated references. 13fb4da312 Convert ShadowIfStatement to IfJudgment. 71042d3dfa linter 0.1.54 e9f994892d Cleanup unescape error messages 7b68a4516f Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9dca5 Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85c76 Re-enable the old analyzer/FE integration logic. 9bd3350f1f Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353fe29 Convert ShadowReturnStatement to ReturnJudgment. 462d2a35d3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8bbd5 [VM][kernel] Don't mix in noSuchMethod forwarders 6612278b71 Skip non-utf8 file tests on reload builders, where they time out 125fae6d56 Incorporate comments from an earlier code review 188c858a4c [gardening] Fix standalone/app_snapshot_share_test 1c4b362ba5 Support noSuchMethod forwarders in dart2js 276598199e Make DDK interpret IntLiteral.value as uint64 a049e340eb Revert the fix for issue #31770 d4a69bde98 app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d6d9 [dart2js] Fix for issue 33500 828df76c85 Notify kernel service of isolate shutdown. a36fbd1990 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d33d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d35f5 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983e0a Convert ShadowStaticGet to StaticGetJudgment acd375cc77 [gardening] Silence flaky test which times out on simarm64 bot 3becdb8afd Convert property gets to judgments. 9db4b71442 Convert ShadowIntLiteral to IntJudgment 37084e677c Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8e42 Convert ShadowNullLiteral to NullJudgment. 3a2a84db9c Improve misplaced factory/modifier recovery 3586fcb165 Cleanup deprecated code eac395c33d Add parameters needed by analyzer to Factory, part 1 edcd3be290 Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683a88 Convert ShadowDoStatement to DoJudgment. 8e8fb38c48 Convert ShadowBlock to BlockJudgment. b71fb2e086 Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f23243b Enable Dart2 in dart2js by default 6b96e65c5b Convert ShadowArguments to ArgumentsJudgment. 437b492042 [gardening] Update status for reload-kernel bots a3a1113cfd Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871ae88 Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6a49 Add a Type parameter to Factory and update one method 119236996a [build] Remove tools/compile_platform.py ddde9820a9 Improve fasta parser parameter list recovery f5a0e3efa8 Create NamedExpressionJudgment. 165c57ffd7 Attempt to fix the windows bot 3 bb1fcebd36 [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d54c6 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d39504f Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49134 Support asset directories in flutter pubspec validation. 015d9eff49 Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff9361f Track which import is referenced by each prefix. 92c24a1ee7 Skip sample_extension_app_snapshot_test on opt-counter-threshold builders 33d41a928a [VM] Fix incorrect memory allocation f3960a0111 Fix language_2/vm/optimized_guarded_field_isolates_test e496efb611 [VM] Adjust status file after 6db5f38d4ee4d ef49436487 [fasta] Update expectation files after noSuchMethod forwarders change 049195b15d Fix path to entry points json file in app_snapshot_share_test b024432a29 [VM] Disable test in reload/rollback mode due to snapshot generation 6db5f38d4e [fasta] Don't generate noSuchMethod forwarders in abstract classes 7979232580 Re-added header, only needed to remove the other resource section. a38b9bed23 Restore dart2js-checked and dart-aot in try_benchmarks.sh. 7be47cd30d Remove some dead code (including implicit setters) 1c01aa7704 Convert some ShadowExpressions into inference judgments 6e6bdb486a Ensure we run app_snapshot_share_test d7e5332057 Make dual use of a part in the same program an error. 856c7c67ea Skip standalone_2 on !strong configurations (for JIT / AOT VM) ba024be044 Mark dart2js specific argument as deprecated. 20fe2f0ada Indent error pointer correctly in the presence of tabs. bd94de8e48 Use dynamic to fix string_interpolate_test b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator f288124d5a Fix InvalidInlineFunctionType example 15821a28a3 Explicit type args in body_builder 1f6925718b Add message for missing type arguments 87e045c484 Remove the helper dart script from our browser test framework 532b9aaa93 Flatten *WorldBuilder hierarchies. f1d44e39fa Update status for passing Windows Firefox co19 tests efb4f69a13 Adjust simarm status. 1a443da6ad Adjust options passed to precompile runtime. f8caffd9e6 Remove some uses of Platform.packageRoot. ebe2f1db2c Adjust status files. 6fcc95d2a4 Adjust status files. f2f6ebf547 Convert ShadowAssertInitializer to AssertInitializerJudgment. ea837c91a0 Transition tests to EvaluateCompiledExpression. 3e6e2dd7f4 Convert ShadowAssertStatement to AssertStatementJudgment. 27fefd7bb3 Convert ShadowAwaitExpression to AwaitExpressionJudgment. dd1c54c442 Convert ShadowBoolLiteral to BoolLiteralJudgement 4a353fea35 Another attempt to fix tests on Windows a69d922794 Adjust some of the test expectations based on the flip to Dart 2 mode. b3b8ca6dc4 Remove the --package-default-analysis-options flag. 9943547d5d Default pub to Dart 2 with opt out aba94f051e Convert ShadowAsExpression to AsJudgment. bc7220a4fd [VM] Turn dart2 on by default on the command line VM cdd2553a12 [vm/kernel/bytecode] Fix null handling in operator == df2bf6590d [VM runtime] Minor cleanup of stubs on all architectures as already done for x64 b140baeb55 Own files by their URIs during search. 56cee22800 Build out the initial version of the Factory class (and derived classes). 83cb0c425d Fix awaiting void in analyzer ast_test.dart. Fix at method decl. c9af309cbf Fix fasta parsing of ?. in cascade expression 67695b9842 Fix the dependencies on the dartdevk_sdk build step. 0a59b2ff90 Fix test cases that await "void." Blocks #33415, making that an error 3ba3e2a752 Revert "switch to dart_action until prebuilt Windows Dart VM is updated" 741ed336f1 Improve AstBuilder int literal recovery e77158eb38 First steps toward generating analyzer/kernel ASTs during type inference. f1c3f997bd [VM] Clear out return-value-register from call-to-runtime-stub, it needs to be GC-safe for lazy deopts 686fd133a7 [VM interpreter] Propagate unhandled exception returned from jitted code to interpreter. 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 7d94755836 Issue 33471. Use full ResolveResult in Extract Local refactoring. 57c0fc9593 [vm/corelib] More cleanup in integer operations after _Bigint is removed 88d12fda42 Parse throw on RHS of an assignment 1dcc3264e7 Fix tests that are failing on Windows 691313f357 Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin. e62f563b2d Validate sdkPath in AnalysisContextCollectionImpl. 493c421f0d Add AnalysisContextCollection. ``` * Roll dart sdk to 4552beb514c5b54fbe9c5a0791f7b95253ac09b9. Changes since last roll: ``` 4552beb514 Revert "[vm/kernel-service] Report an error if isolate compilation options change." f304948807 [vm] Refactoring: extract kernel translation helpers to a separate file 5a47f4c9fa Apply resolution for ParameterElement metadata. db7b5072af Reenable FutureOr resynthesis tests with kernel. 1f8148f862 [infra] Restore sync-async behavior to fix legacy precompiler bots d9911b8a8a Add language_2 test status entries for -cdart2analyzer --use-cfe b0b1020588 [fasta] Add more tests for noSuchMethod forwarders 90e27b19ea Check for conflicts between a static setter and a constructor or static method. b0cbc4e9cd Fix a bug in top-level type inference dependency tracking 29924c4000 In observatory use ArgumentError instead of FallThroughError bd9aa5139a Error on cyclic constructor redirect. 1a6c857a93 Remove ExpressionGenerator.buildThrowNoSuchMethodError c53746fc8a Add lexeme2 template key 2f739fd7d9 Default implementation of _makeRead and _makeWrite 36b22c7ae9 Remove unused files 583a81ade3 [infra] Make test.py's --strong option a no-op to prepare for removing it 17b53a2835 Test out no_implicit_casts on the analyzer source base. 2ee635977d Revert separation of getOutline() and getResolution() in FrontEndCompiler. fc472e03da Don't store resolution for desugaring generated NotJudgment. e0845f9359 [vm/kernel-service] Report an error if isolate compilation options change. cc30bda2be In resynthesis tests, do not attempt to distinguish missing bound from Object. a1bd1dd6ee Use standard I/O posix functions for Fuchsia, not 64 bit variants 6f284b45f7 Fixes for applying resolution to InstanceCreationExpression. 1eacd27b8e [VM runtime] Type bounds do not need to be checked during type finalization in strong mode, since bound checks are explicitly emitted where needed. 5db9e6c95e [VM interpreter] Do not load bytecode of synthesized functions with copied metadata. Fix return of native call to bytecode function. Fix stack level when returning from static field initializer. Use a zone handle for handled exception types. bcacff49ba Ignore deferredCheck() in resolution storer. 423edf86be Fix analyzer/FE integration of local generic functions with bounds. 0e7e0c945a [vm/kernel/bytecode] Generate argument checks after allocating initial context 3fd61646ce Fix analyzer/FE integration of redirected constructors involving type arguments. d03210cdf4 Fix storage of types for local functions that are generic. 4426f5a33e [gardening] Mark large_class_declaration_test Slow in debug, dart1 85253708a3 [build] Include kernel-service snapshot in the platform sdk f0bc620143 Validate location in store(). b4a426fa72 [dart:io] Adds HttpClient.connectionTimeout cb4a19b5fc misc(pkg/analyzer): update to latest pkg:matcher API d2bde00d9d Cleanup skipFormalParameters and remove unused methods 56cb7bac02 Fix for applying resolution to static field annotations. 723bcbd5f9 Added link to see webdev.dartlang.org b9dbe3a0be Fix analyzer/FE integration for `is!` expressions. bef0eca2e3 [gardening] Update status after a7f0f7ea899fe7812f54eea8f957a92153e3176e f5e8cc3517 Remove old code with incorrect instantiation to bounds on typedefs edf26852e6 linter 0.1.55 544358304d [VM] - Add --preview-dart-2 option back as a nop - Temporarily treat --checked as an alias for --enable-asserts in Dart2 mode so that google3 test scripts don't need to change. e7da604c11 More updates for -DuseFastaParser. efa4b21c4f [fuchsia] Update zx_cprng_draw a7f0f7ea89 [vm] Add source positions to stack traces of bool checks 70087c349b Fixes for applying resolution to annotations. 21b077a81c Fix incorrect handling of non-generic typedefs. 37d9e79b1b Update co19 and co19 strong branch in DEPS 7d1642e081 [gardening] Mark large_class_declaration_test Slow. dce6663028 Add message to assert to explain the problem b20dc7b98a Update the script to re-gen the analysis server spec. 29c549bfe2 [vm/kernel] Use old space in a specific Kernel FE error allocation. e13b9e8a75 [fasta] Update expectation files after cf2966ea 46167dfd88 It is OK to declare a const constructor in a class with a mixin, if it has no fields. 88a88b03dc Fix token used for large negative integers. b43dc893eb Remove spec references to Symbol constructor. cf2966ea0d [fasta] Generate noSuchMethod forwarders for abstract accessors 28ed0d743d Make it explicit that "dynamic" is exported from dart:core. ce312b9632 Add --analyzer-use-fasta and --analyzer-use-fasta-parser to test.py 25286e4a7d Add tests for optimization of Flutters use of Widget.runtimeType df2529d443 Detect when a class has a member that conflicts with a static one 50fe42a886 Reduce use of putIfAbsent 385cde3977 Resolve 'dynamic' element references. 70576f431e Roll https://github.com/dart-lang/pub/pull/1938 into the SDK. 46710a77dd Make checked flag again only enable assertions in Dart 2.0 e0905b979a Revert "Add ClassHierarchy to share code between J/KClosedWorld" 9179db84df Resynthesize typedef types properly from kernel. c53952a46d [vm/kernel/bytecode] Generate bytecode for assertions, bool checks a6c2c97d7e Rename ResynthesizeKernelStrongTest to ResynthesizeTest_Kernel cad8d4a741 Store instance creation information at arguments offset. a4c7cf388f First stab at a parsing library for named configurations. 008aa729c5 [VM interpreter] Support implicit getters and setters without compiling them. 54bc1548b0 [fuchsia] Update to Sync2Ptr 05b19947a4 Prep for analyzer 0.32.2 a1efbd326f Change FrontEndCompiler.getOutline() to return full kernels. 966541bec9 Improve literal function recovery 386efb1e6a Improve type parameter recovery 5c9add2c46 Allow Future<T> to be assigned to Future<void> 9c7cd04e7f [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6661 [gardening] Update status file 5a193752f6 Clean up some hints e67c5953e9 Relax return restrictions. a9c624a010 [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f37a9 Update dart_style package to 1.1.0 in DEPS f67308a983 Handle invalid dill files more gracefully 9aa0c4ae3f [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3bc2 Update app_jitk service status a16ad6d9de [infra] Make update_homebrew script work on Dart2 014a5bc678 Replace strstr with strncmp looking for path separator d2d47acdce [kernel] Include urls even when we have no source 5f17b0a0be Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3c1d Add tests showing the async impact on function type checks 8e4d5c0a38 Update formated error for nonexisting constructor a8e930caf3 Add ClassHierarchy to share code between J/KClosedWorld c9bd4df214 Document IntLiteral.value as holding a uint64 value 56d57407e1 Fix status for new test ed20faa2ed Add test for rejecting inexact numbers 31ed467871 Fix directory-prefix finding logic so it works on Windows. 2d6eaba187 pkg:build_integration: clarify that' it's not planned to be published f67cba1067 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd08fb Doc - Fix OSError.message and errorCode doc c97f177112 Issue 33518. Fix for subtypes() in parts without library. e661c9ef54 Simplify 'as T' for simple T 65a3c4443b [observatory] Update packages and remove dead dependencies. b15572933d Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533ff72 snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6232 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623654 Check function types in the correct order in runZoned. 6d25212302 getStats Future should be strongly typed. ca99917fb6 Remove code awaiting void results to unblock #33145 19f60bfb52 Improve fasta parser expression recovery d632980ee0 Add tokens to more judgements 5721d8af6d - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037164 Fix second half on #33343: disallow generic functions as type arguments. 97c81d668a Remove variableSet factory methods. 98efc7917f Improve parse assert statement recovery a93e303f3f [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81bfe7 Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6cae Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560fc6 Count analyzer cfe integration failing tests. 77f94ec259 Convert ShadowLogicalExpression to LogicalJudgment 1a0fc733d3 Add tokens to more judgements 81191186d8 Remove unused class 284b5cce55 Partial fix of #33343. Reject generic function types as bounds. ada8188b73 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd28c [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbdac5c Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e182 [fasta] Update .expect files for non-simple bound tests aeff1c00f2 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a55c1 Change infer to return the expression instead of its type b9f11311f8 [vm/compiler] Fix incorrect assertion from 20ca5bbb056. f85fbde727 Expression compilation fix 6240dd5cc3 Make incremental_load_from_dill_test dart2 compliant 8747da838f Bump kernel version after e2ce88d 20ca5bbb05 [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec380 [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817322 Check whether variables is set before using GN not_needed f381778867 Update the status of analysis server tests. 8b10b1fda9 Add tokens to judgements, part 2 8c1591af9e Add a binder mechanism to the Factory API for handling labels. e132240c91 Re-enable some failing analyzer_cli --use-cfe tests. f598e6933c Drop support for Dart 1 in pub 9146cea63a Print times in seconds ec0df457a2 Convert invocation Shadow(s) to Judgment(s). 223b143167 Workaround for issue 33559. 091f8860c2 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27acd Add unittest for InferenceData 70ac1f90ec Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576dd4 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82ef9a [dart2js] Fix for issue 33572 1416ed283a Convert ShadowNot to NotJudgment. a1a2d90a6c Convert ShadowForStatement to ForJudgment. 7c6211b1d8 Make unittests work with Dart 2 a8d805055a Handle covariant parameters in function types b24170259c Don't add parts without 'part of' as libraries. fea8cb1473 Revise order of type variable declaration events 6339976567 Rename lemma to binder 9d499fffe4 Start adding tokens to judgements ff7a1255aa Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70ec5b Docs - Update example websockets app; use idiomatic async/await in examples ed0ba901e1 Doc - Fix library links in analyzer docs 4c697085be dart2js: Make bazel-input-provider dart2 compliant. 9b814bdf34 Use the lemma approach for NamedFunctionExpression 7c0d31092d Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353f76 Update dartdoc to 0.20.1. eafa9ae4b6 [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708eada [VM interpreter] Fix broken interpreter build. 94abf948c4 pkg:status_file misc cleanup 02721709c3 Fix a committed solo test and mark it as passing now. c8a488c1ca Add parameters to Forest method to support labeled statements c4d6ac0cbe [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363cba0 Rename typeContext to inferredType 10dcad1dd2 pkg:kernel - cleanup pubspec file 7e7fd7ffa5 Convert ShadowLiteralList into LiteralListJudgment 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2840 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9af5 Fix cascade specification. d08317b79f Make status file linter valid Dart 2 code f4d2bf313e Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2824 Compile time error for web int literals that cannot be represented exactly 075c713a93 Register type arguments on inlining 4ebdb31646 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90c42 Convert ShadowRethrow to RethrowJudgment 7661841cc5 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd40725af Convert ShadowIfNullExpression to IfNullJudgment 7c327c32b7 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c8f3 [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0ff07 Convert ShadowStringConcatenation to StringConcatenationJudgment d0655066a5 Use the lemma approach for other variable declaring constructs. 2121c3bb56 Docs - Link to the Random.secure constructor in dartdoc 975686d5a9 [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c268e [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38dec5 [vm, standalone] Do not copy when loading kernel. 8d7c5294c6 Rename the kernel ShadowExpressions for assignments 47f394d61c Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4cdf Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af84e7 DEPS: update crypto version 530f1f6512 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc3352e0 Replace and remove parseType 1b681a75c3 Modify Factory API to allow forward references to incomplete local functions and variables. f682213764 Add parameters to Factory methods to support the try statement cf6fbd9e07 Add parameters to Factory methods to support the switch statement b50ff4990a Add parameters to Factory methods for list and map literals c5855635ae Add Factory method parameters for for loops c2a22c6462 Updates to ddc/ddb tool 1a1ff9e666 Reverse the pub snapshot names d5d5daf411 Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c636 Fix docs for async File methods 569341cbe0 Improve CompressionOptions docs: 8d40afc9c0 Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfcacb Convert ShadowForInStatement to ForInJudgment. f2eaf6aae7 Remove type parameters from the Fasta BodyBuilder 74dd5440f1 Convert ShadowStringLiteral into StringLiteralJudgment 10641cbf42 Update status files after 52b2a869bcb93 ee19f2804a Make ResolutionStorer implement the Factory API. e2ce88dfcc Add startFileOffset on procedures et al, enable VMs GetSource 52b2a869bc Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9163 Update testing scripts to run on a Dart 2 VM 8638668ecf [VM] Fix vm->native state transition in isolate_reload.cc 71ac67aed1 [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8dfe85 Stop using !kernel annotations 3e85df5167 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575a54 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcca7f Roll pub to the latest version. abc8793109 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb154e9 [vmservice] Report expression compilation errors b28ebca825 Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2305 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848fe0f Convert ShadowWhileStatement to WhileJudgment. 5ccc497678 Inline constructor bodies that are called once 4df14626b3 Add parameters to Factory methods for constructor initializers dce00bc836 - fix a strong mode type error - mark a test as slow 83a4d98554 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee90f [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1fad8 Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f578c Convert ShadowTryCatch to TryCatchJudgment. 6182b7215d [vm/kernel/bytecode] Fix passing of type arguments b343d0a80d trigger error for const A(B()) if B non-const 06a588233c Fix package_root_test.dart on mac buildbot. 8419090c8c Cleanup type variable event sequence 8da640704a [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe657 Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c141f [vm] Shorten the write barrier sequence. b6aa31f7d8 Add required parameters to Factory.catchStatement 34bbb1da30 [Gardening] Move status line to the correct section. 68ecf31fc5 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1cd7 Add parameters to Factory API, part 2 85c27d78c1 [Gardening] Removed incorrect entry in the status file. 2edbfd95a7 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b130 Added super_no_such_method5_test also to the issue list for 33517 254d8ef153 Switch ShadowYieldStatement to YieldJudgment. 64fd6653cf Update deprecated references. 13fb4da312 Convert ShadowIfStatement to IfJudgment. 71042d3dfa linter 0.1.54 e9f994892d Cleanup unescape error messages 7b68a4516f Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9dca5 Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85c76 Re-enable the old analyzer/FE integration logic. 9bd3350f1f Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353fe29 Convert ShadowReturnStatement to ReturnJudgment. 462d2a35d3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8bbd5 [VM][kernel] Don't mix in noSuchMethod forwarders 6612278b71 Skip non-utf8 file tests on reload builders, where they time out 125fae6d56 Incorporate comments from an earlier code review 188c858a4c [gardening] Fix standalone/app_snapshot_share_test 1c4b362ba5 Support noSuchMethod forwarders in dart2js 276598199e Make DDK interpret IntLiteral.value as uint64 a049e340eb Revert the fix for issue #31770 d4a69bde98 app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d6d9 [dart2js] Fix for issue 33500 828df76c85 Notify kernel service of isolate shutdown. a36fbd1990 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d33d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d35f5 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983e0a Convert ShadowStaticGet to StaticGetJudgment acd375cc77 [gardening] Silence flaky test which times out on simarm64 bot 3becdb8afd Convert property gets to judgments. 9db4b71442 Convert ShadowIntLiteral to IntJudgment 37084e677c Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8e42 Convert ShadowNullLiteral to NullJudgment. 3a2a84db9c Improve misplaced factory/modifier recovery 3586fcb165 Cleanup deprecated code eac395c33d Add parameters needed by analyzer to Factory, part 1 edcd3be290 Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683a88 Convert ShadowDoStatement to DoJudgment. 8e8fb38c48 Convert ShadowBlock to BlockJudgment. b71fb2e086 Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f23243b Enable Dart2 in dart2js by default 6b96e65c5b Convert ShadowArguments to ArgumentsJudgment. 437b492042 [gardening] Update status for reload-kernel bots a3a1113cfd Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871ae88 Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6a49 Add a Type parameter to Factory and update one method 119236996a [build] Remove tools/compile_platform.py ddde9820a9 Improve fasta parser parameter list recovery f5a0e3efa8 Create NamedExpressionJudgment. 165c57ffd7 Attempt to fix the windows bot 3 bb1fcebd36 [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d54c6 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d39504f Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49134 Support asset directories in flutter pubspec validation. 015d9eff49 Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff9361f Track which import is referenced by each prefix. 92c24a1ee7 Skip sample_extension_app_snapshot_test on opt-counter-threshold builders 33d41a928a [VM] Fix incorrect memory allocation f3960a0111 Fix language_2/vm/optimized_guarded_field_isolates_test e496efb611 [VM] Adjust status file after 6db5f38d4ee4d ef49436487 [fasta] Update expectation files after noSuchMethod forwarders change 049195b15d Fix path to entry points json file in app_snapshot_share_test b024432a29 [VM] Disable test in reload/rollback mode due to snapshot generation 6db5f38d4e [fasta] Don't generate noSuchMethod forwarders in abstract classes 7979232580 Re-added header, only needed to remove the other resource section. a38b9bed23 Restore dart2js-checked and dart-aot in try_benchmarks.sh. 7be47cd30d Remove some dead code (including implicit setters) 1c01aa7704 Convert some ShadowExpressions into inference judgments 6e6bdb486a Ensure we run app_snapshot_share_test d7e5332057 Make dual use of a part in the same program an error. 856c7c67ea Skip standalone_2 on !strong configurations (for JIT / AOT VM) ba024be044 Mark dart2js specific argument as deprecated. 20fe2f0ada Indent error pointer correctly in the presence of tabs. bd94de8e48 Use dynamic to fix string_interpolate_test b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator f288124d5a Fix InvalidInlineFunctionType example 15821a28a3 Explicit type args in body_builder 1f6925718b Add message for missing type arguments 87e045c484 Remove the helper dart script from our browser test framework 532b9aaa93 Flatten *WorldBuilder hierarchies. f1d44e39fa Update status for passing Windows Firefox co19 tests efb4f69a13 Adjust simarm status. 1a443da6ad Adjust options passed to precompile runtime. f8caffd9e6 Remove some uses of Platform.packageRoot. ebe2f1db2c Adjust status files. 6fcc95d2a4 Adjust status files. f2f6ebf547 Convert ShadowAssertInitializer to AssertInitializerJudgment. ea837c91a0 Transition tests to EvaluateCompiledExpression. 3e6e2dd7f4 Convert ShadowAssertStatement to AssertStatementJudgment. 27fefd7bb3 Convert ShadowAwaitExpression to AwaitExpressionJudgment. dd1c54c442 Convert ShadowBoolLiteral to BoolLiteralJudgement 4a353fea35 Another attempt to fix tests on Windows a69d922794 Adjust some of the test expectations based on the flip to Dart 2 mode. b3b8ca6dc4 Remove the --package-default-analysis-options flag. 9943547d5d Default pub to Dart 2 with opt out aba94f051e Convert ShadowAsExpression to AsJudgment. bc7220a4fd [VM] Turn dart2 on by default on the command line VM cdd2553a12 [vm/kernel/bytecode] Fix null handling in operator == df2bf6590d [VM runtime] Minor cleanup of stubs on all architectures as already done for x64 b140baeb55 Own files by their URIs during search. 56cee22800 Build out the initial version of the Factory class (and derived classes). 83cb0c425d Fix awaiting void in analyzer ast_test.dart. Fix at method decl. c9af309cbf Fix fasta parsing of ?. in cascade expression 67695b9842 Fix the dependencies on the dartdevk_sdk build step. 0a59b2ff90 Fix test cases that await "void." Blocks #33415, making that an error 3ba3e2a752 Revert "switch to dart_action until prebuilt Windows Dart VM is updated" 741ed336f1 Improve AstBuilder int literal recovery e77158eb38 First steps toward generating analyzer/kernel ASTs during type inference. f1c3f997bd [VM] Clear out return-value-register from call-to-runtime-stub, it needs to be GC-safe for lazy deopts 686fd133a7 [VM interpreter] Propagate unhandled exception returned from jitted code to interpreter. 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 7d94755836 Issue 33471. Use full ResolveResult in Extract Local refactoring. 57c0fc9593 [vm/corelib] More cleanup in integer operations after _Bigint is removed 88d12fda42 Parse throw on RHS of an assignment 1dcc3264e7 Fix tests that are failing on Windows 691313f357 Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin. e62f563b2d Validate sdkPath in AnalysisContextCollectionImpl. 493c421f0d Add AnalysisContextCollection. ``` * Roll dart sdk to 4552beb514c5b54fbe9c5a0791f7b95253ac09b9. Changes since last roll: ``` 4552beb514 Revert "[vm/kernel-service] Report an error if isolate compilation options change." f304948807 [vm] Refactoring: extract kernel translation helpers to a separate file 5a47f4c9fa Apply resolution for ParameterElement metadata. db7b5072af Reenable FutureOr resynthesis tests with kernel. 1f8148f862 [infra] Restore sync-async behavior to fix legacy precompiler bots d9911b8a8a Add language_2 test status entries for -cdart2analyzer --use-cfe b0b1020588 [fasta] Add more tests for noSuchMethod forwarders 90e27b19ea Check for conflicts between a static setter and a constructor or static method. b0cbc4e9cd Fix a bug in top-level type inference dependency tracking 29924c4000 In observatory use ArgumentError instead of FallThroughError bd9aa5139a Error on cyclic constructor redirect. 1a6c857a93 Remove ExpressionGenerator.buildThrowNoSuchMethodError c53746fc8a Add lexeme2 template key 2f739fd7d9 Default implementation of _makeRead and _makeWrite 36b22c7ae9 Remove unused files 583a81ade3 [infra] Make test.py's --strong option a no-op to prepare for removing it 17b53a2835 Test out no_implicit_casts on the analyzer source base. 2ee635977d Revert separation of getOutline() and getResolution() in FrontEndCompiler. fc472e03da Don't store resolution for desugaring generated NotJudgment. e0845f9359 [vm/kernel-service] Report an error if isolate compilation options change. cc30bda2be In resynthesis tests, do not attempt to distinguish missing bound from Object. a1bd1dd6ee Use standard I/O posix functions for Fuchsia, not 64 bit variants 6f284b45f7 Fixes for applying resolution to InstanceCreationExpression. 1eacd27b8e [VM runtime] Type bounds do not need to be checked during type finalization in strong mode, since bound checks are explicitly emitted where needed. 5db9e6c95e [VM interpreter] Do not load bytecode of synthesized functions with copied metadata. Fix return of native call to bytecode function. Fix stack level when returning from static field initializer. Use a zone handle for handled exception types. bcacff49ba Ignore deferredCheck() in resolution storer. 423edf86be Fix analyzer/FE integration of local generic functions with bounds. 0e7e0c945a [vm/kernel/bytecode] Generate argument checks after allocating initial context 3fd61646ce Fix analyzer/FE integration of redirected constructors involving type arguments. d03210cdf4 Fix storage of types for local functions that are generic. 4426f5a33e [gardening] Mark large_class_declaration_test Slow in debug, dart1 85253708a3 [build] Include kernel-service snapshot in the platform sdk f0bc620143 Validate location in store(). b4a426fa72 [dart:io] Adds HttpClient.connectionTimeout cb4a19b5fc misc(pkg/analyzer): update to latest pkg:matcher API d2bde00d9d Cleanup skipFormalParameters and remove unused methods 56cb7bac02 Fix for applying resolution to static field annotations. 723bcbd5f9 Added link to see webdev.dartlang.org b9dbe3a0be Fix analyzer/FE integration for `is!` expressions. bef0eca2e3 [gardening] Update status after a7f0f7ea899fe7812f54eea8f957a92153e3176e f5e8cc3517 Remove old code with incorrect instantiation to bounds on typedefs edf26852e6 linter 0.1.55 544358304d [VM] - Add --preview-dart-2 option back as a nop - Temporarily treat --checked as an alias for --enable-asserts in Dart2 mode so that google3 test scripts don't need to change. e7da604c11 More updates for -DuseFastaParser. efa4b21c4f [fuchsia] Update zx_cprng_draw a7f0f7ea89 [vm] Add source positions to stack traces of bool checks 70087c349b Fixes for applying resolution to annotations. 21b077a81c Fix incorrect handling of non-generic typedefs. 37d9e79b1b Update co19 and co19 strong branch in DEPS 7d1642e081 [gardening] Mark large_class_declaration_test Slow. dce6663028 Add message to assert to explain the problem b20dc7b98a Update the script to re-gen the analysis server spec. 29c549bfe2 [vm/kernel] Use old space in a specific Kernel FE error allocation. e13b9e8a75 [fasta] Update expectation files after cf2966ea 46167dfd88 It is OK to declare a const constructor in a class with a mixin, if it has no fields. 88a88b03dc Fix token used for large negative integers. b43dc893eb Remove spec references to Symbol constructor. cf2966ea0d [fasta] Generate noSuchMethod forwarders for abstract accessors 28ed0d743d Make it explicit that "dynamic" is exported from dart:core. ce312b9632 Add --analyzer-use-fasta and --analyzer-use-fasta-parser to test.py 25286e4a7d Add tests for optimization of Flutters use of Widget.runtimeType df2529d443 Detect when a class has a member that conflicts with a static one 50fe42a886 Reduce use of putIfAbsent 385cde3977 Resolve 'dynamic' element references. 70576f431e Roll https://github.com/dart-lang/pub/pull/1938 into the SDK. 46710a77dd Make checked flag again only enable assertions in Dart 2.0 e0905b979a Revert "Add ClassHierarchy to share code between J/KClosedWorld" 9179db84df Resynthesize typedef types properly from kernel. c53952a46d [vm/kernel/bytecode] Generate bytecode for assertions, bool checks a6c2c97d7e Rename ResynthesizeKernelStrongTest to ResynthesizeTest_Kernel cad8d4a741 Store instance creation information at arguments offset. a4c7cf388f First stab at a parsing library for named configurations. 008aa729c5 [VM interpreter] Support implicit getters and setters without compiling them. 54bc1548b0 [fuchsia] Update to Sync2Ptr 05b19947a4 Prep for analyzer 0.32.2 a1efbd326f Change FrontEndCompiler.getOutline() to return full kernels. 966541bec9 Improve literal function recovery 386efb1e6a Improve type parameter recovery 5c9add2c46 Allow Future<T> to be assigned to Future<void> 9c7cd04e7f [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6661 [gardening] Update status file 5a193752f6 Clean up some hints e67c5953e9 Relax return restrictions. a9c624a010 [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f37a9 Update dart_style package to 1.1.0 in DEPS f67308a983 Handle invalid dill files more gracefully 9aa0c4ae3f [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3bc2 Update app_jitk service status a16ad6d9de [infra] Make update_homebrew script work on Dart2 014a5bc678 Replace strstr with strncmp looking for path separator d2d47acdce [kernel] Include urls even when we have no source 5f17b0a0be Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3c1d Add tests showing the async impact on function type checks 8e4d5c0a38 Update formated error for nonexisting constructor a8e930caf3 Add ClassHierarchy to share code between J/KClosedWorld c9bd4df214 Document IntLiteral.value as holding a uint64 value 56d57407e1 Fix status for new test ed20faa2ed Add test for rejecting inexact numbers 31ed467871 Fix directory-prefix finding logic so it works on Windows. 2d6eaba187 pkg:build_integration: clarify that' it's not planned to be published f67cba1067 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd08fb Doc - Fix OSError.message and errorCode doc c97f177112 Issue 33518. Fix for subtypes() in parts without library. e661c9ef54 Simplify 'as T' for simple T 65a3c4443b [observatory] Update packages and remove dead dependencies. b15572933d Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533ff72 snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6232 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623654 Check function types in the correct order in runZoned. 6d25212302 getStats Future should be strongly typed. ca99917fb6 Remove code awaiting void results to unblock #33145 19f60bfb52 Improve fasta parser expression recovery d632980ee0 Add tokens to more judgements 5721d8af6d - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037164 Fix second half on #33343: disallow generic functions as type arguments. 97c81d668a Remove variableSet factory methods. 98efc7917f Improve parse assert statement recovery a93e303f3f [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81bfe7 Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6cae Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560fc6 Count analyzer cfe integration failing tests. 77f94ec259 Convert ShadowLogicalExpression to LogicalJudgment 1a0fc733d3 Add tokens to more judgements 81191186d8 Remove unused class 284b5cce55 Partial fix of #33343. Reject generic function types as bounds. ada8188b73 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd28c [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbdac5c Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e182 [fasta] Update .expect files for non-simple bound tests aeff1c00f2 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a55c1 Change infer to return the expression instead of its type b9f11311f8 [vm/compiler] Fix incorrect assertion from 20ca5bbb056. f85fbde727 Expression compilation fix 6240dd5cc3 Make incremental_load_from_dill_test dart2 compliant 8747da838f Bump kernel version after e2ce88d 20ca5bbb05 [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec380 [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817322 Check whether variables is set before using GN not_needed f381778867 Update the status of analysis server tests. 8b10b1fda9 Add tokens to judgements, part 2 8c1591af9e Add a binder mechanism to the Factory API for handling labels. e132240c91 Re-enable some failing analyzer_cli --use-cfe tests. f598e6933c Drop support for Dart 1 in pub 9146cea63a Print times in seconds ec0df457a2 Convert invocation Shadow(s) to Judgment(s). 223b143167 Workaround for issue 33559. 091f8860c2 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27acd Add unittest for InferenceData 70ac1f90ec Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576dd4 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82ef9a [dart2js] Fix for issue 33572 1416ed283a Convert ShadowNot to NotJudgment. a1a2d90a6c Convert ShadowForStatement to ForJudgment. 7c6211b1d8 Make unittests work with Dart 2 a8d805055a Handle covariant parameters in function types b24170259c Don't add parts without 'part of' as libraries. fea8cb1473 Revise order of type variable declaration events 6339976567 Rename lemma to binder 9d499fffe4 Start adding tokens to judgements ff7a1255aa Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70ec5b Docs - Update example websockets app; use idiomatic async/await in examples ed0ba901e1 Doc - Fix library links in analyzer docs 4c697085be dart2js: Make bazel-input-provider dart2 compliant. 9b814bdf34 Use the lemma approach for NamedFunctionExpression 7c0d31092d Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353f76 Update dartdoc to 0.20.1. eafa9ae4b6 [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708eada [VM interpreter] Fix broken interpreter build. 94abf948c4 pkg:status_file misc cleanup 02721709c3 Fix a committed solo test and mark it as passing now. c8a488c1ca Add parameters to Forest method to support labeled statements c4d6ac0cbe [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363cba0 Rename typeContext to inferredType 10dcad1dd2 pkg:kernel - cleanup pubspec file 7e7fd7ffa5 Convert ShadowLiteralList into LiteralListJudgment 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2840 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9af5 Fix cascade specification. d08317b79f Make status file linter valid Dart 2 code f4d2bf313e Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2824 Compile time error for web int literals that cannot be represented exactly 075c713a93 Register type arguments on inlining 4ebdb31646 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90c42 Convert ShadowRethrow to RethrowJudgment 7661841cc5 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd40725af Convert ShadowIfNullExpression to IfNullJudgment 7c327c32b7 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c8f3 [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0ff07 Convert ShadowStringConcatenation to StringConcatenationJudgment d0655066a5 Use the lemma approach for other variable declaring constructs. 2121c3bb56 Docs - Link to the Random.secure constructor in dartdoc 975686d5a9 [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c268e [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38dec5 [vm, standalone] Do not copy when loading kernel. 8d7c5294c6 Rename the kernel ShadowExpressions for assignments 47f394d61c Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4cdf Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af84e7 DEPS: update crypto version 530f1f6512 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc3352e0 Replace and remove parseType 1b681a75c3 Modify Factory API to allow forward references to incomplete local functions and variables. f682213764 Add parameters to Factory methods to support the try statement cf6fbd9e07 Add parameters to Factory methods to support the switch statement b50ff4990a Add parameters to Factory methods for list and map literals c5855635ae Add Factory method parameters for for loops c2a22c6462 Updates to ddc/ddb tool 1a1ff9e666 Reverse the pub snapshot names d5d5daf411 Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c636 Fix docs for async File methods 569341cbe0 Improve CompressionOptions docs: 8d40afc9c0 Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfcacb Convert ShadowForInStatement to ForInJudgment. f2eaf6aae7 Remove type parameters from the Fasta BodyBuilder 74dd5440f1 Convert ShadowStringLiteral into StringLiteralJudgment 10641cbf42 Update status files after 52b2a869bcb93 ee19f2804a Make ResolutionStorer implement the Factory API. e2ce88dfcc Add startFileOffset on procedures et al, enable VMs GetSource 52b2a869bc Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9163 Update testing scripts to run on a Dart 2 VM 8638668ecf [VM] Fix vm->native state transition in isolate_reload.cc 71ac67aed1 [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8dfe85 Stop using !kernel annotations 3e85df5167 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575a54 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcca7f Roll pub to the latest version. abc8793109 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb154e9 [vmservice] Report expression compilation errors b28ebca825 Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2305 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848fe0f Convert ShadowWhileStatement to WhileJudgment. 5ccc497678 Inline constructor bodies that are called once 4df14626b3 Add parameters to Factory methods for constructor initializers dce00bc836 - fix a strong mode type error - mark a test as slow 83a4d98554 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee90f [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1fad8 Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f578c Convert ShadowTryCatch to TryCatchJudgment. 6182b7215d [vm/kernel/bytecode] Fix passing of type arguments b343d0a80d trigger error for const A(B()) if B non-const 06a588233c Fix package_root_test.dart on mac buildbot. 8419090c8c Cleanup type variable event sequence 8da640704a [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe657 Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c141f [vm] Shorten the write barrier sequence. b6aa31f7d8 Add required parameters to Factory.catchStatement 34bbb1da30 [Gardening] Move status line to the correct section. 68ecf31fc5 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1cd7 Add parameters to Factory API, part 2 85c27d78c1 [Gardening] Removed incorrect entry in the status file. 2edbfd95a7 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b130 Added super_no_such_method5_test also to the issue list for 33517 254d8ef153 Switch ShadowYieldStatement to YieldJudgment. 64fd6653cf Update deprecated references. 13fb4da312 Convert ShadowIfStatement to IfJudgment. 71042d3dfa linter 0.1.54 e9f994892d Cleanup unescape error messages 7b68a4516f Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9dca5 Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85c76 Re-enable the old analyzer/FE integration logic. 9bd3350f1f Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353fe29 Convert ShadowReturnStatement to ReturnJudgment. 462d2a35d3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8bbd5 [VM][kernel] Don't mix in noSuchMethod forwarders 6612278b71 Skip non-utf8 file tests on reload builders, where they time out 125fae6d56 Incorporate comments from an earlier code review 188c858a4c [gardening] Fix standalone/app_snapshot_share_test 1c4b362ba5 Support noSuchMethod forwarders in dart2js 276598199e Make DDK interpret IntLiteral.value as uint64 a049e340eb Revert the fix for issue #31770 d4a69bde98 app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d6d9 [dart2js] Fix for issue 33500 828df76c85 Notify kernel service of isolate shutdown. a36fbd1990 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d33d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d35f5 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983e0a Convert ShadowStaticGet to StaticGetJudgment acd375cc77 [gardening] Silence flaky test which times out on simarm64 bot 3becdb8afd Convert property gets to judgments. 9db4b71442 Convert ShadowIntLiteral to IntJudgment 37084e677c Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8e42 Convert ShadowNullLiteral to NullJudgment. 3a2a84db9c Improve misplaced factory/modifier recovery 3586fcb165 Cleanup deprecated code eac395c33d Add parameters needed by analyzer to Factory, part 1 edcd3be290 Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683a88 Convert ShadowDoStatement to DoJudgment. 8e8fb38c48 Convert ShadowBlock to BlockJudgment. b71fb2e086 Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f23243b Enable Dart2 in dart2js by default 6b96e65c5b Convert ShadowArguments to ArgumentsJudgment. 437b492042 [gardening] Update status for reload-kernel bots a3a1113cfd Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871ae88 Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6a49 Add a Type parameter to Factory and update one method 119236996a [build] Remove tools/compile_platform.py ddde9820a9 Improve fasta parser parameter list recovery f5a0e3efa8 Create NamedExpressionJudgment. 165c57ffd7 Attempt to fix the windows bot 3 bb1fcebd36 [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d54c6 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d39504f Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49134 Support asset directories in flutter pubspec validation. 015d9eff49 Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff9361f Track …
bkonyi
pushed a commit
to flutter/engine
that referenced
this pull request
Jul 13, 2018
* Roll dart sdk to 9c7cd04e7f285c3e74f54def9f91dbdd1a18b1ba. Changes since last roll: ``` 9c7cd04e7f [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6661 [gardening] Update status file 5a193752f6 Clean up some hints e67c5953e9 Relax return restrictions. a9c624a010 [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f37a9 Update dart_style package to 1.1.0 in DEPS f67308a983 Handle invalid dill files more gracefully 9aa0c4ae3f [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3bc2 Update app_jitk service status a16ad6d9de [infra] Make update_homebrew script work on Dart2 014a5bc678 Replace strstr with strncmp looking for path separator d2d47acdce [kernel] Include urls even when we have no source 5f17b0a0be Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3c1d Add tests showing the async impact on function type checks 8e4d5c0a38 Update formated error for nonexisting constructor a8e930caf3 Add ClassHierarchy to share code between J/KClosedWorld c9bd4df214 Document IntLiteral.value as holding a uint64 value 56d57407e1 Fix status for new test ed20faa2ed Add test for rejecting inexact numbers 31ed467871 Fix directory-prefix finding logic so it works on Windows. 2d6eaba187 pkg:build_integration: clarify that' it's not planned to be published f67cba1067 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd08fb Doc - Fix OSError.message and errorCode doc c97f177112 Issue 33518. Fix for subtypes() in parts without library. e661c9ef54 Simplify 'as T' for simple T 65a3c4443b [observatory] Update packages and remove dead dependencies. b15572933d Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533ff72 snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6232 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623654 Check function types in the correct order in runZoned. 6d25212302 getStats Future should be strongly typed. ca99917fb6 Remove code awaiting void results to unblock #33145 19f60bfb52 Improve fasta parser expression recovery d632980ee0 Add tokens to more judgements 5721d8af6d - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037164 Fix second half on #33343: disallow generic functions as type arguments. 97c81d668a Remove variableSet factory methods. 98efc7917f Improve parse assert statement recovery a93e303f3f [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81bfe7 Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6cae Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560fc6 Count analyzer cfe integration failing tests. 77f94ec259 Convert ShadowLogicalExpression to LogicalJudgment 1a0fc733d3 Add tokens to more judgements 81191186d8 Remove unused class 284b5cce55 Partial fix of #33343. Reject generic function types as bounds. ada8188b73 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd28c [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbdac5c Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e182 [fasta] Update .expect files for non-simple bound tests aeff1c00f2 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a55c1 Change infer to return the expression instead of its type b9f11311f8 [vm/compiler] Fix incorrect assertion from 20ca5bbb056. f85fbde727 Expression compilation fix 6240dd5cc3 Make incremental_load_from_dill_test dart2 compliant 8747da838f Bump kernel version after e2ce88d 20ca5bbb05 [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec380 [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817322 Check whether variables is set before using GN not_needed f381778867 Update the status of analysis server tests. 8b10b1fda9 Add tokens to judgements, part 2 8c1591af9e Add a binder mechanism to the Factory API for handling labels. e132240c91 Re-enable some failing analyzer_cli --use-cfe tests. f598e6933c Drop support for Dart 1 in pub 9146cea63a Print times in seconds ec0df457a2 Convert invocation Shadow(s) to Judgment(s). 223b143167 Workaround for issue 33559. 091f8860c2 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27acd Add unittest for InferenceData 70ac1f90ec Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576dd4 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82ef9a [dart2js] Fix for issue 33572 1416ed283a Convert ShadowNot to NotJudgment. a1a2d90a6c Convert ShadowForStatement to ForJudgment. 7c6211b1d8 Make unittests work with Dart 2 a8d805055a Handle covariant parameters in function types b24170259c Don't add parts without 'part of' as libraries. fea8cb1473 Revise order of type variable declaration events 6339976567 Rename lemma to binder 9d499fffe4 Start adding tokens to judgements ff7a1255aa Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70ec5b Docs - Update example websockets app; use idiomatic async/await in examples ed0ba901e1 Doc - Fix library links in analyzer docs 4c697085be dart2js: Make bazel-input-provider dart2 compliant. 9b814bdf34 Use the lemma approach for NamedFunctionExpression 7c0d31092d Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353f76 Update dartdoc to 0.20.1. eafa9ae4b6 [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708eada [VM interpreter] Fix broken interpreter build. 94abf948c4 pkg:status_file misc cleanup 02721709c3 Fix a committed solo test and mark it as passing now. c8a488c1ca Add parameters to Forest method to support labeled statements c4d6ac0cbe [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363cba0 Rename typeContext to inferredType 10dcad1dd2 pkg:kernel - cleanup pubspec file 7e7fd7ffa5 Convert ShadowLiteralList into LiteralListJudgment 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2840 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9af5 Fix cascade specification. d08317b79f Make status file linter valid Dart 2 code f4d2bf313e Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2824 Compile time error for web int literals that cannot be represented exactly 075c713a93 Register type arguments on inlining 4ebdb31646 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90c42 Convert ShadowRethrow to RethrowJudgment 7661841cc5 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd40725af Convert ShadowIfNullExpression to IfNullJudgment 7c327c32b7 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c8f3 [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0ff07 Convert ShadowStringConcatenation to StringConcatenationJudgment d0655066a5 Use the lemma approach for other variable declaring constructs. 2121c3bb56 Docs - Link to the Random.secure constructor in dartdoc 975686d5a9 [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c268e [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38dec5 [vm, standalone] Do not copy when loading kernel. 8d7c5294c6 Rename the kernel ShadowExpressions for assignments 47f394d61c Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4cdf Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af84e7 DEPS: update crypto version 530f1f6512 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc3352e0 Replace and remove parseType 1b681a75c3 Modify Factory API to allow forward references to incomplete local functions and variables. f682213764 Add parameters to Factory methods to support the try statement cf6fbd9e07 Add parameters to Factory methods to support the switch statement b50ff4990a Add parameters to Factory methods for list and map literals c5855635ae Add Factory method parameters for for loops c2a22c6462 Updates to ddc/ddb tool 1a1ff9e666 Reverse the pub snapshot names d5d5daf411 Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c636 Fix docs for async File methods 569341cbe0 Improve CompressionOptions docs: 8d40afc9c0 Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfcacb Convert ShadowForInStatement to ForInJudgment. f2eaf6aae7 Remove type parameters from the Fasta BodyBuilder 74dd5440f1 Convert ShadowStringLiteral into StringLiteralJudgment 10641cbf42 Update status files after 52b2a869bcb93 ee19f2804a Make ResolutionStorer implement the Factory API. e2ce88dfcc Add startFileOffset on procedures et al, enable VMs GetSource 52b2a869bc Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9163 Update testing scripts to run on a Dart 2 VM 8638668ecf [VM] Fix vm->native state transition in isolate_reload.cc 71ac67aed1 [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8dfe85 Stop using !kernel annotations 3e85df5167 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575a54 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcca7f Roll pub to the latest version. abc8793109 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb154e9 [vmservice] Report expression compilation errors b28ebca825 Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2305 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848fe0f Convert ShadowWhileStatement to WhileJudgment. 5ccc497678 Inline constructor bodies that are called once 4df14626b3 Add parameters to Factory methods for constructor initializers dce00bc836 - fix a strong mode type error - mark a test as slow 83a4d98554 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee90f [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1fad8 Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f578c Convert ShadowTryCatch to TryCatchJudgment. 6182b7215d [vm/kernel/bytecode] Fix passing of type arguments b343d0a80d trigger error for const A(B()) if B non-const 06a588233c Fix package_root_test.dart on mac buildbot. 8419090c8c Cleanup type variable event sequence 8da640704a [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe657 Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c141f [vm] Shorten the write barrier sequence. b6aa31f7d8 Add required parameters to Factory.catchStatement 34bbb1da30 [Gardening] Move status line to the correct section. 68ecf31fc5 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1cd7 Add parameters to Factory API, part 2 85c27d78c1 [Gardening] Removed incorrect entry in the status file. 2edbfd95a7 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b130 Added super_no_such_method5_test also to the issue list for 33517 254d8ef153 Switch ShadowYieldStatement to YieldJudgment. 64fd6653cf Update deprecated references. 13fb4da312 Convert ShadowIfStatement to IfJudgment. 71042d3dfa linter 0.1.54 e9f994892d Cleanup unescape error messages 7b68a4516f Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9dca5 Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85c76 Re-enable the old analyzer/FE integration logic. 9bd3350f1f Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353fe29 Convert ShadowReturnStatement to ReturnJudgment. 462d2a35d3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8bbd5 [VM][kernel] Don't mix in noSuchMethod forwarders 6612278b71 Skip non-utf8 file tests on reload builders, where they time out 125fae6d56 Incorporate comments from an earlier code review 188c858a4c [gardening] Fix standalone/app_snapshot_share_test 1c4b362ba5 Support noSuchMethod forwarders in dart2js 276598199e Make DDK interpret IntLiteral.value as uint64 a049e340eb Revert the fix for issue #31770 d4a69bde98 app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d6d9 [dart2js] Fix for issue 33500 828df76c85 Notify kernel service of isolate shutdown. a36fbd1990 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d33d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d35f5 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983e0a Convert ShadowStaticGet to StaticGetJudgment acd375cc77 [gardening] Silence flaky test which times out on simarm64 bot 3becdb8afd Convert property gets to judgments. 9db4b71442 Convert ShadowIntLiteral to IntJudgment 37084e677c Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8e42 Convert ShadowNullLiteral to NullJudgment. 3a2a84db9c Improve misplaced factory/modifier recovery 3586fcb165 Cleanup deprecated code eac395c33d Add parameters needed by analyzer to Factory, part 1 edcd3be290 Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683a88 Convert ShadowDoStatement to DoJudgment. 8e8fb38c48 Convert ShadowBlock to BlockJudgment. b71fb2e086 Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f23243b Enable Dart2 in dart2js by default 6b96e65c5b Convert ShadowArguments to ArgumentsJudgment. 437b492042 [gardening] Update status for reload-kernel bots a3a1113cfd Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871ae88 Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6a49 Add a Type parameter to Factory and update one method 119236996a [build] Remove tools/compile_platform.py ddde9820a9 Improve fasta parser parameter list recovery f5a0e3efa8 Create NamedExpressionJudgment. 165c57ffd7 Attempt to fix the windows bot 3 bb1fcebd36 [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d54c6 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d39504f Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49134 Support asset directories in flutter pubspec validation. 015d9eff49 Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff9361f Track which import is referenced by each prefix. 92c24a1ee7 Skip sample_extension_app_snapshot_test on opt-counter-threshold builders 33d41a928a [VM] Fix incorrect memory allocation f3960a0111 Fix language_2/vm/optimized_guarded_field_isolates_test e496efb611 [VM] Adjust status file after 6db5f38d4ee4d ef49436487 [fasta] Update expectation files after noSuchMethod forwarders change 049195b15d Fix path to entry points json file in app_snapshot_share_test b024432a29 [VM] Disable test in reload/rollback mode due to snapshot generation 6db5f38d4e [fasta] Don't generate noSuchMethod forwarders in abstract classes 7979232580 Re-added header, only needed to remove the other resource section. a38b9bed23 Restore dart2js-checked and dart-aot in try_benchmarks.sh. 7be47cd30d Remove some dead code (including implicit setters) 1c01aa7704 Convert some ShadowExpressions into inference judgments 6e6bdb486a Ensure we run app_snapshot_share_test d7e5332057 Make dual use of a part in the same program an error. 856c7c67ea Skip standalone_2 on !strong configurations (for JIT / AOT VM) ba024be044 Mark dart2js specific argument as deprecated. 20fe2f0ada Indent error pointer correctly in the presence of tabs. bd94de8e48 Use dynamic to fix string_interpolate_test b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator f288124d5a Fix InvalidInlineFunctionType example 15821a28a3 Explicit type args in body_builder 1f6925718b Add message for missing type arguments 87e045c484 Remove the helper dart script from our browser test framework 532b9aaa93 Flatten *WorldBuilder hierarchies. f1d44e39fa Update status for passing Windows Firefox co19 tests efb4f69a13 Adjust simarm status. 1a443da6ad Adjust options passed to precompile runtime. f8caffd9e6 Remove some uses of Platform.packageRoot. ebe2f1db2c Adjust status files. 6fcc95d2a4 Adjust status files. f2f6ebf547 Convert ShadowAssertInitializer to AssertInitializerJudgment. ea837c91a0 Transition tests to EvaluateCompiledExpression. 3e6e2dd7f4 Convert ShadowAssertStatement to AssertStatementJudgment. 27fefd7bb3 Convert ShadowAwaitExpression to AwaitExpressionJudgment. dd1c54c442 Convert ShadowBoolLiteral to BoolLiteralJudgement 4a353fea35 Another attempt to fix tests on Windows a69d922794 Adjust some of the test expectations based on the flip to Dart 2 mode. b3b8ca6dc4 Remove the --package-default-analysis-options flag. 9943547d5d Default pub to Dart 2 with opt out aba94f051e Convert ShadowAsExpression to AsJudgment. bc7220a4fd [VM] Turn dart2 on by default on the command line VM cdd2553a12 [vm/kernel/bytecode] Fix null handling in operator == df2bf6590d [VM runtime] Minor cleanup of stubs on all architectures as already done for x64 b140baeb55 Own files by their URIs during search. 56cee22800 Build out the initial version of the Factory class (and derived classes). 83cb0c425d Fix awaiting void in analyzer ast_test.dart. Fix at method decl. c9af309cbf Fix fasta parsing of ?. in cascade expression 67695b9842 Fix the dependencies on the dartdevk_sdk build step. 0a59b2ff90 Fix test cases that await "void." Blocks #33415, making that an error 3ba3e2a752 Revert "switch to dart_action until prebuilt Windows Dart VM is updated" 741ed336f1 Improve AstBuilder int literal recovery e77158eb38 First steps toward generating analyzer/kernel ASTs during type inference. f1c3f997bd [VM] Clear out return-value-register from call-to-runtime-stub, it needs to be GC-safe for lazy deopts 686fd133a7 [VM interpreter] Propagate unhandled exception returned from jitted code to interpreter. 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 7d94755836 Issue 33471. Use full ResolveResult in Extract Local refactoring. 57c0fc9593 [vm/corelib] More cleanup in integer operations after _Bigint is removed 88d12fda42 Parse throw on RHS of an assignment 1dcc3264e7 Fix tests that are failing on Windows 691313f357 Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin. e62f563b2d Validate sdkPath in AnalysisContextCollectionImpl. 493c421f0d Add AnalysisContextCollection. ``` * Roll dart sdk to 4552beb514c5b54fbe9c5a0791f7b95253ac09b9. Changes since last roll: ``` 4552beb514 Revert "[vm/kernel-service] Report an error if isolate compilation options change." f304948807 [vm] Refactoring: extract kernel translation helpers to a separate file 5a47f4c9fa Apply resolution for ParameterElement metadata. db7b5072af Reenable FutureOr resynthesis tests with kernel. 1f8148f862 [infra] Restore sync-async behavior to fix legacy precompiler bots d9911b8a8a Add language_2 test status entries for -cdart2analyzer --use-cfe b0b1020588 [fasta] Add more tests for noSuchMethod forwarders 90e27b19ea Check for conflicts between a static setter and a constructor or static method. b0cbc4e9cd Fix a bug in top-level type inference dependency tracking 29924c4000 In observatory use ArgumentError instead of FallThroughError bd9aa5139a Error on cyclic constructor redirect. 1a6c857a93 Remove ExpressionGenerator.buildThrowNoSuchMethodError c53746fc8a Add lexeme2 template key 2f739fd7d9 Default implementation of _makeRead and _makeWrite 36b22c7ae9 Remove unused files 583a81ade3 [infra] Make test.py's --strong option a no-op to prepare for removing it 17b53a2835 Test out no_implicit_casts on the analyzer source base. 2ee635977d Revert separation of getOutline() and getResolution() in FrontEndCompiler. fc472e03da Don't store resolution for desugaring generated NotJudgment. e0845f9359 [vm/kernel-service] Report an error if isolate compilation options change. cc30bda2be In resynthesis tests, do not attempt to distinguish missing bound from Object. a1bd1dd6ee Use standard I/O posix functions for Fuchsia, not 64 bit variants 6f284b45f7 Fixes for applying resolution to InstanceCreationExpression. 1eacd27b8e [VM runtime] Type bounds do not need to be checked during type finalization in strong mode, since bound checks are explicitly emitted where needed. 5db9e6c95e [VM interpreter] Do not load bytecode of synthesized functions with copied metadata. Fix return of native call to bytecode function. Fix stack level when returning from static field initializer. Use a zone handle for handled exception types. bcacff49ba Ignore deferredCheck() in resolution storer. 423edf86be Fix analyzer/FE integration of local generic functions with bounds. 0e7e0c945a [vm/kernel/bytecode] Generate argument checks after allocating initial context 3fd61646ce Fix analyzer/FE integration of redirected constructors involving type arguments. d03210cdf4 Fix storage of types for local functions that are generic. 4426f5a33e [gardening] Mark large_class_declaration_test Slow in debug, dart1 85253708a3 [build] Include kernel-service snapshot in the platform sdk f0bc620143 Validate location in store(). b4a426fa72 [dart:io] Adds HttpClient.connectionTimeout cb4a19b5fc misc(pkg/analyzer): update to latest pkg:matcher API d2bde00d9d Cleanup skipFormalParameters and remove unused methods 56cb7bac02 Fix for applying resolution to static field annotations. 723bcbd5f9 Added link to see webdev.dartlang.org b9dbe3a0be Fix analyzer/FE integration for `is!` expressions. bef0eca2e3 [gardening] Update status after a7f0f7ea899fe7812f54eea8f957a92153e3176e f5e8cc3517 Remove old code with incorrect instantiation to bounds on typedefs edf26852e6 linter 0.1.55 544358304d [VM] - Add --preview-dart-2 option back as a nop - Temporarily treat --checked as an alias for --enable-asserts in Dart2 mode so that google3 test scripts don't need to change. e7da604c11 More updates for -DuseFastaParser. efa4b21c4f [fuchsia] Update zx_cprng_draw a7f0f7ea89 [vm] Add source positions to stack traces of bool checks 70087c349b Fixes for applying resolution to annotations. 21b077a81c Fix incorrect handling of non-generic typedefs. 37d9e79b1b Update co19 and co19 strong branch in DEPS 7d1642e081 [gardening] Mark large_class_declaration_test Slow. dce6663028 Add message to assert to explain the problem b20dc7b98a Update the script to re-gen the analysis server spec. 29c549bfe2 [vm/kernel] Use old space in a specific Kernel FE error allocation. e13b9e8a75 [fasta] Update expectation files after cf2966ea 46167dfd88 It is OK to declare a const constructor in a class with a mixin, if it has no fields. 88a88b03dc Fix token used for large negative integers. b43dc893eb Remove spec references to Symbol constructor. cf2966ea0d [fasta] Generate noSuchMethod forwarders for abstract accessors 28ed0d743d Make it explicit that "dynamic" is exported from dart:core. ce312b9632 Add --analyzer-use-fasta and --analyzer-use-fasta-parser to test.py 25286e4a7d Add tests for optimization of Flutters use of Widget.runtimeType df2529d443 Detect when a class has a member that conflicts with a static one 50fe42a886 Reduce use of putIfAbsent 385cde3977 Resolve 'dynamic' element references. 70576f431e Roll https://github.com/dart-lang/pub/pull/1938 into the SDK. 46710a77dd Make checked flag again only enable assertions in Dart 2.0 e0905b979a Revert "Add ClassHierarchy to share code between J/KClosedWorld" 9179db84df Resynthesize typedef types properly from kernel. c53952a46d [vm/kernel/bytecode] Generate bytecode for assertions, bool checks a6c2c97d7e Rename ResynthesizeKernelStrongTest to ResynthesizeTest_Kernel cad8d4a741 Store instance creation information at arguments offset. a4c7cf388f First stab at a parsing library for named configurations. 008aa729c5 [VM interpreter] Support implicit getters and setters without compiling them. 54bc1548b0 [fuchsia] Update to Sync2Ptr 05b19947a4 Prep for analyzer 0.32.2 a1efbd326f Change FrontEndCompiler.getOutline() to return full kernels. 966541bec9 Improve literal function recovery 386efb1e6a Improve type parameter recovery 5c9add2c46 Allow Future<T> to be assigned to Future<void> 9c7cd04e7f [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6661 [gardening] Update status file 5a193752f6 Clean up some hints e67c5953e9 Relax return restrictions. a9c624a010 [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f37a9 Update dart_style package to 1.1.0 in DEPS f67308a983 Handle invalid dill files more gracefully 9aa0c4ae3f [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3bc2 Update app_jitk service status a16ad6d9de [infra] Make update_homebrew script work on Dart2 014a5bc678 Replace strstr with strncmp looking for path separator d2d47acdce [kernel] Include urls even when we have no source 5f17b0a0be Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3c1d Add tests showing the async impact on function type checks 8e4d5c0a38 Update formated error for nonexisting constructor a8e930caf3 Add ClassHierarchy to share code between J/KClosedWorld c9bd4df214 Document IntLiteral.value as holding a uint64 value 56d57407e1 Fix status for new test ed20faa2ed Add test for rejecting inexact numbers 31ed467871 Fix directory-prefix finding logic so it works on Windows. 2d6eaba187 pkg:build_integration: clarify that' it's not planned to be published f67cba1067 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd08fb Doc - Fix OSError.message and errorCode doc c97f177112 Issue 33518. Fix for subtypes() in parts without library. e661c9ef54 Simplify 'as T' for simple T 65a3c4443b [observatory] Update packages and remove dead dependencies. b15572933d Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533ff72 snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6232 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623654 Check function types in the correct order in runZoned. 6d25212302 getStats Future should be strongly typed. ca99917fb6 Remove code awaiting void results to unblock #33145 19f60bfb52 Improve fasta parser expression recovery d632980ee0 Add tokens to more judgements 5721d8af6d - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037164 Fix second half on #33343: disallow generic functions as type arguments. 97c81d668a Remove variableSet factory methods. 98efc7917f Improve parse assert statement recovery a93e303f3f [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81bfe7 Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6cae Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560fc6 Count analyzer cfe integration failing tests. 77f94ec259 Convert ShadowLogicalExpression to LogicalJudgment 1a0fc733d3 Add tokens to more judgements 81191186d8 Remove unused class 284b5cce55 Partial fix of #33343. Reject generic function types as bounds. ada8188b73 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd28c [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbdac5c Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e182 [fasta] Update .expect files for non-simple bound tests aeff1c00f2 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a55c1 Change infer to return the expression instead of its type b9f11311f8 [vm/compiler] Fix incorrect assertion from 20ca5bbb056. f85fbde727 Expression compilation fix 6240dd5cc3 Make incremental_load_from_dill_test dart2 compliant 8747da838f Bump kernel version after e2ce88d 20ca5bbb05 [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec380 [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817322 Check whether variables is set before using GN not_needed f381778867 Update the status of analysis server tests. 8b10b1fda9 Add tokens to judgements, part 2 8c1591af9e Add a binder mechanism to the Factory API for handling labels. e132240c91 Re-enable some failing analyzer_cli --use-cfe tests. f598e6933c Drop support for Dart 1 in pub 9146cea63a Print times in seconds ec0df457a2 Convert invocation Shadow(s) to Judgment(s). 223b143167 Workaround for issue 33559. 091f8860c2 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27acd Add unittest for InferenceData 70ac1f90ec Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576dd4 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82ef9a [dart2js] Fix for issue 33572 1416ed283a Convert ShadowNot to NotJudgment. a1a2d90a6c Convert ShadowForStatement to ForJudgment. 7c6211b1d8 Make unittests work with Dart 2 a8d805055a Handle covariant parameters in function types b24170259c Don't add parts without 'part of' as libraries. fea8cb1473 Revise order of type variable declaration events 6339976567 Rename lemma to binder 9d499fffe4 Start adding tokens to judgements ff7a1255aa Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70ec5b Docs - Update example websockets app; use idiomatic async/await in examples ed0ba901e1 Doc - Fix library links in analyzer docs 4c697085be dart2js: Make bazel-input-provider dart2 compliant. 9b814bdf34 Use the lemma approach for NamedFunctionExpression 7c0d31092d Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353f76 Update dartdoc to 0.20.1. eafa9ae4b6 [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708eada [VM interpreter] Fix broken interpreter build. 94abf948c4 pkg:status_file misc cleanup 02721709c3 Fix a committed solo test and mark it as passing now. c8a488c1ca Add parameters to Forest method to support labeled statements c4d6ac0cbe [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363cba0 Rename typeContext to inferredType 10dcad1dd2 pkg:kernel - cleanup pubspec file 7e7fd7ffa5 Convert ShadowLiteralList into LiteralListJudgment 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2840 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9af5 Fix cascade specification. d08317b79f Make status file linter valid Dart 2 code f4d2bf313e Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2824 Compile time error for web int literals that cannot be represented exactly 075c713a93 Register type arguments on inlining 4ebdb31646 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90c42 Convert ShadowRethrow to RethrowJudgment 7661841cc5 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd40725af Convert ShadowIfNullExpression to IfNullJudgment 7c327c32b7 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c8f3 [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0ff07 Convert ShadowStringConcatenation to StringConcatenationJudgment d0655066a5 Use the lemma approach for other variable declaring constructs. 2121c3bb56 Docs - Link to the Random.secure constructor in dartdoc 975686d5a9 [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c268e [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38dec5 [vm, standalone] Do not copy when loading kernel. 8d7c5294c6 Rename the kernel ShadowExpressions for assignments 47f394d61c Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4cdf Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af84e7 DEPS: update crypto version 530f1f6512 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc3352e0 Replace and remove parseType 1b681a75c3 Modify Factory API to allow forward references to incomplete local functions and variables. f682213764 Add parameters to Factory methods to support the try statement cf6fbd9e07 Add parameters to Factory methods to support the switch statement b50ff4990a Add parameters to Factory methods for list and map literals c5855635ae Add Factory method parameters for for loops c2a22c6462 Updates to ddc/ddb tool 1a1ff9e666 Reverse the pub snapshot names d5d5daf411 Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c636 Fix docs for async File methods 569341cbe0 Improve CompressionOptions docs: 8d40afc9c0 Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfcacb Convert ShadowForInStatement to ForInJudgment. f2eaf6aae7 Remove type parameters from the Fasta BodyBuilder 74dd5440f1 Convert ShadowStringLiteral into StringLiteralJudgment 10641cbf42 Update status files after 52b2a869bcb93 ee19f2804a Make ResolutionStorer implement the Factory API. e2ce88dfcc Add startFileOffset on procedures et al, enable VMs GetSource 52b2a869bc Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9163 Update testing scripts to run on a Dart 2 VM 8638668ecf [VM] Fix vm->native state transition in isolate_reload.cc 71ac67aed1 [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8dfe85 Stop using !kernel annotations 3e85df5167 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575a54 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcca7f Roll pub to the latest version. abc8793109 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb154e9 [vmservice] Report expression compilation errors b28ebca825 Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2305 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848fe0f Convert ShadowWhileStatement to WhileJudgment. 5ccc497678 Inline constructor bodies that are called once 4df14626b3 Add parameters to Factory methods for constructor initializers dce00bc836 - fix a strong mode type error - mark a test as slow 83a4d98554 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee90f [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1fad8 Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f578c Convert ShadowTryCatch to TryCatchJudgment. 6182b7215d [vm/kernel/bytecode] Fix passing of type arguments b343d0a80d trigger error for const A(B()) if B non-const 06a588233c Fix package_root_test.dart on mac buildbot. 8419090c8c Cleanup type variable event sequence 8da640704a [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe657 Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c141f [vm] Shorten the write barrier sequence. b6aa31f7d8 Add required parameters to Factory.catchStatement 34bbb1da30 [Gardening] Move status line to the correct section. 68ecf31fc5 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1cd7 Add parameters to Factory API, part 2 85c27d78c1 [Gardening] Removed incorrect entry in the status file. 2edbfd95a7 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b130 Added super_no_such_method5_test also to the issue list for 33517 254d8ef153 Switch ShadowYieldStatement to YieldJudgment. 64fd6653cf Update deprecated references. 13fb4da312 Convert ShadowIfStatement to IfJudgment. 71042d3dfa linter 0.1.54 e9f994892d Cleanup unescape error messages 7b68a4516f Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9dca5 Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85c76 Re-enable the old analyzer/FE integration logic. 9bd3350f1f Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353fe29 Convert ShadowReturnStatement to ReturnJudgment. 462d2a35d3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8bbd5 [VM][kernel] Don't mix in noSuchMethod forwarders 6612278b71 Skip non-utf8 file tests on reload builders, where they time out 125fae6d56 Incorporate comments from an earlier code review 188c858a4c [gardening] Fix standalone/app_snapshot_share_test 1c4b362ba5 Support noSuchMethod forwarders in dart2js 276598199e Make DDK interpret IntLiteral.value as uint64 a049e340eb Revert the fix for issue #31770 d4a69bde98 app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d6d9 [dart2js] Fix for issue 33500 828df76c85 Notify kernel service of isolate shutdown. a36fbd1990 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d33d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d35f5 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983e0a Convert ShadowStaticGet to StaticGetJudgment acd375cc77 [gardening] Silence flaky test which times out on simarm64 bot 3becdb8afd Convert property gets to judgments. 9db4b71442 Convert ShadowIntLiteral to IntJudgment 37084e677c Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8e42 Convert ShadowNullLiteral to NullJudgment. 3a2a84db9c Improve misplaced factory/modifier recovery 3586fcb165 Cleanup deprecated code eac395c33d Add parameters needed by analyzer to Factory, part 1 edcd3be290 Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683a88 Convert ShadowDoStatement to DoJudgment. 8e8fb38c48 Convert ShadowBlock to BlockJudgment. b71fb2e086 Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f23243b Enable Dart2 in dart2js by default 6b96e65c5b Convert ShadowArguments to ArgumentsJudgment. 437b492042 [gardening] Update status for reload-kernel bots a3a1113cfd Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871ae88 Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6a49 Add a Type parameter to Factory and update one method 119236996a [build] Remove tools/compile_platform.py ddde9820a9 Improve fasta parser parameter list recovery f5a0e3efa8 Create NamedExpressionJudgment. 165c57ffd7 Attempt to fix the windows bot 3 bb1fcebd36 [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d54c6 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d39504f Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49134 Support asset directories in flutter pubspec validation. 015d9eff49 Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff9361f Track which import is referenced by each prefix. 92c24a1ee7 Skip sample_extension_app_snapshot_test on opt-counter-threshold builders 33d41a928a [VM] Fix incorrect memory allocation f3960a0111 Fix language_2/vm/optimized_guarded_field_isolates_test e496efb611 [VM] Adjust status file after 6db5f38d4ee4d ef49436487 [fasta] Update expectation files after noSuchMethod forwarders change 049195b15d Fix path to entry points json file in app_snapshot_share_test b024432a29 [VM] Disable test in reload/rollback mode due to snapshot generation 6db5f38d4e [fasta] Don't generate noSuchMethod forwarders in abstract classes 7979232580 Re-added header, only needed to remove the other resource section. a38b9bed23 Restore dart2js-checked and dart-aot in try_benchmarks.sh. 7be47cd30d Remove some dead code (including implicit setters) 1c01aa7704 Convert some ShadowExpressions into inference judgments 6e6bdb486a Ensure we run app_snapshot_share_test d7e5332057 Make dual use of a part in the same program an error. 856c7c67ea Skip standalone_2 on !strong configurations (for JIT / AOT VM) ba024be044 Mark dart2js specific argument as deprecated. 20fe2f0ada Indent error pointer correctly in the presence of tabs. bd94de8e48 Use dynamic to fix string_interpolate_test b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator f288124d5a Fix InvalidInlineFunctionType example 15821a28a3 Explicit type args in body_builder 1f6925718b Add message for missing type arguments 87e045c484 Remove the helper dart script from our browser test framework 532b9aaa93 Flatten *WorldBuilder hierarchies. f1d44e39fa Update status for passing Windows Firefox co19 tests efb4f69a13 Adjust simarm status. 1a443da6ad Adjust options passed to precompile runtime. f8caffd9e6 Remove some uses of Platform.packageRoot. ebe2f1db2c Adjust status files. 6fcc95d2a4 Adjust status files. f2f6ebf547 Convert ShadowAssertInitializer to AssertInitializerJudgment. ea837c91a0 Transition tests to EvaluateCompiledExpression. 3e6e2dd7f4 Convert ShadowAssertStatement to AssertStatementJudgment. 27fefd7bb3 Convert ShadowAwaitExpression to AwaitExpressionJudgment. dd1c54c442 Convert ShadowBoolLiteral to BoolLiteralJudgement 4a353fea35 Another attempt to fix tests on Windows a69d922794 Adjust some of the test expectations based on the flip to Dart 2 mode. b3b8ca6dc4 Remove the --package-default-analysis-options flag. 9943547d5d Default pub to Dart 2 with opt out aba94f051e Convert ShadowAsExpression to AsJudgment. bc7220a4fd [VM] Turn dart2 on by default on the command line VM cdd2553a12 [vm/kernel/bytecode] Fix null handling in operator == df2bf6590d [VM runtime] Minor cleanup of stubs on all architectures as already done for x64 b140baeb55 Own files by their URIs during search. 56cee22800 Build out the initial version of the Factory class (and derived classes). 83cb0c425d Fix awaiting void in analyzer ast_test.dart. Fix at method decl. c9af309cbf Fix fasta parsing of ?. in cascade expression 67695b9842 Fix the dependencies on the dartdevk_sdk build step. 0a59b2ff90 Fix test cases that await "void." Blocks #33415, making that an error 3ba3e2a752 Revert "switch to dart_action until prebuilt Windows Dart VM is updated" 741ed336f1 Improve AstBuilder int literal recovery e77158eb38 First steps toward generating analyzer/kernel ASTs during type inference. f1c3f997bd [VM] Clear out return-value-register from call-to-runtime-stub, it needs to be GC-safe for lazy deopts 686fd133a7 [VM interpreter] Propagate unhandled exception returned from jitted code to interpreter. 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 7d94755836 Issue 33471. Use full ResolveResult in Extract Local refactoring. 57c0fc9593 [vm/corelib] More cleanup in integer operations after _Bigint is removed 88d12fda42 Parse throw on RHS of an assignment 1dcc3264e7 Fix tests that are failing on Windows 691313f357 Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin. e62f563b2d Validate sdkPath in AnalysisContextCollectionImpl. 493c421f0d Add AnalysisContextCollection. ``` * Roll dart sdk to 4552beb514c5b54fbe9c5a0791f7b95253ac09b9. Changes since last roll: ``` 4552beb514 Revert "[vm/kernel-service] Report an error if isolate compilation options change." f304948807 [vm] Refactoring: extract kernel translation helpers to a separate file 5a47f4c9fa Apply resolution for ParameterElement metadata. db7b5072af Reenable FutureOr resynthesis tests with kernel. 1f8148f862 [infra] Restore sync-async behavior to fix legacy precompiler bots d9911b8a8a Add language_2 test status entries for -cdart2analyzer --use-cfe b0b1020588 [fasta] Add more tests for noSuchMethod forwarders 90e27b19ea Check for conflicts between a static setter and a constructor or static method. b0cbc4e9cd Fix a bug in top-level type inference dependency tracking 29924c4000 In observatory use ArgumentError instead of FallThroughError bd9aa5139a Error on cyclic constructor redirect. 1a6c857a93 Remove ExpressionGenerator.buildThrowNoSuchMethodError c53746fc8a Add lexeme2 template key 2f739fd7d9 Default implementation of _makeRead and _makeWrite 36b22c7ae9 Remove unused files 583a81ade3 [infra] Make test.py's --strong option a no-op to prepare for removing it 17b53a2835 Test out no_implicit_casts on the analyzer source base. 2ee635977d Revert separation of getOutline() and getResolution() in FrontEndCompiler. fc472e03da Don't store resolution for desugaring generated NotJudgment. e0845f9359 [vm/kernel-service] Report an error if isolate compilation options change. cc30bda2be In resynthesis tests, do not attempt to distinguish missing bound from Object. a1bd1dd6ee Use standard I/O posix functions for Fuchsia, not 64 bit variants 6f284b45f7 Fixes for applying resolution to InstanceCreationExpression. 1eacd27b8e [VM runtime] Type bounds do not need to be checked during type finalization in strong mode, since bound checks are explicitly emitted where needed. 5db9e6c95e [VM interpreter] Do not load bytecode of synthesized functions with copied metadata. Fix return of native call to bytecode function. Fix stack level when returning from static field initializer. Use a zone handle for handled exception types. bcacff49ba Ignore deferredCheck() in resolution storer. 423edf86be Fix analyzer/FE integration of local generic functions with bounds. 0e7e0c945a [vm/kernel/bytecode] Generate argument checks after allocating initial context 3fd61646ce Fix analyzer/FE integration of redirected constructors involving type arguments. d03210cdf4 Fix storage of types for local functions that are generic. 4426f5a33e [gardening] Mark large_class_declaration_test Slow in debug, dart1 85253708a3 [build] Include kernel-service snapshot in the platform sdk f0bc620143 Validate location in store(). b4a426fa72 [dart:io] Adds HttpClient.connectionTimeout cb4a19b5fc misc(pkg/analyzer): update to latest pkg:matcher API d2bde00d9d Cleanup skipFormalParameters and remove unused methods 56cb7bac02 Fix for applying resolution to static field annotations. 723bcbd5f9 Added link to see webdev.dartlang.org b9dbe3a0be Fix analyzer/FE integration for `is!` expressions. bef0eca2e3 [gardening] Update status after a7f0f7ea899fe7812f54eea8f957a92153e3176e f5e8cc3517 Remove old code with incorrect instantiation to bounds on typedefs edf26852e6 linter 0.1.55 544358304d [VM] - Add --preview-dart-2 option back as a nop - Temporarily treat --checked as an alias for --enable-asserts in Dart2 mode so that google3 test scripts don't need to change. e7da604c11 More updates for -DuseFastaParser. efa4b21c4f [fuchsia] Update zx_cprng_draw a7f0f7ea89 [vm] Add source positions to stack traces of bool checks 70087c349b Fixes for applying resolution to annotations. 21b077a81c Fix incorrect handling of non-generic typedefs. 37d9e79b1b Update co19 and co19 strong branch in DEPS 7d1642e081 [gardening] Mark large_class_declaration_test Slow. dce6663028 Add message to assert to explain the problem b20dc7b98a Update the script to re-gen the analysis server spec. 29c549bfe2 [vm/kernel] Use old space in a specific Kernel FE error allocation. e13b9e8a75 [fasta] Update expectation files after cf2966ea 46167dfd88 It is OK to declare a const constructor in a class with a mixin, if it has no fields. 88a88b03dc Fix token used for large negative integers. b43dc893eb Remove spec references to Symbol constructor. cf2966ea0d [fasta] Generate noSuchMethod forwarders for abstract accessors 28ed0d743d Make it explicit that "dynamic" is exported from dart:core. ce312b9632 Add --analyzer-use-fasta and --analyzer-use-fasta-parser to test.py 25286e4a7d Add tests for optimization of Flutters use of Widget.runtimeType df2529d443 Detect when a class has a member that conflicts with a static one 50fe42a886 Reduce use of putIfAbsent 385cde3977 Resolve 'dynamic' element references. 70576f431e Roll https://github.com/dart-lang/pub/pull/1938 into the SDK. 46710a77dd Make checked flag again only enable assertions in Dart 2.0 e0905b979a Revert "Add ClassHierarchy to share code between J/KClosedWorld" 9179db84df Resynthesize typedef types properly from kernel. c53952a46d [vm/kernel/bytecode] Generate bytecode for assertions, bool checks a6c2c97d7e Rename ResynthesizeKernelStrongTest to ResynthesizeTest_Kernel cad8d4a741 Store instance creation information at arguments offset. a4c7cf388f First stab at a parsing library for named configurations. 008aa729c5 [VM interpreter] Support implicit getters and setters without compiling them. 54bc1548b0 [fuchsia] Update to Sync2Ptr 05b19947a4 Prep for analyzer 0.32.2 a1efbd326f Change FrontEndCompiler.getOutline() to return full kernels. 966541bec9 Improve literal function recovery 386efb1e6a Improve type parameter recovery 5c9add2c46 Allow Future<T> to be assigned to Future<void> 9c7cd04e7f [ VM / Testing ] Disabled non_utf8_* tests for FileSystemEntity classes 5c9e9a6661 [gardening] Update status file 5a193752f6 Clean up some hints e67c5953e9 Relax return restrictions. a9c624a010 [infra] Update checked in SDKs to 2.0.0-dev.65.0 12971f37a9 Update dart_style package to 1.1.0 in DEPS f67308a983 Handle invalid dill files more gracefully 9aa0c4ae3f [release] Prepare changelog for 2.0.0-dev.65.0 9a8b5f3bc2 Update app_jitk service status a16ad6d9de [infra] Make update_homebrew script work on Dart2 014a5bc678 Replace strstr with strncmp looking for path separator d2d47acdce [kernel] Include urls even when we have no source 5f17b0a0be Convert ShadowMapLiteral to MapLiteralJudgment 2c98fb3c1d Add tests showing the async impact on function type checks 8e4d5c0a38 Update formated error for nonexisting constructor a8e930caf3 Add ClassHierarchy to share code between J/KClosedWorld c9bd4df214 Document IntLiteral.value as holding a uint64 value 56d57407e1 Fix status for new test ed20faa2ed Add test for rejecting inexact numbers 31ed467871 Fix directory-prefix finding logic so it works on Windows. 2d6eaba187 pkg:build_integration: clarify that' it's not planned to be published f67cba1067 [vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. 2876bd08fb Doc - Fix OSError.message and errorCode doc c97f177112 Issue 33518. Fix for subtypes() in parts without library. e661c9ef54 Simplify 'as T' for simple T 65a3c4443b [observatory] Update packages and remove dead dependencies. b15572933d Update checked-in Dart SDK to 2.0.0-dev.64.1 9d3533ff72 snapshot the kernel worker in dart 2 mode and fix some dart 2 errors b29bde6232 Convert ShadowSyntheticExpression to SyntheticExpressionJudgment 2876623654 Check function types in the correct order in runZoned. 6d25212302 getStats Future should be strongly typed. ca99917fb6 Remove code awaiting void results to unblock #33145 19f60bfb52 Improve fasta parser expression recovery d632980ee0 Add tokens to more judgements 5721d8af6d - Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. 3640037164 Fix second half on #33343: disallow generic functions as type arguments. 97c81d668a Remove variableSet factory methods. 98efc7917f Improve parse assert statement recovery a93e303f3f [vm/kernel/bytecode] Bytecode generation for rarely used operations a0ba81bfe7 Convert ShadowCascadeExpression to CascadeJudgment. de4d8b6cae Convert ShadowSymbolLiteral to SymbolLiteralJudgment 13c3560fc6 Count analyzer cfe integration failing tests. 77f94ec259 Convert ShadowLogicalExpression to LogicalJudgment 1a0fc733d3 Add tokens to more judgements 81191186d8 Remove unused class 284b5cce55 Partial fix of #33343. Reject generic function types as bounds. ada8188b73 Update pkg/pkg.status with the latest -DuseFastaParser status. e232ddd28c [VM] Handle [VariableGet]s for parameters/let variables differently than other const variables 5d4dbdac5c Adjust stringContentTDQ, stringContentTSQ to allow escapes. b27b62e182 [fasta] Update .expect files for non-simple bound tests aeff1c00f2 [vm/compiler] Improve CallTargets::CreateAndExpand 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 2f474a55c1 Change infer to return the expression instead of its type b9f11311f8 [vm/compiler] Fix incorrect assertion from 20ca5bbb056. f85fbde727 Expression compilation fix 6240dd5cc3 Make incremental_load_from_dill_test dart2 compliant 8747da838f Bump kernel version after e2ce88d 20ca5bbb05 [vm/jit] Introduce dynamic invocation forwarders that perform type checking f9a11ec380 [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 212a817322 Check whether variables is set before using GN not_needed f381778867 Update the status of analysis server tests. 8b10b1fda9 Add tokens to judgements, part 2 8c1591af9e Add a binder mechanism to the Factory API for handling labels. e132240c91 Re-enable some failing analyzer_cli --use-cfe tests. f598e6933c Drop support for Dart 1 in pub 9146cea63a Print times in seconds ec0df457a2 Convert invocation Shadow(s) to Judgment(s). 223b143167 Workaround for issue 33559. 091f8860c2 [ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. 9276b27acd Add unittest for InferenceData 70ac1f90ec Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" c270576dd4 Use FunctionNodeJudgment in FunctionExpressionJudgment. aeba82ef9a [dart2js] Fix for issue 33572 1416ed283a Convert ShadowNot to NotJudgment. a1a2d90a6c Convert ShadowForStatement to ForJudgment. 7c6211b1d8 Make unittests work with Dart 2 a8d805055a Handle covariant parameters in function types b24170259c Don't add parts without 'part of' as libraries. fea8cb1473 Revise order of type variable declaration events 6339976567 Rename lemma to binder 9d499fffe4 Start adding tokens to judgements ff7a1255aa Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. 5bfb70ec5b Docs - Update example websockets app; use idiomatic async/await in examples ed0ba901e1 Doc - Fix library links in analyzer docs 4c697085be dart2js: Make bazel-input-provider dart2 compliant. 9b814bdf34 Use the lemma approach for NamedFunctionExpression 7c0d31092d Rename variableLemma and variableType to clarify that they refer to the loop variable. b36f353f76 Update dartdoc to 0.20.1. eafa9ae4b6 [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 3e2708eada [VM interpreter] Fix broken interpreter build. 94abf948c4 pkg:status_file misc cleanup 02721709c3 Fix a committed solo test and mark it as passing now. c8a488c1ca Add parameters to Forest method to support labeled statements c4d6ac0cbe [vm/compiler/aot] Implement non-speculative int64 shift operation 3af363cba0 Rename typeContext to inferredType 10dcad1dd2 pkg:kernel - cleanup pubspec file 7e7fd7ffa5 Convert ShadowLiteralList into LiteralListJudgment 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 121fed2840 Convert ShadowDeferredCheck to DeferredCheckJudgment e2c54e9af5 Fix cascade specification. d08317b79f Make status file linter valid Dart 2 code f4d2bf313e Convert ShadowFunctionExpression to FunctionExpressionJudgment 6888bc2824 Compile time error for web int literals that cannot be represented exactly 075c713a93 Register type arguments on inlining 4ebdb31646 Separate getOutline() and getResolution() in FrontEndCompiler. 6a7bf90c42 Convert ShadowRethrow to RethrowJudgment 7661841cc5 Convert ShadowNamedFunctionExpression to NamedFunctionExpressionJudgment 6fd40725af Convert ShadowIfNullExpression to IfNullJudgment 7c327c32b7 [frontend-server] Fix starter so it works in '--incremental' mode f885a0c8f3 [vm/kernel] Fix crash when reading symbol literal from Dart annotation 16c0c0ff07 Convert ShadowStringConcatenation to StringConcatenationJudgment d0655066a5 Use the lemma approach for other variable declaring constructs. 2121c3bb56 Docs - Link to the Random.secure constructor in dartdoc 975686d5a9 [syscalls] Use vmar..._old apis. Modify existing calls to vmar routines in preparation for changing the parameter order. 7d7e7c268e [vm] Work around interaction between type and instance canonicalization in isolate messages. fa7c38dec5 [vm, standalone] Do not copy when loading kernel. 8d7c5294c6 Rename the kernel ShadowExpressions for assignments 47f394d61c Update checked-in Dart SDK to 2.0.0-dev.64.1 efd36d4cdf Updated non_utf8_* tests to better cleanup after themselves. Fixes issue d1e1af84e7 DEPS: update crypto version 530f1f6512 [build] Possible fix for 'Error while initializing Kernel isolate' e9bc3352e0 Replace and remove parseType 1b681a75c3 Modify Factory API to allow forward references to incomplete local functions and variables. f682213764 Add parameters to Factory methods to support the try statement cf6fbd9e07 Add parameters to Factory methods to support the switch statement b50ff4990a Add parameters to Factory methods for list and map literals c5855635ae Add Factory method parameters for for loops c2a22c6462 Updates to ddc/ddb tool 1a1ff9e666 Reverse the pub snapshot names d5d5daf411 Fixed cascade_test failure due to return type of operator []= being non-void. 69c807c636 Fix docs for async File methods 569341cbe0 Improve CompressionOptions docs: 8d40afc9c0 Convert ShadowTryFinally to TryFinallyJudgment. 4a9abfcacb Convert ShadowForInStatement to ForInJudgment. f2eaf6aae7 Remove type parameters from the Fasta BodyBuilder 74dd5440f1 Convert ShadowStringLiteral into StringLiteralJudgment 10641cbf42 Update status files after 52b2a869bcb93 ee19f2804a Make ResolutionStorer implement the Factory API. e2ce88dfcc Add startFileOffset on procedures et al, enable VMs GetSource 52b2a869bc Update some noSuchMethod based tests to the currently desired behavior. bf4f9a9163 Update testing scripts to run on a Dart 2 VM 8638668ecf [VM] Fix vm->native state transition in isolate_reload.cc 71ac67aed1 [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 216e8dfe85 Stop using !kernel annotations 3e85df5167 [ VM / Dart API ] Added additional methods required for Flutter background execution. fa19575a54 [vm/kernel/bytecode] Inline list of types into TypeArgumentsForInstanceAllocation constant pool entry c37bbcca7f Roll pub to the latest version. abc8793109 [VM interpreter] Adjust bytecode constant pool reading for inlined list of types in TypeArgumentsForInstanceAllocation entry. 8d3eb154e9 [vmservice] Report expression compilation errors b28ebca825 Begin reworking ResolutionStorer API to look more like the Factory class. f6871d2305 [vm/kernel/bytecode] Fix generation of InstantiateTypeArgumentsTOS bytecode 272848fe0f Convert ShadowWhileStatement to WhileJudgment. 5ccc497678 Inline constructor bodies that are called once 4df14626b3 Add parameters to Factory methods for constructor initializers dce00bc836 - fix a strong mode type error - mark a test as slow 83a4d98554 [vm] Weaken CAS to RMW when accessing the remembered and mark bits. e76fbee90f [VM interpreter] Provide arm64 stubs. Minor cleanups. a3dde1fad8 Convert ShadowSwitchStatement to SwitchStatementJudgment. e8323f578c Convert ShadowTryCatch to TryCatchJudgment. 6182b7215d [vm/kernel/bytecode] Fix passing of type arguments b343d0a80d trigger error for const A(B()) if B non-const 06a588233c Fix package_root_test.dart on mac buildbot. 8419090c8c Cleanup type variable event sequence 8da640704a [vm/linearscan] Reserve slots for catch block entry when nothing is spilled 80a8bfe657 Convert ShadowExpressionStatement to ExpressionStatementJudgment. 2f664c141f [vm] Shorten the write barrier sequence. b6aa31f7d8 Add required parameters to Factory.catchStatement 34bbb1da30 [Gardening] Move status line to the correct section. 68ecf31fc5 Update CHANGELOG.md with text for the default switching to Dart 2.0. e15b6a1cd7 Add parameters to Factory API, part 2 85c27d78c1 [Gardening] Removed incorrect entry in the status file. 2edbfd95a7 Convert ShadowVariableDeclaration to VariableDeclarationJudgment. 075027b130 Added super_no_such_method5_test also to the issue list for 33517 254d8ef153 Switch ShadowYieldStatement to YieldJudgment. 64fd6653cf Update deprecated references. 13fb4da312 Convert ShadowIfStatement to IfJudgment. 71042d3dfa linter 0.1.54 e9f994892d Cleanup unescape error messages 7b68a4516f Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError(). 7d9ac9dca5 Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 591cf85c76 Re-enable the old analyzer/FE integration logic. 9bd3350f1f Convert ShadowContinueSwitchStatement to ContinueSwitchJudgment. 92f353fe29 Convert ShadowReturnStatement to ReturnJudgment. 462d2a35d3 Convert shadow nodes for 'is' and 'is!' into inference judgments a3a8d8bbd5 [VM][kernel] Don't mix in noSuchMethod forwarders 6612278b71 Skip non-utf8 file tests on reload builders, where they time out 125fae6d56 Incorporate comments from an earlier code review 188c858a4c [gardening] Fix standalone/app_snapshot_share_test 1c4b362ba5 Support noSuchMethod forwarders in dart2js 276598199e Make DDK interpret IntLiteral.value as uint64 a049e340eb Revert the fix for issue #31770 d4a69bde98 app_snapshot_share_test now runs only in dartk and dartkp mode. 75f485d6d9 [dart2js] Fix for issue 33500 828df76c85 Notify kernel service of isolate shutdown. a36fbd1990 Skip app_snapshot_share test in precompiled dart1 mode as the test spawns a dart process which runs in Dart2 mode and hence needs a kernel file generation step to run. This test now makes sense only in dartk and dartkp modes. 6dfa10d33d Generate the kernel buffers using bin_to_assembly rule instead of dill_to_cc. This should fix the clang tool errors we are seeing. 8da46d35f5 [vm] Move heap-related code to its own subdirectory (cf. compiler). 2f3c983e0a Convert ShadowStaticGet to StaticGetJudgment acd375cc77 [gardening] Silence flaky test which times out on simarm64 bot 3becdb8afd Convert property gets to judgments. 9db4b71442 Convert ShadowIntLiteral to IntJudgment 37084e677c Convert ShadowDoubleLiteral to DoubleJudgment d84d3f8e42 Convert ShadowNullLiteral to NullJudgment. 3a2a84db9c Improve misplaced factory/modifier recovery 3586fcb165 Cleanup deprecated code eac395c33d Add parameters needed by analyzer to Factory, part 1 edcd3be290 Update aot_assembly rule to temporarily use --no-preview-dart-2 until it is updated to call gen_kernel to produce a kernel file before creating the AOT snapshot. 3d96683a88 Convert ShadowDoStatement to DoJudgment. 8e8fb38c48 Convert ShadowBlock to BlockJudgment. b71fb2e086 Convert ShadowBreakStatement to BreakJudgment and ContinueJudgment. c96f23243b Enable Dart2 in dart2js by default 6b96e65c5b Convert ShadowArguments to ArgumentsJudgment. 437b492042 [gardening] Update status for reload-kernel bots a3a1113cfd Convert ShadowConditionalExpression to ConditionalJudgment. 5b2871ae88 Ensure that constructor invocation file offset is set correctly for annotations. bedbdf6a49 Add a Type parameter to Factory and update one method 119236996a [build] Remove tools/compile_platform.py ddde9820a9 Improve fasta parser parameter list recovery f5a0e3efa8 Create NamedExpressionJudgment. 165c57ffd7 Attempt to fix the windows bot 3 bb1fcebd36 [dart:io] Expose Crypto::GetRandomBytes in embedded_dart_io.h 23f87d54c6 [vm/kernel/bytecode] Implement strong mode type checks in bytecode 1e7d39504f Convert ShadowLabeledStatement to LabeledStatementJudgment. d895b49134 Support asset directories in flutter pubspec validation. 015d9eff49 Use ShadowEmptyStatement instead of EmptyStatement in blocks. 029ff9361f Track …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix dart-lang/sdk#33577.
I discovered (after painful trial and error) that the tests for binstubs are basically broken. They don't run pub from its own repo and instead run the pub that's currently in the Dart repo where you invoked the Dart VM from. I left a comment to that effect, but I don't want to fix it now.
I did verify that this fixes the issue by: