Add test for issue when excluding a nested dir from a higher level gitignore file #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in the issue I believe you are "holding it wrong". I think we implement the correct rules here. They are just somewhat obscure. |
sigurdm
reviewed
Jun 10, 2024
|
|
||
| // Check that you can unignore certain files too. | ||
| await d.dir('myapp', [ | ||
| d.file('.gitignore', '*.txt\n!foo.txt'), |
There was a problem hiding this comment.
I believe this is tested well enough in the general ignore-rules tests. Eg. here:
Line 344 in e1fbda7
|
|
||
| // Check that you can unignore certain dirs from a higher level gitignore. | ||
| await d.dir('reporoot', [ | ||
| d.file('.gitignore', '*.txt\n!myapp/'), |
There was a problem hiding this comment.
I don't think this does whatever you think it does.
myapp/ is not ignored here, so it cannot meaningfully be negated/unignored.
We could test that "/*\n!myapp/" leads to no warnings. That is already the case.
Suggested change
| d.file('.gitignore', '*.txt\n!myapp/'), | |
| d.file('.gitignore', '/*\n!myapp/'), |
|
Sounds good, that behavior seems bizarre to me but as long as we are consistent with git, that is what matters :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro test for #4300
I don't see a good mechanism for skipping individual parts of a test so this can just land after the issue is fixed (or close this and write different tests)