Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zone updates in 1.18 break a number of Angular zone tests #26906

Closed
kevmoo opened this issue Jul 18, 2016 · 5 comments
Closed

Zone updates in 1.18 break a number of Angular zone tests #26906

kevmoo opened this issue Jul 18, 2016 · 5 comments
Assignees
@alan-knight
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries
Milestone
1.18

Comments

@kevmoo
Copy link
Member

kevmoo commented Jul 18, 2016

All succeed in 1.17

See @kevmoo for repro details

Suspect commit: 6a7c037
@kevmoo kevmoo added web-libraries Issues impacting dart:html, etc., libraries area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async library-html labels Jul 18, 2016
@kevmoo kevmoo added this to the 1.18 milestone Jul 18, 2016
@kevmoo kevmoo mentioned this issue Jul 18, 2016
Closed
@kevmoo kevmoo added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Jul 18, 2016
@mit-mit
Copy link
Member

mit-mit commented Jul 18, 2016

CC @mit-mit

@kevmoo kevmoo mentioned this issue Jul 18, 2016
Closed
@alan-knight
Copy link
Contributor

Reverted the suspect commit and it seems to be working for me. Landed on Dart bots now.

@alan-knight
Copy link
Contributor

There seems to be a bug in Angular2 that the el function is defined in two places, so it doesn't compile with dart2js. If I fix that it runs there as well.

@kevmoo
Copy link
Member Author

kevmoo commented Jul 18, 2016

There seems to be a bug in Angular2 that the el function is defined in two places, so it doesn't compile with dart2js. If I fix that it runs there as well.

Awesome!

@kevmoo
Copy link
Member Author

kevmoo commented Jul 18, 2016

Fixed by 30b4895 – thanks @alan-knight

Will open a merge request separately

@kevmoo kevmoo closed this as completed Jul 18, 2016
@kevmoo kevmoo mentioned this issue Jul 18, 2016
Closed
whesse added a commit that referenced this issue Jul 19, 2016
@whesse
Revert "Don't call _ensureRequestAnimationFrame in Dartium."
bde8d3e 
This reverts commit bf8eeef.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf38.

BUG=#26906

Review URL: https://codereview.chromium.org/2159183003 .
whesse added a commit that referenced this issue Jul 19, 2016
@whesse
Revert "Don't call _ensureRequestAnimationFrame in Dartium."
5e1bdc0 
This reverts commit bf8eeef.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf38.

BUG=#26906

Review URL: https://codereview.chromium.org/2159183003 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alan-knight alan-knight

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
1.18
Development

No branches or pull requests
3 participants
@kevmoo @alan-knight @mit-mit