Dart 1.19.0 breaks Angular2 change detection

[zoechi]

Dart VM version: 1.19.0-edge.c0d594c86c7a9f132a8274c8223c3a1dcdf6692c (Wed Jul 6 06:52:12 2016) on "linux_x64"

breaks change detection for async calls like ´new Future((){...})` in Angular2 beta.17

Its working fine when I switch back to

Dart VM version: 1.18.0-edge.bb96f289217952cd7d298444519fc07dca995dee (Wed Jul 6 00:20:52 2016) on "linux_x64"

[floitschG]

That might have been changes I did.
Do you have an example I could use to debug?

[floitschG]

/cc @mit-mit, @kevmoo, @whesse: This is probably a release-blocker.

[whesse]

I'm not sure that this would be a release blocker for 1.18, since this is not on that dev branch.

This could also be due to a change in which packages are checked out, when the version number changed. Could you check the output of pub get (or the pubspec.lock file) for your project, under the two versions? I know test needed to be updated, and maybe other packages are choosing different versions.

The two versions you have tested differ by just 2 commits: The version number change, and a documentation change. So I would suspect the version change had an impact. You could override the project, running with the 1.19 SDK, with the package versions from the 1.18 version of pub get, to see if that fixes it.

[zoechi]

Test was already updated to support Dart 1.19. I'll try to create a reproduction project but I don't know if I will be able to do it before my vacation next week.

[zoechi]

I won't be able to set up a project, I have to go.

What I did is something like

String someProp = 'init';
ngOnInit() {
  new Future(() => this.someProp = 'foo');
}

which should invoke change detection after the future completed to update, but doesn't (only after some other event (mouse click, ...) invokes change detection.

{{someProp}} in the view, but the binding is only updated

[whesse]

Let's verify that this is not on 1.18.0-dev.4.0, before releasing it to stable.

[zoechi]

I can reproduce in
Dart VM version: 1.19.0-edge.b43b9bad862f8c9b42981e437703a2aef804c7e9 (Fri Jul 15 14:31:57 2016) on "linux_x64"

[kevmoo]

@zoechi have you tried 1.18-dev?

Trying to see if this is related to #26906

[kevmoo]

Putting in 1.18 to see if it's related to #26906

[whesse]

The original submission indicated it was not in 1.18.0-dev, I just wanted
someone to make absolutely certain of it, if possible. We are rather
certain it isn't in 1.18.

On Mon, Jul 18, 2016 at 9:55 PM, Kevin Moore notifications@github.com
wrote:

Putting in 1.18 to see if it's related to #26906
#26906

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26839 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AErap4OCKP3Zxe9vVoGxzAvZ5rACN-LAks5qW9ohgaJpZM4JHwje
.

William Hesse

[kevmoo]

The original submission indicated it was not in 1.18.0-dev, I just wanted
someone to make absolutely certain of it, if possible. We are rather
certain it isn't in 1.18.

If that's the case, feel free to remove the milestone – or push it back to 1.19. Just being careful.

[mit-mit]

Bumping to 1.19

[zoechi]

I don't know if the related code is included in

Dart VM version: 1.19.0-edge.db48637ab39adfc79e981a60ab9e3d0b59671323 (Wed Jul 20 13:09:21 2016) on "linux_x64"

but after updating to this version I'm not able to reproduce the problem.

[whesse]

Since the branch for 1.18, we reverted a major change to async futures, and a change to URIs. I would suspect the change of futures, but in the original report, the problem seemed to arise exactly when we changed the version number to 1.19, so it could also have been something about the pubspec and package versions. I would like to keep this open until we reland the changes to async, to make sure it doesn't reoccur. @floitschG

[mit-mit]

@floitschG @whesse can we close this now?

[floitschG]

I haven't heard of any breakage recently. Closing for now.