Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOT RELOAD: When enum values are created during a reload the old canonical immutable array of enum values is not removed #26988

Closed
a-siva opened this issue Jul 29, 2016 · 1 comment
Closed

HOT RELOAD: When enum values are created during a reload the old canonical immutable array of enum values is not removed #26988

a-siva opened this issue Jul 29, 2016 · 1 comment
Assignees
@johnmccutchan
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload

Comments

@a-siva
Copy link
Contributor

a-siva commented Jul 29, 2016

The Canonical object verification code fails during hot reload of libraries that have enum values.
The old canonical immutable array of enum values is not removed when we create the new enum.
This results in an assertion failure.

@rmacnak-google
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload labels Jul 29, 2016
@johnmccutchan
Copy link
Contributor

We should probably remove the old canonical values array from the ImmutableArray class when we replace the enum class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnmccutchan johnmccutchan

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnmccutchan @a-siva