The Clock sample has bad data for the number 5 #273
Assignees
Labels
area-samples (deprecated)
Deprecated: this label is no longer actively used.
Comments
|
Set owner to @floitschG. |
|
Fixed in r960 (http://codereview.chromium.org/8430009/). Added Fixed label. |
DartBot
added
Type-Defect
area-samples (deprecated)
This was referenced Oct 29, 2020
copybara-service bot
pushed a commit
that referenced
this issue
Sep 20, 2022
Changes: ``` > git log --format="%C(auto) %h %s" feb2a18..1eee95b https://dart.googlesource.com/external/github.com/google/vector_math.dart.git/+/1eee95b refactor the locations of the 'noise.dart' part files (#273) https://dart.googlesource.com/external/github.com/google/vector_math.dart.git/+/8c5c72b add markdown badges; configure dependabot (#274) ``` Diff: https://dart.googlesource.com/external/github.com/google/vector_math.dart.git/+/feb2a188b1ecd863fd92500453b26a90048e71ad~..1eee95b15e5d35cf519514cc253037b19705fb7a/ Change-Id: I6da5e3e7c0950c1f2ac407455d7d4be92135c19d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260074 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Nate Bosch <nbosch@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 3, 2023
…, html, http, lints, markdown, matcher, mockito, path, protobuf, shelf, source_maps, source_span, sync_http, test, test_reflective_loader, tools, usage, vector_math, webdriver, webkit_inspection_protocol, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/5ac2ba1..1864048): 1864048 2023-05-03 Devon Carew added package topics to the pubspec file (#242) db229fb 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#241) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d5f8837..1b86d3c): 1b86d3c 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#72) characters (https://github.com/dart-lang/characters/compare/b306414..2af6783): 2af6783 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#81) cli_util (https://github.com/dart-lang/cli_util/compare/6c318c2..7234f17): 7234f17 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#82) collection (https://github.com/dart-lang/collection/compare/9db854d..26e3e67): 26e3e67 2023-05-03 Lasse R.H. Nielsen Accept SDK version above 3.0. (#281) file (https://github.com/google/file.dart/compare/72a67c3..b905180): b905180 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#212) 8158a35 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#218) html (https://github.com/dart-lang/html/compare/0438b26..5d87dc8): 5d87dc8 2023-05-03 Devon Carew added package topics to the pubspec file (#215) http (https://github.com/dart-lang/http/compare/877f134..f581ff7): f581ff7 2023-05-01 Nate Bosch Prepare to publish (#914) fa53651 2023-05-01 Brian Quinlan Document that RetryClient may consume a lot of memory (#915) lints (https://github.com/dart-lang/lints/compare/ba7d75e..17276ec): 17276ec 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#116) markdown (https://github.com/dart-lang/markdown/compare/82b050d..6db8fc1): 6db8fc1 2023-05-02 Jonas Finnemann Jensen Prepare 7.1.0 (#538) matcher (https://github.com/dart-lang/matcher/compare/7228c26..5890f2b): 5890f2b 2023-05-01 Nate Bosch Expand bound for `test_api` dependency (#219) mockito (https://github.com/dart-lang/mockito/compare/beb45ba..56173fa): 56173fa 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#626) path (https://github.com/dart-lang/path/compare/23e3319..1552cfd): 1552cfd 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#142) 82ddc60 2023-05-01 Jonathan fixed mistake in split method doc comment (#141) protobuf (https://github.com/dart-lang/protobuf/compare/b90a4c4..9d7cf0d): 9d7cf0d 2023-05-01 Kevin Moore Update Github Actions (#827) shelf (https://github.com/dart-lang/shelf/compare/9a792b4..79e3cee): 79e3cee 2023-05-03 Devon Carew add package topics for package:shelf_router_generator (#346) 25861e5 2023-05-03 Devon Carew add topics to the pubspec files (#345) source_maps (https://github.com/dart-lang/source_maps/compare/0a4b030..f0a8506): f0a8506 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#77) source_span (https://github.com/dart-lang/source_span/compare/905a167..69fa991): 69fa991 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#97) sync_http (https://github.com/dart-lang/sync_http/compare/660ad87..c3d6ad4): c3d6ad4 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#36) test (https://github.com/dart-lang/test/compare/b252463..9484592): 9484592a 2023-05-02 Nate Bosch Prepare to publish checks (#2005) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/a85a930..d1b763f): d1b763f 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#48) tools (https://github.com/dart-lang/tools/compare/516995e..b55f0d4): b55f0d4 2023-05-02 Elias Yishak `pddFlag` removal + tests for pdd restricted instance of `Analytics` (#86) usage (https://github.com/dart-lang/usage/compare/f97752f..929a4e3): 929a4e3 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#193) vector_math (https://github.com/google/vector_math.dart/compare/7dec984..e3de8da): e3de8da 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#291) webdriver (https://github.com/google/webdriver.dart/compare/562aa06..d0f78d0): d0f78d0 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#273) 1ef3348 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#275) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/8401098..39a3c29): 39a3c29 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#102) 5555c53 2023-05-01 dependabot[bot] Bump nanasess/setup-chromedriver from 1.1.0 to 2.0.0 (#101) 9adce2a 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#103) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/5f392a1..e05282b): e05282b 2023-05-02 Jonas Finnemann Jensen Prepare 2.1.1 release (#52) Change-Id: Iee7fd84d32ae37b76147d62c2268df19cf8db95b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300863 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Jun 22, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/793d575..4757339): 47573391 2023-06-21 Sam Rawlins Remove dependency on code_builder (#3451) 370cb2c4 2023-06-21 Sam Rawlins Remove all use of package:build (#3448) 70c2897b 2023-06-20 Sam Rawlins Simplify some code in PackageBuilder (#3447) 1a8403ec 2023-06-20 Sam Rawlins Rank libraries lower than classes and class members (#3446) lints (https://github.com/dart-lang/lints/compare/4b79906..79581ff): 79581ff 2023-06-20 Devon Carew update core and recommended from the recent review (#136) test (https://github.com/dart-lang/test/compare/3d5afed..cdc8178): cdc8178b 2023-06-21 Nate Bosch Ignore a false positive for unreachable_from_main (#2041) vector_math (https://github.com/google/vector_math.dart/compare/a3aca09..c147038): c147038 2023-06-20 Lukas Klingsbo `Vector2` constructor benchmark (#297) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/af72652..7fb82f2): 7fb82f2 2023-06-21 Brian Quinlan Add a note explaining why the onerror doesn't generate a more detailed exception (#273) webdev (https://github.com/dart-lang/webdev/compare/b58edb7..6fe17fe): 6fe17fe8 2023-06-21 Elliott Brooks Prepare Webdev `3.0.5` release (#2151) 3b7f266c 2023-06-21 Elliott Brooks Small fixes for the `release` script (#2150) 45446ec9 2023-06-20 Elliott Brooks Reset DWDS to `19.0.2-wip` (#2149) 91cbd183 2023-06-20 Elliott Brooks Prepare DWDS for release to version 19.0.1 (#2145) a7b81589 2023-06-20 Elliott Brooks Don't run proper_release_test with the rest of the test common tests (#2146) aa586d29 2023-06-20 Elliott Brooks Fix DCM errors in `chrome_proxy_service.dart` (#2148) Change-Id: I27850a0b8b1241b03f07a5832555d4da6dfbff44 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310962 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by jaywg...@gmail.com
The file:
'dart\samples\clock\ClockNumbers.dart'
for the data array for the number 5 has too many lines.
Line 54 (or 52 or 53) needs to be deleted.
The text was updated successfully, but these errors were encountered: