Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List.setRange should work for non-extensible arrays. #291

Closed
madsager opened this issue Nov 1, 2011 · 4 comments
Closed

List.setRange should work for non-extensible arrays. #291

madsager opened this issue Nov 1, 2011 · 4 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.

Comments

@madsager
Copy link
Contributor

madsager commented Nov 1, 2011

List.setRange is specified as throwing an exception on non-extensible arrays. I think this is too restrictive?

List.setRange should work for non-extensible arrays (as long as the indices are within range).

var l = new Array(3);
l.setRange(0, 3, [1, 2, 3]);

This works in the VM (once http://codereview.chromium.org/8431028/ which fixes a bug in it lands) but does not work in dartc. I have added a test to tests/corelib/src/ListSetRangeTest and will add it to the status file for dartc.
@DartBot
Copy link

DartBot commented Feb 7, 2012

This comment was originally written by zundel@google.com

Code generation for dartc is going away.

Added WontFix label.

@lexprfuncall
Copy link

Set owner to @lexprfuncall.

@lexprfuncall
Copy link

Added Accepted label.

@lexprfuncall
Copy link

http://codereview.chromium.org/9561005/

Added Fixed label.

@madsager madsager added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Mar 16, 2012
@MananKakadiya MananKakadiya mentioned this issue Sep 25, 2018
Closed
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue May 3, 2023
@devoncarew
[deps] rev args, bazel_worker, characters, cli_util, collection, file…
5797e7e 
…, html, http, lints, markdown, matcher, mockito, path, protobuf, shelf, source_maps, source_span, sync_http, test, test_reflective_loader, tools, usage, vector_math, webdriver, webkit_inspection_protocol, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/5ac2ba1..1864048):
  1864048  2023-05-03  Devon Carew  added package topics to the pubspec file (#242)
  db229fb  2023-05-02  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#241)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d5f8837..1b86d3c):
  1b86d3c  2023-05-02  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#72)

characters (https://github.com/dart-lang/characters/compare/b306414..2af6783):
  2af6783  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#81)

cli_util (https://github.com/dart-lang/cli_util/compare/6c318c2..7234f17):
  7234f17  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#82)

collection (https://github.com/dart-lang/collection/compare/9db854d..26e3e67):
  26e3e67  2023-05-03  Lasse R.H. Nielsen  Accept SDK version above 3.0. (#281)

file (https://github.com/google/file.dart/compare/72a67c3..b905180):
  b905180  2023-05-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#212)
  8158a35  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.2 (#218)

html (https://github.com/dart-lang/html/compare/0438b26..5d87dc8):
  5d87dc8  2023-05-03  Devon Carew  added package topics to the pubspec file (#215)

http (https://github.com/dart-lang/http/compare/877f134..f581ff7):
  f581ff7  2023-05-01  Nate Bosch  Prepare to publish (#914)
  fa53651  2023-05-01  Brian Quinlan  Document that RetryClient may consume a lot of memory (#915)

lints (https://github.com/dart-lang/lints/compare/ba7d75e..17276ec):
  17276ec  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#116)

markdown (https://github.com/dart-lang/markdown/compare/82b050d..6db8fc1):
  6db8fc1  2023-05-02  Jonas Finnemann Jensen  Prepare 7.1.0 (#538)

matcher (https://github.com/dart-lang/matcher/compare/7228c26..5890f2b):
  5890f2b  2023-05-01  Nate Bosch  Expand bound for `test_api` dependency (#219)

mockito (https://github.com/dart-lang/mockito/compare/beb45ba..56173fa):
  56173fa  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#626)

path (https://github.com/dart-lang/path/compare/23e3319..1552cfd):
  1552cfd  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#142)
  82ddc60  2023-05-01  Jonathan  fixed mistake in split method doc comment (#141)

protobuf (https://github.com/dart-lang/protobuf/compare/b90a4c4..9d7cf0d):
  9d7cf0d  2023-05-01  Kevin Moore  Update Github Actions (#827)

shelf (https://github.com/dart-lang/shelf/compare/9a792b4..79e3cee):
  79e3cee  2023-05-03  Devon Carew  add package topics for package:shelf_router_generator (#346)
  25861e5  2023-05-03  Devon Carew  add topics to the pubspec files (#345)

source_maps (https://github.com/dart-lang/source_maps/compare/0a4b030..f0a8506):
  f0a8506  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#77)

source_span (https://github.com/dart-lang/source_span/compare/905a167..69fa991):
  69fa991  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#97)

sync_http (https://github.com/dart-lang/sync_http/compare/660ad87..c3d6ad4):
  c3d6ad4  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#36)

test (https://github.com/dart-lang/test/compare/b252463..9484592):
  9484592a  2023-05-02  Nate Bosch  Prepare to publish checks (#2005)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/a85a930..d1b763f):
  d1b763f  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#48)

tools (https://github.com/dart-lang/tools/compare/516995e..b55f0d4):
  b55f0d4  2023-05-02  Elias Yishak  `pddFlag` removal + tests for pdd restricted instance of `Analytics` (#86)

usage (https://github.com/dart-lang/usage/compare/f97752f..929a4e3):
  929a4e3  2023-05-02  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#193)

vector_math (https://github.com/google/vector_math.dart/compare/7dec984..e3de8da):
  e3de8da  2023-05-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#291)

webdriver (https://github.com/google/webdriver.dart/compare/562aa06..d0f78d0):
  d0f78d0  2023-05-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#273)
  1ef3348  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.2 (#275)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/8401098..39a3c29):
  39a3c29  2023-05-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#102)
  5555c53  2023-05-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 1.1.0 to 2.0.0 (#101)
  9adce2a  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.2 (#103)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/5f392a1..e05282b):
  e05282b  2023-05-02  Jonas Finnemann Jensen  Prepare 2.1.1 release (#52)

Change-Id: Iee7fd84d32ae37b76147d62c2268df19cf8db95b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300863
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 4, 2023
@devoncarew
[deps] rev browser_launcher, ecosystem, http_multi_server, markdown, …
ff80836 
…mime, protobuf, pub_semver, sse, string_scanner, term_glyph, test, test_reflective_loader, typed_data, vector_math, web, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/f60df1d..c68ec25):
  c68ec25  2023-12-04  Kevin Moore  drop outdated lints

ecosystem (https://github.com/dart-lang/ecosystem/compare/805ab4f..79a1bc5):
  79a1bc5  2023-12-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#204)
  c51c500  2023-12-01  dependabot[bot]  Bump actions/github-script (#202)
  64eeeee  2023-12-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#203)
  32461a7  2023-12-01  Moritz  Upgrades to `health.yaml` (#201)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/2238a6b..ae48489):
  ae48489  2023-12-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#61)

markdown (https://github.com/dart-lang/markdown/compare/3774ad0..d2e7903):
  d2e7903  2023-12-01  dependabot[bot]  Bump subosito/flutter-action from 2.11.0 to 2.12.0 (#569)
  42d32cb  2023-11-30  Kevin Moore  Update to latest lints, require Dart ^3.1 (#568)

mime (https://github.com/dart-lang/mime/compare/8ebf946..56359b0):
  56359b0  2023-12-05  Yoshihiro Tanaka  Detect HEIC/HEIF format by checking header bytes (#109)

protobuf (https://github.com/dart-lang/protobuf/compare/dcec2ed..bb19774):
  bb19774  2023-11-29  Ömer Sinan Ağacan  Revert `PbMap._wrappedMap` empty map value (#904)
  cf43230  2023-11-23  Ömer Sinan Ağacan  Update getList and getMap return types (#903)
  4e0bdff  2023-11-23  Ömer Sinan Ağacan  Make wrapped lists in PbList monomorphic (#902)

pub_semver (https://github.com/dart-lang/pub_semver/compare/f9e94ee..4572181):
  4572181  2023-12-04  Kevin Moore  drop outdated lints (#96)

sse (https://github.com/dart-lang/sse/compare/1df63f2..8d2e2f0):
  8d2e2f0  2023-12-01  dependabot[bot]  Bump nanasess/setup-chromedriver (#99)
  c6501b3  2023-12-01  Kevin Moore  Drop unneeded dep on pkg:test (#98)

string_scanner (https://github.com/dart-lang/string_scanner/compare/a7105ef..ebc30a3):
  ebc30a3  2023-12-04  Kevin Moore  Update to latest lints and cleanup (#67)

term_glyph (https://github.com/dart-lang/term_glyph/compare/7c1eb9d..4c5a496):
  4c5a496  2023-12-04  Kevin Moore  drop outdated lints (#46)

test (https://github.com/dart-lang/test/compare/a0a4d1e..9fffb48):
  9fffb489  2023-12-01  dependabot[bot]  Bump github/codeql-action from 2.22.5 to 2.22.8 (#2145)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/17d40bb..6edf535):
  6edf535  2023-11-30  Kevin Moore  Update lints, bump min SDK to ^3.1.0 (#56)

typed_data (https://github.com/dart-lang/typed_data/compare/0b16bd2..6f6d81d):
  6f6d81d  2023-12-04  Kevin Moore  drop outdated lints (#78)

vector_math (https://github.com/google/vector_math.dart/compare/cca3cf1..38a00c3):
  38a00c3  2023-12-04  Kevin Moore  Update to latest lints and cleanup (#309)
  cedd304  2023-12-04  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#307)

web (https://github.com/dart-lang/web/compare/cffc2e3..865aeaf):
  865aeaf  2023-12-01  Devon Carew  update the CI workflow to test the generation script (#112)

webdriver (https://github.com/google/webdriver.dart/compare/43ed1db..2c1b6f8):
  2c1b6f8  2023-12-01  dependabot[bot]  Bump nanasess/setup-chromedriver (#290)
  dc988d7  2023-12-01  Devon Carew  update to the latest package:lints (#291)

Change-Id: I2d898b6d772925146630777ef587d29a05288a3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339720
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madsager @lexprfuncall @DartBot