Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add front_end package source to the SDK. #27857

Closed
pq opened this issue Nov 18, 2016 · 2 comments
Closed

Add front_end package source to the SDK. #27857

pq opened this issue Nov 18, 2016 · 2 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter

Comments

@pq
Copy link
Member

pq commented Nov 18, 2016

Flutter vends in the analyzer package from the source in the SDK. Now that the analyzer depends on front_end we need to do the same with it which means we need it's source handy.

/cc @bwilkerson @whesse
@pq
Copy link
Member Author

pq commented Nov 19, 2016

https://codereview.chromium.org/2506253008/

@kasperl kasperl added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Nov 21, 2016
@pq pq closed this as completed in dbb3cd5 Nov 21, 2016
@pq
Copy link
Member Author

pq commented Nov 21, 2016

Fixed w/ dbb3cd5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. customer-flutter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @kasperl