Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make modular kernel tree-shaker agnostic transformers #29954

Open
sigmundch opened this issue Jun 20, 2017 · 1 comment
Open

make modular kernel tree-shaker agnostic transformers #29954

sigmundch opened this issue Jun 20, 2017 · 1 comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. P3 A lower priority bug or feature request

Comments

@sigmundch
Copy link
Member

The modular kernel tree-shaker in package:front_end is breaking encapsulation: it contains hard-coded knowledge about methods that may be used by some transformations (like some helper methods for async/await).

Possible solutions to avoid this:

  • declare used members in transformers: this might be exposed as methods in kernel.Transformer and kernel.Target that, given a program/CoreTypes, they return a set of members that are expected to exist.
  • transformers inject an external declaration for members used: this might not be that easy to for modular transformers though.

/cc @kmillikin

@sigmundch sigmundch added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Jun 20, 2017
@sigmundch sigmundch added the P3 A lower priority bug or feature request label Nov 28, 2017
@sigmundch
Copy link
Member Author

We are not planning on using the tree-shaker for some time, marking this as low-priority for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

1 participant