Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM: gen_snapshot does not escape paths with spaces when generating depfiles #30059

Closed
rmacnak-google opened this issue Jun 30, 2017 · 2 comments
Closed

VM: gen_snapshot does not escape paths with spaces when generating depfiles #30059

rmacnak-google opened this issue Jun 30, 2017 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@rmacnak-google
Copy link
Contributor

This will break users that have their Flutter project in a directory whose name includes a space

@cbracken
@rmacnak-google rmacnak-google added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jun 30, 2017
@cbracken
Copy link
Member

@jakobr-google
FYI for the gradle code that parses this here:
https://github.com/flutter/flutter/blob/2d79ce8419db5b72a3b67e072e76edb43903d3ea/packages/flutter_tools/gradle/flutter.gradle#L344

@cbracken cbracken mentioned this issue Jun 30, 2017
Closed
@jakobr-google
Copy link
Contributor

/cc @mravn-google

@cbracken cbracken mentioned this issue Jul 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbracken @rmacnak-google @jakobr-google